On Sat, 21 Aug 1999 16:59:38 MST, "Jordan K. Hubbard" wrote:
> http://www.freebsd.org/~jkh/etc.diffs.fix-it-right
>
> Which I've sent to Sheldon for review but haven't heard anything
> back from him yet.
Universal Week-end Time. :-P
Ciao,
Sheldon.
To Unsubscribe: send mail to [EMAIL
On Fri, 20 Aug 1999 11:59:05 MST, Doug wrote:
> However I'd REALLY like to emphasize again that if we're going to do
> this the proper fix is to use case wherever possible.
>
> I have offered several times to do the work if it has a chance of
> being committed, that offer is still good.
Hi Dou
"Jordan K. Hubbard" wrote:
>
> > The X also protected test from the case where the expansion included a
> > string like "-x", although with most modern implementations of test (or
> > shells with test as a builtin) this is no longer a problem.
>
> And certainly not in any of these cases. :
> The X also protected test from the case where the expansion included a
> string like "-x", although with most modern implementations of test (or
> shells with test as a builtin) this is no longer a problem.
And certainly not in any of these cases. :)
> I agree with some of your changes
"Jordan K. Hubbard" wrote:
>
> > I gather the reason for using the X trick *and* the quotes is because there
> > might be some whitespace in there, too.
>
> Actually, that's mostly just historical legacy. When the quotes, it's
> safe even if the expansion is empty or contains whitespace.
> I gather the reason for using the X trick *and* the quotes is because there
> might be some whitespace in there, too.
Actually, that's mostly just historical legacy. When the quotes, it's
safe even if the expansion is empty or contains whitespace. I got
kinda annoyed with this last night and
I understand that folks use X$foo becuase if $foo evaluates to -whatever
then there is a *chance* that test will misunderstand.
I gather the reason for using the X trick *and* the quotes is because there
might be some whitespace in there, too.
Given that "case" is a builtin and using "case" inst
Warner Losh wrote:
>
> In message <[EMAIL PROTECTED]> Sheldon Hearn writes:
> : -if [ X$start_vinum = XYES ]; then
> : +if [ X"${start_vinum}" = X"YES" ]; then
>
> I never understood why you check against X"YES"? XYES always seemed
> much better than X"YES" since the latter is somewhat obscure.
> However I'd REALLY like to emphasize again that if we're going to do
> this the proper fix is to use case wherever possible. There are
> numerous reasons for this, not the least of which are making the
> variable case insensitive (and therefore more user friendly)
I have to really agree with Do
In message <[EMAIL PROTECTED]> Sheldon Hearn writes:
: -if [ X$start_vinum = XYES ]; then
: +if [ X"${start_vinum}" = X"YES" ]; then
I never understood why you check against X"YES"? XYES always seemed
much better than X"YES" since the latter is somewhat obscure. Both
are identical...
Warner
On Fri, 20 Aug 1999, Sheldon Hearn wrote:
>
> Hi folks,
>
> I have a diff for src/etc/rc that I'd like to have had used on a few
> machines before I commit it. I'm pretty sure I haven't made any mistakes
> with my changes, but you can never be too careful, right?
>
> The diff homogenizes the m
>
> Hi folks,
>
> I have a diff for src/etc/rc that I'd like to have had used on a few
> machines before I commit it. I'm pretty sure I haven't made any mistakes
> with my changes, but you can never be too careful, right?
Right...
>
> The diff homogenizes the manner in which variables are tes
Hi folks,
I have a diff for src/etc/rc that I'd like to have had used on a few
machines before I commit it. I'm pretty sure I haven't made any mistakes
with my changes, but you can never be too careful, right?
The diff homogenizes the manner in which variables are tested and is
more careful abo
13 matches
Mail list logo
