Re: Please review newbus patch for amd and adv

2000-04-04 Thread Warner Losh
In message <[EMAIL PROTECTED]> Takahashi Yoshihiro writes: : There is not ISA bus on PC-98. So, we can't use devices for ISA bus on : PC-98. But, PC-98 has `Cbus' which is like ISA bus in software place. : As most codes for ISA bus are useful for Cbus, the code for Cbus is : based on the code for

Re: Please review newbus patch for amd and adv

2000-04-03 Thread Takahashi Yoshihiro
In article <[EMAIL PROTECTED]> Brian Somers <[EMAIL PROTECTED]> writes: > I'm afraid this code fails in bus_alloc_resource(...SYS_RES_IOPORT...). > I know nothing about what that does, but notice that the old code > didn't even call pci_map_port() (which makes the compat code call > bus_alloc_r

Re: Please review newbus patch for amd and adv

2000-04-03 Thread Takahashi Yoshihiro
In article <[EMAIL PROTECTED]> Warner Losh <[EMAIL PROTECTED]> writes: > In message <[EMAIL PROTECTED]> Takahashi Yoshihiro >writes: > : Because, adv_isa.c is not required by PC-98, PC-98 requires only PCI > : frontend. Then it contains isa_dmacascade function which does not > : exist and is not

Re: Please review newbus patch for amd and adv

2000-04-03 Thread Brian Somers
> I converted the amd and adv drivers to new-bus. But, as I am not > familiar with these drivers and new-bus, maybe I have mistaken. > > Will somebody please review these changes? > > For amd driver: > http://home.jp.FreeBSD.org/~nyan/patches/amd.diff.gz Hi, I'm afraid this code fails in bus_a

Re: Please review newbus patch for amd and adv

2000-04-02 Thread Warner Losh
In message <[EMAIL PROTECTED]> Takahashi Yoshihiro writes: : Because, adv_isa.c is not required by PC-98, PC-98 requires only PCI : frontend. Then it contains isa_dmacascade function which does not : exist and is not needed for PC-98. Is that because there's not isa bus on a pc-98? Or that the a

Re: Please review newbus patch for amd and adv

2000-04-02 Thread Takahashi Yoshihiro
In article <[EMAIL PROTECTED]> Warner Losh <[EMAIL PROTECTED]> writes: > In message <[EMAIL PROTECTED]> Takahashi Yoshihiro writes: > : For adv driver: > : http://home.jp.FreeBSD.org/~nyan/patches/advansys.diff.gz > > I took a look at this change. For the most part it looks good. Thanks. > Ho

Re: Please review newbus patch for amd and adv

2000-04-02 Thread Warner Losh
In message <[EMAIL PROTECTED]> Takahashi Yoshihiro writes: : For adv driver: : http://home.jp.FreeBSD.org/~nyan/patches/advansys.diff.gz I took a look at this change. For the most part it looks good. However, I have a question. Why did you move the adv_isa into the md files file and then commen

Please review newbus patch for amd and adv

2000-04-02 Thread Takahashi Yoshihiro
I converted the amd and adv drivers to new-bus. But, as I am not familiar with these drivers and new-bus, maybe I have mistaken. Will somebody please review these changes? For amd driver: http://home.jp.FreeBSD.org/~nyan/patches/amd.diff.gz For adv driver: http://home.jp.FreeBSD.org/~nyan/patch