Re: PATCH: Removal of unneeded

2000-04-27 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Will Andrews writes: >On Fri, Apr 28, 2000 at 07:45:36AM +0200, Poul-Henning Kamp wrote: >> I agree too, but nobody has written *that* code yet. > >Instead of trying to find these yourself, why not invest this time in >writing said script? :) I already wrote src/to

Re: PATCH: Removal of unneeded

2000-04-27 Thread Will Andrews
On Fri, Apr 28, 2000 at 07:45:36AM +0200, Poul-Henning Kamp wrote: > I agree too, but nobody has written *that* code yet. Instead of trying to find these yourself, why not invest this time in writing said script? :) (I'm not volunteering for this.. ;-) -- Will Andrews <[EMAIL PROTECTED]> GCS/E

Re: PATCH: Removal of unneeded

2000-04-27 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Donn Miller writes: >Will Andrews wrote: >> >> On Wed, Apr 26, 2000 at 11:50:11AM +0200, Poul-Henning Kamp wrote: > >> > Comments, tests and reviews please. >> >> Just write a script to check all #include's against their prototypes and >> have it autogen diffs. >

Re: PATCH: Removal of unneeded

2000-04-27 Thread Donn Miller
Will Andrews wrote: > > On Wed, Apr 26, 2000 at 11:50:11AM +0200, Poul-Henning Kamp wrote: > > Comments, tests and reviews please. > > Just write a script to check all #include's against their prototypes and > have it autogen diffs. I agree. I like the automated method better. What happens i

Re: PATCH: Removal of unneeded

2000-04-27 Thread Will Andrews
On Wed, Apr 26, 2000 at 11:50:11AM +0200, Poul-Henning Kamp wrote: > New patch at: http://phk.freebsd.dk/misc/sys_kernel_h.patch > > This patch removes 67 unneeded instances of #include > > Comments, tests and reviews please. Just write a script to check all #include's against their prototypes

Re: PATCH: Removal of unneeded

2000-04-27 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Brian Somers writes: >> Yes, the src/tools/tools/kerninclude script first renames the include >> and if the source file still compiles it declares a "no-read" and >> leaves the #include intact. > >The thing that's screwed me up the most doing this sort of thing is

Re: PATCH: Removal of unneeded

2000-04-27 Thread Brian Somers
> In message <[EMAIL PROTECTED]>, Greg Lehey writes: > >On Wednesday, 26 April 2000 at 11:50:11 +0200, Poul-Henning Kamp wrote: > >> > >> New patch at: http://phk.freebsd.dk/misc/sys_kernel_h.patch > >> > >> This patch removes 67 unneeded instances of #include > >> > >> Comments, tests and review

Re: PATCH: Removal of unneeded

2000-04-26 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Greg Lehey writes: >On Wednesday, 26 April 2000 at 11:50:11 +0200, Poul-Henning Kamp wrote: >> >> New patch at: http://phk.freebsd.dk/misc/sys_kernel_h.patch >> >> This patch removes 67 unneeded instances of #include >> >> Comments, tests and reviews please. > >Hav

Re: PATCH: Removal of unneeded

2000-04-26 Thread Greg Lehey
On Wednesday, 26 April 2000 at 11:50:11 +0200, Poul-Henning Kamp wrote: > > New patch at: http://phk.freebsd.dk/misc/sys_kernel_h.patch > > This patch removes 67 unneeded instances of #include > > Comments, tests and reviews please. Have you checked that there are no references which are #ifdefe

PATCH: Removal of unneeded

2000-04-26 Thread Poul-Henning Kamp
New patch at: http://phk.freebsd.dk/misc/sys_kernel_h.patch This patch removes 67 unneeded instances of #include Comments, tests and reviews please. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.