Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-12-25 Thread Hans Petter Selasky
On 12/06/16 11:04, Hans Petter Selasky wrote: On 11/24/16 14:11, Vsevolod Stakhov wrote: Then I don't understand how your patch should affect the solving procedure. If pkg tries to reinstall something without *reason* it is a good sign of bug in pkg itself and/or your database/repo and not in S

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-12-06 Thread Hans Petter Selasky
On 11/24/16 14:11, Vsevolod Stakhov wrote: Then I don't understand how your patch should affect the solving procedure. If pkg tries to reinstall something without *reason* it is a good sign of bug in pkg itself and/or your database/repo and not in SAT solver. I'll try to review your issue but I

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-29 Thread David Chisnall
On 23 Nov 2016, at 18:11, A. Wilcox wrote: > > Or you could just, I don't know, email the diff as a patch using git > send-email like normal people instead of using GitHub's walled garden. > That way, people without GitHub accounts can still comment on it. GitHub pull requests are branches in th

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-29 Thread A. Wilcox
On 23/11/16 10:47, Ed Schouten wrote: > 2016-11-23 17:41 GMT+01:00 Hans Petter Selasky : >> GitHub wouldn't allow me to make a .diff attachment. > > But there's absolutely no need for doing that in the first place! :-) > > 1. Go to https://github.com/freebsd/pkg > 2. Click 'Fork' on the top right

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-24 Thread Ed Schouten
2016-11-24 13:13 GMT+01:00 Vsevolod Stakhov : > On 23/11/2016 16:27, Ed Schouten wrote: >> Hi Hans, >> >> 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : >>> I've made a patch to hopefully optimise SAT solving in our pkg utility. >> >> Nice! Do you by any chance have any numbers that show the perf

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-24 Thread Hans Petter Selasky
On 11/24/16 14:11, Vsevolod Stakhov wrote: On 24/11/2016 13:05, Hans Petter Selasky wrote: On 11/24/16 13:13, Vsevolod Stakhov wrote: On 23/11/2016 16:27, Ed Schouten wrote: Hi Hans, 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : I've made a patch to hopefully optimise SAT solving in our p

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-24 Thread Hans Petter Selasky
On 11/24/16 14:05, Hans Petter Selasky wrote: the non-patched version wants to reinstall 1 package. Spelling: patched version wants to reinstall 1 package only. --HPS ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/list

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-24 Thread Vsevolod Stakhov
On 24/11/2016 13:05, Hans Petter Selasky wrote: > On 11/24/16 13:13, Vsevolod Stakhov wrote: >> On 23/11/2016 16:27, Ed Schouten wrote: >>> Hi Hans, >>> >>> 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : I've made a patch to hopefully optimise SAT solving in our pkg utility. >>> >>> Nice! Do

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-24 Thread Hans Petter Selasky
On 11/24/16 13:13, Vsevolod Stakhov wrote: On 23/11/2016 16:27, Ed Schouten wrote: Hi Hans, 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : I've made a patch to hopefully optimise SAT solving in our pkg utility. Nice! Do you by any chance have any numbers that show the performance improveme

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-24 Thread Vsevolod Stakhov
On 23/11/2016 16:27, Ed Schouten wrote: > Hi Hans, > > 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : >> I've made a patch to hopefully optimise SAT solving in our pkg utility. > > Nice! Do you by any chance have any numbers that show the performance > improvements made by this change? Assuming

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-23 Thread Konstantin Tokarev
23.11.2016, 19:42, "Hans Petter Selasky" : > On 11/23/16 17:27, Ed Schouten wrote: >>  Hi Hans, >> >>  2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : >>>  I've made a patch to hopefully optimise SAT solving in our pkg utility. >> >>  Nice! Do you by any chance have any numbers that show the per

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-23 Thread Ed Schouten
2016-11-23 17:41 GMT+01:00 Hans Petter Selasky : > GitHub wouldn't allow me to make a .diff attachment. But there's absolutely no need for doing that in the first place! :-) 1. Go to https://github.com/freebsd/pkg 2. Click 'Fork' on the top right. This will probably create a https://github.com/hs

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-23 Thread Hans Petter Selasky
On 11/23/16 17:27, Ed Schouten wrote: Hi Hans, 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : I've made a patch to hopefully optimise SAT solving in our pkg utility. Nice! Do you by any chance have any numbers that show the performance improvements made by this change? Hi Ed, I tried mea

Re: Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-23 Thread Ed Schouten
Hi Hans, 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky : > I've made a patch to hopefully optimise SAT solving in our pkg utility. Nice! Do you by any chance have any numbers that show the performance improvements made by this change? Assuming that the SAT solver of pkg(1) uses an algorithm simi

Optimising generated rules for SAT solving (5/12 are duplicates)

2016-11-23 Thread Hans Petter Selasky
FYI I've made a patch to hopefully optimise SAT solving in our pkg utility. https://github.com/freebsd/pkg/issues/1505 --HPS ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send a