Re: Need help fixing failing locale tests

Craig Rodrigues wrote: > I don't know much about locales, so don't know what to do. I find LANG=C LC_ALL=C solves most locale induced issues. I suspect the tests in question assume the above anyway. ___ freebsd-current@freebsd.org mailing list https://l

Re: Need help fixing failing locale tests

On 11/15/2015 4:38 PM, Andrey Chernov wrote: > On 15.11.2015 18:17, John Marino wrote: >> >> For the traditional checks, It's ironic, DragonFly uses short locales >> like "fr_FR" which link to the approprioprate ISO8859 or UTF-8 locale. >> Bapt removed them to avoid a bike shed and if he had not do

Re: Need help fixing failing locale tests

On 11/15/2015 3:59 PM, Andrey Chernov wrote: > On 15.11.2015 17:47, John Marino wrote: Please provide an example of such a program (in ports). >>> >>> See gettext-0.19.6/gettext-tools/configure, part started with >>> # Test for the usual locale name. >>> I don't have time to dig more such code

Re: Need help fixing failing locale tests

Documentation on any existing regressions and how they are expected to fail would be a good thing… Change is necessary, but so is modification of a regression to continue to pass (or fail) as expected. Demonstration of the unit testing process can also be very beneficial. : mdm > On Nov 15, 2015,

Re: Need help fixing failing locale tests

John Marino wrote on 11/15/2015 15:47: On 11/15/2015 3:39 PM, Andrey Chernov wrote: As I already say, I don't want to insist on any particular point of view in such area as human behavior. I just say that it is POLA violation (even while it is upgrade) and we can let users decide by themselves,

Re: Need help fixing failing locale tests

FWIW; While I personally don’t use it, Latin is the official language for the Holy See [1]. I think it is still taught in schools in Italy for cultural reasons and because it’s supposed to make easier to learn other “romance” languages. It shouldn't hurt to keep it but I have no strong opinion.

Re: Need help fixing failing locale tests

On 15.11.2015 18:38, Andrey Chernov wrote: >> For the traditional checks, It's ironic, DragonFly uses short locales >> like "fr_FR" which link to the approprioprate ISO8859 or UTF-8 locale. >> Bapt removed them to avoid a bike shed and if he had not done that, this >> gettext configure would not be

Re: Need help fixing failing locale tests

On 15.11.2015 18:17, John Marino wrote: See gettext-0.19.6/gettext-tools/configure, part started with # Test for the usual locale name. I don't have time to dig more such code now, but I remember I saw more for sure. > Of course it's the same topic. > If the configure of a port

Re: Need help fixing failing locale tests

On 11/15/2015 3:39 PM, Andrey Chernov wrote: > As I already say, I don't want to insist on any particular point of view > in such area as human behavior. I just say that it is POLA violation > (even while it is upgrade) and we can let users decide by themselves, > what it best for them (without me

Re: Need help fixing failing locale tests

On 15.11.2015 18:01, Baptiste Daroussin wrote: > I have restored the 8859-1 Thanx! BTW, speaking with John I find at least one configure script from ports which depends on 8859-1 presence. See gettext-0.19.6/gettext-tools/configure, part started with # Test for the usual locale name. -- http://a

Re: Need help fixing failing locale tests

On Sun, Nov 15, 2015 at 04:04:33PM +0300, Andrey Chernov wrote: > On 15.11.2015 16:00, Baptiste Daroussin wrote: > > On Sun, Nov 15, 2015 at 03:56:26PM +0300, Andrey Chernov wrote: > >> On 15.11.2015 15:46, Baptiste Daroussin wrote: > >>> On Sun, Nov 15, 2015 at 03:24:19PM +0300, Andrey Chernov wro

Re: Need help fixing failing locale tests

On 15.11.2015 17:47, John Marino wrote: >>> Please provide an example of such a program (in ports). >> >> See gettext-0.19.6/gettext-tools/configure, part started with >> # Test for the usual locale name. >> I don't have time to dig more such code now, but I remember I saw more >> for sure. > If t

Re: Need help fixing failing locale tests

On 15.11.2015 16:54, John Marino wrote: > We are talking about people that install FreeBSD 11 as a release. If > it's an upgrade, it's documented in UPDATING (it will be) and anybody on > -CURRENT is taking responsibility for knowing what they are doing. *IF* > this is an obstacle, it's either tr

Re: Need help fixing failing locale tests

On 11/15/2015 2:10 PM, Andrey Chernov wrote: >> Well, there is "harm". The -1/-15 confusion happens a lot. > > It is user confusion and his responsibility. It not leads to wrong > program build f.e. Moreover, you can't protect users who set 8859-1 that > way, they do not convert to 8859-15 as you

Re: Need help fixing failing locale tests

On 11/15/2015 2:04 PM, Andrey Chernov wrote: > On 15.11.2015 16:00, Baptiste Daroussin wrote: >> On Sun, Nov 15, 2015 at 03:56:26PM +0300, Andrey Chernov wrote: >>> On 15.11.2015 15:46, Baptiste Daroussin wrote: On Sun, Nov 15, 2015 at 03:24:19PM +0300, Andrey Chernov wrote: > On 15.11.201

Re: Need help fixing failing locale tests

On 15.11.2015 16:14, John Marino wrote: >> It is user confusion and his responsibility. It not leads to wrong >> program build f.e. Moreover, you can't protect users who set 8859-1 that >> way, they do not convert to 8859-15 as you assume but start to complain >> everywhere that FreeBSD is not work

Re: Need help fixing failing locale tests

On 11/15/2015 2:36 PM, Andrey Chernov wrote: > On 15.11.2015 16:14, John Marino wrote: >>> It is user confusion and his responsibility. It not leads to wrong >>> program build f.e. Moreover, you can't protect users who set 8859-1 that >>> way, they do not convert to 8859-15 as you assume but start

Re: Need help fixing failing locale tests

> > There is soft-fail, configure just marks that locales are not supported > > and use "C". Sorry I don't remember port names where I saw it right now > > and don't have a time to search for them right now too. Soft-fails (like > > in tcl with nl_langinfo) are almost impossible to detect excepting

Re: Need help fixing failing locale tests

On 11/15/2015 1:56 PM, Andrey Chernov wrote: > On 15.11.2015 15:46, Baptiste Daroussin wrote: >> On Sun, Nov 15, 2015 at 03:24:19PM +0300, Andrey Chernov wrote: >>> On 15.11.2015 10:09, John Marino wrote: >>> ISO8859-1 locales are legacy even if obsoleted in modern world (I agree >>> with that). Lo

Re: Need help fixing failing locale tests

> Well, there is "harm". The -1/-15 confusion happens a lot. It is user confusion and his responsibility. It not leads to wrong program build f.e. Moreover, you can't protect users who set 8859-1 that way, they do not convert to 8859-15 as you assume but start to complain everywhere that FreeBSD

Re: Need help fixing failing locale tests

On 15.11.2015 16:00, Baptiste Daroussin wrote: > On Sun, Nov 15, 2015 at 03:56:26PM +0300, Andrey Chernov wrote: >> On 15.11.2015 15:46, Baptiste Daroussin wrote: >>> On Sun, Nov 15, 2015 at 03:24:19PM +0300, Andrey Chernov wrote: On 15.11.2015 10:09, John Marino wrote: ISO8859-1 locales

Re: Need help fixing failing locale tests

On Sun, Nov 15, 2015 at 03:56:26PM +0300, Andrey Chernov wrote: > On 15.11.2015 15:46, Baptiste Daroussin wrote: > > On Sun, Nov 15, 2015 at 03:24:19PM +0300, Andrey Chernov wrote: > >> On 15.11.2015 10:09, John Marino wrote: > >> ISO8859-1 locales are legacy even if obsoleted in modern world (I ag

Re: Need help fixing failing locale tests

On 15.11.2015 15:46, Baptiste Daroussin wrote: > On Sun, Nov 15, 2015 at 03:24:19PM +0300, Andrey Chernov wrote: >> On 15.11.2015 10:09, John Marino wrote: >> ISO8859-1 locales are legacy even if obsoleted in modern world (I agree >> with that). Lots of ports (even at configure stage!) have checks

Re: Need help fixing failing locale tests

> >> There's also a common > >> problem that users view -15 documents with -1 accidently. So there was > >> a conscience decision to have either ISO8859-1 or ISO8859-15 but not > >> both. For western Europe this means the ISO8859-1 versions were dropped. > > It is pure user problem choosing its

Re: Need help fixing failing locale tests

On Sun, Nov 15, 2015 at 03:24:19PM +0300, Andrey Chernov wrote: > On 15.11.2015 10:09, John Marino wrote: > > We (DragonFly) didn't just update locales. We took the opportunity to > > do spring cleaning. We didn't want to be as drastic as OpenBSD which > > removed all encodings except for C/POSIX

Re: Need help fixing failing locale tests

On 15.11.2015 15:24, Andrey Chernov wrote: > On 15.11.2015 10:09, John Marino wrote: >> We (DragonFly) didn't just update locales. We took the opportunity to >> do spring cleaning. We didn't want to be as drastic as OpenBSD which >> removed all encodings except for C/POSIX and UTF, but we did rem

Re: Need help fixing failing locale tests

On 15.11.2015 10:09, John Marino wrote: > We (DragonFly) didn't just update locales. We took the opportunity to > do spring cleaning. We didn't want to be as drastic as OpenBSD which > removed all encodings except for C/POSIX and UTF, but we did remove > several locales intentionally. > > In the

Re: Need help fixing failing locale tests

On 11/15/2015 12:23 PM, Craig Rodrigues wrote: > > > On Sat, Nov 14, 2015 at 11:47 PM, John Marino > wrote: > > > With 4.) they have been removed from FreeBSD when "Make upgrade" is run > after rebuilding. Does FreeBSD have a cleanup like that, and di

Re: Need help fixing failing locale tests

On 11/15/2015 8:24 AM, NGie Cooper wrote: >> On Nov 14, 2015, at 23:09, John Marino wrote: >> Bapt liked DF approach well enough that he adopted it. Even Edwin was >> first in desiring to clean up locales. The major update was a perfect time. >> >> Bottom line: >> The testsuite needs to be updat

Re: Need help fixing failing locale tests

On 11/15/2015 4:46 AM, NGie Cooper wrote: > >> On Nov 14, 2015, at 19:28, NGie Cooper wrote: > > … > >> Why were these locales removed? >> >> 58 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_COLLATE >> 59 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_CTYPE >> 60 OLD_FILES+=usr/share/locale

Re: Need help fixing failing locale tests

> On Nov 15, 2015, at 03:30, John Marino wrote: … > by they way, this was meant to be "removed from DragonFly". I don't > know if "make upgrade" is set right for FreeBSD. (it appears not) make upgrade doesn’t exist on FreeBSD: $ (cd /usr/src/svn/; make upgrade) make: don't know how to make

Re: Need help fixing failing locale tests

On Sat, Nov 14, 2015 at 11:47 PM, John Marino wrote: > > With 4.) they have been removed from FreeBSD when "Make upgrade" is run > after rebuilding. Does FreeBSD have a cleanup like that, and did you > run it? If not, then maybe that needs to be updated. > > I did not run "make upgrade". I did

Re: Need help fixing failing locale tests

> On Nov 14, 2015, at 23:09, John Marino wrote: > > On 11/15/2015 4:46 AM, NGie Cooper wrote: >> >>> On Nov 14, 2015, at 19:28, NGie Cooper wrote: >> >> … >> >>> Why were these locales removed? >>> >>> 58 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_COLLATE >>> 59 OLD_FILES+=usr/share/loc

Re: Need help fixing failing locale tests

> On Nov 14, 2015, at 19:46, NGie Cooper wrote: > > >> On Nov 14, 2015, at 19:28, NGie Cooper wrote: > > … > >> Why were these locales removed? >> >> 58 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_COLLATE >> 59 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_CTYPE >> 60 OLD_FILES+=usr/sha

Re: Need help fixing failing locale tests

> On Nov 14, 2015, at 19:28, NGie Cooper wrote: … > Why were these locales removed? > > 58 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_COLLATE > 59 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_CTYPE > 60 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_TIME > 61 OLD_DIRS+=usr/share/loca

Re: Need help fixing failing locale tests

> On Nov 14, 2015, at 19:18, Craig Rodrigues wrote: > > On Sat, Nov 14, 2015 at 7:05 PM, Craig Rodrigues > wrote: > >> Hi, >> >> After the recent locale commits, some of the tests are failing: >> >> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1675/testReport/ >> >> I can reproduce tw

Re: Need help fixing failing locale tests

On Sat, Nov 14, 2015 at 7:05 PM, Craig Rodrigues wrote: > Hi, > > After the recent locale commits, some of the tests are failing: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1675/testReport/ > > I can reproduce two failures quite easily by doing with a newly built > world: > > /bin/sh

Re: Need help fixing failing locale tests

> On Nov 14, 2015, at 19:05, Craig Rodrigues wrote: > > Hi, > > After the recent locale commits, some of the tests are failing: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1675/testReport/ > > I can reproduce two failures quite easily by doing with a newly built world: > > /bin/sh

Need help fixing failing locale tests

Hi, After the recent locale commits, some of the tests are failing: https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1675/testReport/ I can reproduce two failures quite easily by doing with a newly built world: /bin/sh /usr/tests/bin/sh/builtins/case7.0 /bin/sh /usr/tests/bin/sh/builtins/loca