Re: Minor bug in SCSI definition

2014-11-13 Thread Alexander Motin
On 13.11.2014 05:44, NGie Cooper wrote: > On Wed, Nov 12, 2014 at 7:30 PM, Rang, Anton wrote: >> Coverity found an issue in this area which I tracked down to the incorrect >> definition patched below. >> >> The SID_QUAL macro is (((inq_data)->device & 0xE0) >> 5) which extracts the >> peripheral

Re: Minor bug in SCSI definition

2014-11-12 Thread NGie Cooper
On Wed, Nov 12, 2014 at 7:30 PM, Rang, Anton wrote: > Coverity found an issue in this area which I tracked down to the incorrect > definition patched below. > > The SID_QUAL macro is (((inq_data)->device & 0xE0) >> 5) which extracts the > peripheral qualifier. > Per SCSI-2 (draft 10L) table 46,

Minor bug in SCSI definition

2014-11-12 Thread Rang, Anton
Coverity found an issue in this area which I tracked down to the incorrect definition patched below. The SID_QUAL macro is (((inq_data)->device & 0xE0) >> 5) which extracts the peripheral qualifier. Per SCSI-2 (draft 10L) table 46, the vendor-specific values are "1XXb". This probably affects al