Re: MD broken in current

2002-11-28 Thread Ian Dowse
In message <[EMAIL PROTECTED]>, Hiten Pandya writ es: >Is anyone planning to take this task, because, I think its important >that it is fixed. Or should it be put on the 5.0-todo list? If not, we >should put it in the BUGS section of mdconfig/ or the md(4) manual page. >IMO. I've tested the fix,

Re: MD broken in current

2002-11-28 Thread Hiten Pandya
On Wed, Nov 27, 2002 at 11:37:17AM +, Ian Dowse wrote the words in effect of: > In message <[EMAIL PROTECTED]>, Bruce Evans writes: > >On Wed, 27 Nov 2002, Ian Dowse wrote: > >> I think moving the line > >> > >>tsleep(sc, PRIBIO, "mdwait", 0); > >> > >> to just after the following `if' stat

Re: MD broken in current

2002-11-27 Thread Ian Dowse
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >On Wed, 27 Nov 2002, Ian Dowse wrote: >> I think moving the line >> >> tsleep(sc, PRIBIO, "mdwait", 0); >> >> to just after the following `if' statement may do the trick. If the > >Wouldn't Giant locking prevent races here? There is no lock

Re: MD broken in current

2002-11-27 Thread Bruce Evans
On Wed, 27 Nov 2002, Ian Dowse wrote: > In message <[EMAIL PROTECTED]>, Bruce Evans writes: > >Better fix mddestroy(). I don't know why it hangs ... I guess it is > >because it is called before initialization is completed in mdinit(), > >and there aren't enough state checks in mddestroy(). > > I

Re: MD broken in current

2002-11-27 Thread Ian Dowse
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >Better fix mddestroy(). I don't know why it hangs ... I guess it is >because it is called before initialization is completed in mdinit(), >and there aren't enough state checks in mddestroy(). I think moving the line tsleep(sc, PRIBIO,

Re: MD broken in current

2002-11-26 Thread Bruce Evans
On Tue, 26 Nov 2002, Hiten Pandya wrote: > There is also a problem, when the md(4) driver is passed a 0 byte file, > i.e. mdconfig -a -t -vnode -f /tmp/mdimage.zero. It simply hangs the > process in the `mddestroy' state, making it unkillable. > > David Wolfskill tested a patch, which I made. It

Re: MD broken in current

2002-11-26 Thread Hiten Pandya
On Tue, Nov 26, 2002 at 09:00:37PM +1100, Bruce Evans wrote the words in effect of: > On 26 Nov 2002, Vladimir B. Grebenschikov wrote: > > > # mdconfig -a -t vnode ./bootimg.bin > > mdconfig: ioctl(/dev/mdctl): Bad address > > This should be ... "-t vnode -f ./bootimg.bin". > > The bug is just

Re: MD broken in current

2002-11-26 Thread Bruce Evans
On 26 Nov 2002, Vladimir B. Grebenschikov wrote: > # mdconfig -a -t vnode ./bootimg.bin > mdconfig: ioctl(/dev/mdctl): Bad address This should be ... "-t vnode -f ./bootimg.bin". The bug is just low quality option parsing. ./bootimg.bin is garbage when it is not preceded by -f, and garbage ar

MD broken in current

2002-11-26 Thread Vladimir B.
Hi # mdconfig -a -t vnode ./bootimg.bin mdconfig: ioctl(/dev/mdctl): Bad address # truss mdconfig -a -t vnode ./bootimg.bin open("/dev/mdctl",0x2,00)= 3 (0x3) ioctl(3,MDIOCATTACH,0x8058c00) ERR#14 'Bad address' # ls -l /dev/mdctl crw---