Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-31 Thread John Baldwin
On 12/31/20 2:40 PM, Chuck Tuffli wrote: > On Wed, Dec 30, 2020 at 4:38 PM Neel Chauhan wrote: >> >> Hi Chuck, >> >> On 2020-12-30 10:04, Chuck Tuffli wrote: >>> What is the output from >>> # pciconf -rb pci0:0:14:0 0x40:0x48 >> >> The output is: >> >> 01 00 00 00 01 2e 68 02 00 > > Perfect. The

Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-31 Thread Chuck Tuffli
On Wed, Dec 30, 2020 at 4:38 PM Neel Chauhan wrote: > > Hi Chuck, > > On 2020-12-30 10:04, Chuck Tuffli wrote: > > What is the output from > > # pciconf -rb pci0:0:14:0 0x40:0x48 > > The output is: > > 01 00 00 00 01 2e 68 02 00 Perfect. The Linux driver says the 8086:9a0b device you have "... m

Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-30 Thread Neel Chauhan
On 2020-12-30 21:04, Neel Chauhan wrote: It is likely because VMD uses PCI domain above 0x1 but we aren't looking at this. The 0x1 is purely a Linux construct. It seems the PCI domains are virtual. Source: https://lists.x.org/archives/xorg-devel/2016-August/050590.html -Neel ___

Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-30 Thread Neel Chauhan
I think I found the issue: This PCIe controller is not detected: 1:e0:1d.0 PCI bridge [0604]: Intel Corporation Tiger Lake-LP PCI Express Root Port #9 [8086:a0b0] (rev 20) SI I believe the above PCIe controller is exposed by VMD (as it is on Linux), but FreeBSD vmd/vmd_bus is unable to a

Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-30 Thread Neel Chauhan
I have attached two files: * pcidump.txt: A dump of `pciconf -lv` * acpidump.txt: A dump of `acpidump` Hope this can help. -Neel On 2020-12-30 17:21, Neel Chauhan wrote: To extend, I am getting an issue with `pci_read_device()` where it returns a `vid` (PCI Vendor ID) of 0x. This ends

Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-30 Thread Neel Chauhan
To extend, I am getting an issue with `pci_read_device()` where it returns a `vid` (PCI Vendor ID) of 0x. This ends up returning "Cannot allocate dinfo!" from vmd. Log (via grep): https://imgur.com/a/tAmmY7i -Neel On 2020-12-30 16:38, Neel Chauhan wrote: Hi Chuck, On 2020-12-30 10:04, C

Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-30 Thread Neel Chauhan
Hi Chuck, On 2020-12-30 10:04, Chuck Tuffli wrote: What is the output from # pciconf -rb pci0:0:14:0 0x40:0x48 The output is: 01 00 00 00 01 2e 68 02 00 --chuck I was also able to stop kernel panics by adding: rman_fini(&sc->vmd_bus.rman); In the fail: statement in vmd_attach(). But I

Re: Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-30 Thread Chuck Tuffli
On Tue, Dec 29, 2020 at 6:30 PM Neel Chauhan wrote: > > Hi freebsd-hackers@, CC'd freebsd-current@, > > I hope you all had a wonderful holiday season. > > I recently got a HP Spectre x360 13t-aw200 which is an Intel > TigerLake-based laptop. It has the Intel "Evo" branding and an "Optane" > SSD wh

Intel TigerLake NVMe vmd: Adding Support & Debugging a Patch

2020-12-29 Thread Neel Chauhan
Hi freebsd-hackers@, CC'd freebsd-current@, I hope you all had a wonderful holiday season. I recently got a HP Spectre x360 13t-aw200 which is an Intel TigerLake-based laptop. It has the Intel "Evo" branding and an "Optane" SSD which I disabled (so I can get a "second" SSD). On the Spectre,