Re: Fall back to fast_float when C++ stdlib doesn't provide from_chars for floats

2024-08-08 Thread Dimitry Andric
On 8 Aug 2024, at 19:56, Daniel Tameling wrote: > > On Tue, Aug 06, 2024 at 11:26:26AM +0100, Nuno Teixeira wrote: >> >> As I don't have skills to understand why this fix works, I'd like to have >> some expert opinion on this fix since I don't know if this will be >> supported in the future. >

Re: Fall back to fast_float when C++ stdlib doesn't provide from_chars for floats

2024-08-08 Thread Daniel Tameling
On Tue, Aug 06, 2024 at 11:26:26AM +0100, Nuno Teixeira wrote: > > As I don't have skills to understand why this fix works, I'd like to have > some expert opinion on this fix since I don't know if this will be > supported in the future. Not an expert, but here is my opinion: the workaround uses t

Fall back to fast_float when C++ stdlib doesn't provide from_chars for floats

2024-08-06 Thread Nuno Teixeira
Hello all, On deskutils/treesheets port, upstream did some updated that broke build. After investigating it upstream says we are building with an outdated C++ standard lib. To fix it, I'm using a fall back to fast_float as we see in main PR: https://github.com/aardappel/treesheets/issues/686 As