Re: CFR: AES-GCM and OpenCrypto work review

2014-11-17 Thread John-Mark Gurney
Andrey V. Elsukov wrote this message on Mon, Nov 17, 2014 at 21:34 +0300: > On 16.11.2014 09:15, John-Mark Gurney wrote: > > Ok, I was able to reproduce the bug, and found that my optimization > > for single mbuf packets was broken... I've attached a new patch > > that has the fix... > > > > This

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-17 Thread Andrey V. Elsukov
On 16.11.2014 09:15, John-Mark Gurney wrote: > Ok, I was able to reproduce the bug, and found that my optimization > for single mbuf packets was broken... I've attached a new patch > that has the fix... > > This patch also has added a lock around the aesni fpu context setting > to deal w/ the iss

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-15 Thread John-Mark Gurney
Adrian Chadd wrote this message on Sat, Nov 15, 2014 at 22:18 -0800: > ... no attachment? Thanks, I put it on the website since I realized it was 155k and a bit large to attach... it's at: https://www.funkthat.com/~jmg/patches/aes.ipsec.6.patch > On 15 November 2014 22:15, John-Mark Gurney wrot

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-15 Thread Adrian Chadd
... no attachment? -adrian On 15 November 2014 22:15, John-Mark Gurney wrote: > Andrey V. Elsukov wrote this message on Sat, Nov 15, 2014 at 15:19 +0300: >> On 15.11.2014 05:42, John-Mark Gurney wrote: >> > I just verified that this happens on a clean HEAD @ r274534: >> > FreeBSD 11.0-CURRENT

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-15 Thread John-Mark Gurney
Andrey V. Elsukov wrote this message on Sat, Nov 15, 2014 at 15:19 +0300: > On 15.11.2014 05:42, John-Mark Gurney wrote: > > I just verified that this happens on a clean HEAD @ r274534: > > FreeBSD 11.0-CURRENT #0 r274534: Fri Nov 14 17:17:10 PST 2014 > > j...@carbon.funkthat.com:/scratch/jmg/c

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-15 Thread Andrey V. Elsukov
On 15.11.2014 05:42, John-Mark Gurney wrote: > I just verified that this happens on a clean HEAD @ r274534: > FreeBSD 11.0-CURRENT #0 r274534: Fri Nov 14 17:17:10 PST 2014 > j...@carbon.funkthat.com:/scratch/jmg/clean/sys/amd64/compile/IPSEC amd64 > > No modifications, nothing, and I got the s

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-15 Thread Andrey V. Elsukov
On 15.11.2014 05:42, John-Mark Gurney wrote: > John-Mark Gurney wrote this message on Fri, Nov 14, 2014 at 11:39 > -0800: >> Well.. It looks like IPSEC is still broken in head... I can get >> pings to pass, but now on IPv4 transport mode, I can't get syn's >> to be sent out... I see the output p

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-14 Thread John-Mark Gurney
John-Mark Gurney wrote this message on Fri, Nov 14, 2014 at 11:39 -0800: > Well.. It looks like IPSEC is still broken in head... I can get > pings to pass, but now on IPv4 transport mode, I can't get syn's to > be sent out... I see the output packet in the protocol stats, but > no packets go out

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-14 Thread Andrey V. Elsukov
On 14.11.2014 03:52, Andrey V. Elsukov wrote: > I tried your patch with my IPv4 forwarding test. When aesni module is > loaded and aes-cbc is used I see growing of `invalid outbound packets` > counter in `netstat -sp ipsec` output. And no packets are forwarded. > Also while testing I got a panic in

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-14 Thread Konstantin Belousov
On Fri, Nov 14, 2014 at 03:52:39AM +0300, Andrey V. Elsukov wrote: > On 08.11.2014 07:23, John-Mark Gurney wrote: > > Hello, > > > > Over the last few months, I've been working on a project to add support > > for AES-GCM and AES-CTR modes to our OpenCrypto framework. The work is > > sponsored by

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-13 Thread Andrey V. Elsukov
On 08.11.2014 07:23, John-Mark Gurney wrote: > Hello, > > Over the last few months, I've been working on a project to add support > for AES-GCM and AES-CTR modes to our OpenCrypto framework. The work is > sponsored by The FreeBSD Foundation and Netgate. > > I plan on committing these patches ear

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-12 Thread John-Mark Gurney
Vsevolod Stakhov wrote this message on Sat, Nov 08, 2014 at 21:20 +: > On 08/11/14 20:45, John-Mark Gurney wrote: > >Vsevolod Stakhov wrote this message on Sat, Nov 08, 2014 at 18:55 +: > >>On 08/11/14 04:23, John-Mark Gurney wrote: > >>>Hello, > >>> > >>>Over the last few months, I've been

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-08 Thread Vsevolod Stakhov
On 08/11/14 20:45, John-Mark Gurney wrote: Vsevolod Stakhov wrote this message on Sat, Nov 08, 2014 at 18:55 +: On 08/11/14 04:23, John-Mark Gurney wrote: Hello, Over the last few months, I've been working on a project to add support for AES-GCM and AES-CTR modes to our OpenCrypto framewor

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-08 Thread John-Mark Gurney
Vsevolod Stakhov wrote this message on Sat, Nov 08, 2014 at 18:55 +: > On 08/11/14 04:23, John-Mark Gurney wrote: > > Hello, > > > > Over the last few months, I've been working on a project to add support > > for AES-GCM and AES-CTR modes to our OpenCrypto framework. The work is > > sponsored

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-08 Thread Vsevolod Stakhov
On 08/11/14 04:23, John-Mark Gurney wrote: > Hello, > > Over the last few months, I've been working on a project to add support > for AES-GCM and AES-CTR modes to our OpenCrypto framework. The work is > sponsored by The FreeBSD Foundation and Netgate. > > I plan on committing these patches early

Re: CFR: AES-GCM and OpenCrypto work review

2014-11-08 Thread Dag-Erling Smørgrav
John-Mark Gurney writes: > Over the last few months, I've been working on a project to add support > for AES-GCM and AES-CTR modes to our OpenCrypto framework. The work is > sponsored by The FreeBSD Foundation and Netgate. > > I plan on committing these patches early next week. If you need more

CFR: AES-GCM and OpenCrypto work review

2014-11-07 Thread John-Mark Gurney
Hello, Over the last few months, I've been working on a project to add support for AES-GCM and AES-CTR modes to our OpenCrypto framework. The work is sponsored by The FreeBSD Foundation and Netgate. I plan on committing these patches early next week. If you need more time for review, please ema