Re: EPSV patch for review (was Re: Broken FTP)

2000-02-20 Thread Yoshinobu Inoue
> Please review this patch. It fix all problems I mention. Thanks, as far as I reviewed and actually confirmed, your patches solved every problem. :-) Yoshinobu Inoue To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message

EPSV patch for review (was Re: Broken FTP)

2000-02-20 Thread Andrey A. Chernov
Please review this patch. It fix all problems I mention. --- ftp.c.old Sun Feb 20 23:30:29 2000 +++ ftp.c Mon Feb 21 02:21:01 2000 @@ -1173,8 +1173,6 @@ #endif if (passivemode) { - static int try_epsv = 1; - data_addr = myctladdr; d

Re: Broken FTP

2000-02-20 Thread Andrey A. Chernov
On Sun, Feb 20, 2000 at 01:56:06PM -0800, Andrey A. Chernov wrote: > Sorry, this place (EPSV == PASV) is right excepting proxy mode is not covered by > EPSV (see PASV usage for proxy). Another error is that static int try_epsv = 1; is set globally for all connections made by ftp instead

Re: Broken FTP

2000-02-20 Thread Andrey A. Chernov
On Sun, Feb 20, 2000 at 01:37:01PM -0800, Andrey A. Chernov wrote: > I don't look at the code deeply yet, but it looks from > your words that EPSV command must be issued _only_ if ftp called > as pftp or 'passive' command given or FTP_PASIVE_MODE > env. variable is set and must be not issued in no

Re: Broken FTP

2000-02-20 Thread Andrey A. Chernov
On Sat, Feb 19, 2000 at 06:19:17PM +0900, Yoshinobu Inoue wrote: > EPSV is just enhanced version of PASV, and I think it needs to > check same kind of errors. Maybe same check as getreply() in > ftp/ftp.c will be necessary. About the spec, please check RFC2428. > > But the problem is that the err

Re: Broken FTP

2000-02-19 Thread Yoshinobu Inoue
> > Could you please create the patch which seems to be safely > > committed? That will be very much help. > > Well, I can try but I need to know most shortest and most trivial EPSV > check sequence from you since can't check it locally and don't know about EPSV. EPSV is just enhanced version o

Re: Broken FTP

2000-02-18 Thread Andrey A. Chernov
On Sat, Feb 19, 2000 at 04:47:34AM +0900, Yoshinobu Inoue wrote: > But the change to do it seems to be not so simple as can be > done in this code freeze phase. (At least with my level of > understanding of ftp code.) > Somewhat no printing version of getreply() seems to be > necessary. > > Coul

Re: Broken FTP

2000-02-18 Thread Yoshinobu Inoue
> > OK I'll change not to try it once it fails. > > It seems your last patch _not_ fix the problem. Now I got: > > ftp> dir > 500 'EPSV': command not understood. > > on first 'dir' command issued. This is with wu-ftpd. Remember that different > ftpd's could have slightly different format for r

Re: Broken FTP

2000-02-18 Thread Andrey A. Chernov
On Thu, Feb 17, 2000 at 06:06:22PM +0900, Yoshinobu Inoue wrote: > > > But maybe it is better to print out the first error, as the fact? > > > > I have nothing against EPSV itself, I am against additional verbosity and > > performance degradation since it is tried before _each_ command. > > OK I

Re: Broken FTP

2000-02-17 Thread Yoshinobu Inoue
> > But maybe it is better to print out the first error, as the fact? > > I have nothing against EPSV itself, I am against additional verbosity and > performance degradation since it is tried before _each_ command. OK I'll change not to try it once it fails. But trying to do that I noticed that

Re: Broken FTP

2000-02-15 Thread Andrey A. Chernov
On Wed, Feb 16, 2000 at 03:51:24PM +0900, Yoshinobu Inoue wrote: > (2)EPSV is always tried first, and if server doesn't support it, > then try PASV. > > Remembering the status might be reasonable. I'll try the fix. > > But maybe it is better to print out the first error, as the fact? I hav

Re: Broken FTP

2000-02-15 Thread Yoshinobu Inoue
Hello, EPSV and EPRT is new ftp command defind in RFC2428 and it is used for IPv6 and NAT/firewall friendly IPv4 connection. Current implementation is, (1)EPRT is only used if destination is IPv6 host. (2)EPSV is always tried first, and if server doesn't support it, then try PASV. EPRT do

Re: Broken FTP

2000-02-15 Thread Will Saxon
I was experiencing the same thing with EPRT commands... I cvsupped, remade/installed ftp, and haven't seen that behavior since. Someone mentioned it was IPv6 related but I have no idea if that is the case. -Will On Wed, 16 Feb 2000, Andrey A. Chernov wrote: > Current ftp client tries to put thi

Re: Broken FTP

2000-02-15 Thread Andrey A. Chernov
On Tue, Feb 15, 2000 at 09:37:34PM -0500, Will Saxon wrote: > I was experiencing the same thing with EPRT commands... I cvsupped, > remade/installed ftp, and haven't seen that behavior since. Someone > mentioned it was IPv6 related but I have no idea if that is the case. Just rebuild 'ftp' from s

Broken FTP

2000-02-15 Thread Andrey A. Chernov
Current ftp client tries to put this unknown command on each remote request: 500 'EPSV': command not understood. It is just too bothering. Could it silently try once at the beginning and remember status during the session? -- Andrey A. Chernov <[EMAIL PROTECTED]> http://nagual.pp.ru/~ache/ To