Re: [dtrace] syscall provider naming convention.

2010-12-24 Thread Artem Belevich
>>> I have one comment though.  I am not sure about renaming syscall.ko to >>> syscall_freebsd.ko. >> I've renamed it for consistency with other systrace provider variants. >> I can change it back. > > I think that I would prefer this. > If only for POLA reasons. Done. New patch is here: https://s

Re: [dtrace] syscall provider naming convention.

2010-12-24 Thread Andriy Gapon
on 24/12/2010 04:02 Artem Belevich said the following: >> I have one comment though. I am not sure about renaming syscall.ko to >> syscall_freebsd.ko. > > You mean systrace_freebsd.ko. Yes, thanks. > I've renamed it for consistency with other systrace provider variants. > I can change it back.

Re: [dtrace] syscall provider naming convention.

2010-12-23 Thread Artem Belevich
> I have one comment though.  I am not sure about renaming syscall.ko to > syscall_freebsd.ko. You mean systrace_freebsd.ko. I've renamed it for consistency with other systrace provider variants. I can change it back. > Perhaps we could keep the old name?  Or add a new module > under that name t

Re: [dtrace] syscall provider naming convention.

2010-12-21 Thread Artem Belevich
On Mon, Dec 20, 2010 at 3:15 AM, Andriy Gapon wrote: > It would be nice to get the i386 counterpart too when this goes into the tree. Here's updated version that has syscall:linux32 working on i386, too. https://sites.google.com/site/abc678site/files/dt-systrace-20101221.patch.gz --Artem __

Re: [dtrace] syscall provider naming convention.

2010-12-21 Thread Artem Belevich
On Tue, Dec 21, 2010 at 1:26 AM, Artem Belevich wrote: > On Mon, Dec 20, 2010 at 3:15 AM, Andriy Gapon wrote: >> It would be nice to get the i386 counterpart too when this goes into the >> tree. > > Here's updated version that has syscall:linux32 working on i386, too. > > https://sites.google.co

Re: [dtrace] syscall provider naming convention.

2010-12-21 Thread Andriy Gapon
on 21/12/2010 11:27 Artem Belevich said the following: > On Tue, Dec 21, 2010 at 1:26 AM, Artem Belevich wrote: >> On Mon, Dec 20, 2010 at 3:15 AM, Andriy Gapon wrote: >>> It would be nice to get the i386 counterpart too when this goes into the >>> tree. >> >> Here's updated version that has sys

[dtrace] syscall provider naming convention.

2010-12-20 Thread Andriy Gapon
on 14/12/2010 05:10 Artem Belevich said the following: > I've posted updated version of the patch here: > https://sites.google.com/site/abc678site/files/dt-systrace.patch.gz > > This patch uses DTrace module field to specify syscall's compat > variant in the syscall probe name. If there are no ob