Re: [bmake] bmake sigint handling causing tty corruption

2017-08-09 Thread Bryan Drewery
On 7/20/2017 10:33 AM, Simon J. Gerraty wrote: > Konstantin Belousov wrote: >> I just find is somewhat strange that make initiates a new session. > > In jobs mode it does - to ensure the child and all progeny can be killed > in one fell swoop. > In compat mode it does not, but that does not mean

Re: [bmake] bmake sigint handling causing tty corruption

2017-07-25 Thread Ilya A . Arkhipov
19.07.2017, 16:00, "Dmitry Marakasov" : > Hi! > > Me and Ilya Arkhipov were investigating the cause of this bug: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215572 > > In short, when FreeBSD ports options dialog is interrupted by Ctrl+C, > there's chance of sporadic terminal corruption. T

Re: [bmake] bmake sigint handling causing tty corruption

2017-07-20 Thread Simon J. Gerraty
Konstantin Belousov wrote: > I just find is somewhat strange that make initiates a new session. In jobs mode it does - to ensure the child and all progeny can be killed in one fell swoop. In compat mode it does not, but that does not mean the child cannot do so. > Did you verified that enabling

Re: [bmake] bmake sigint handling causing tty corruption

2017-07-20 Thread Konstantin Belousov
On Tue, Jul 18, 2017 at 11:57:00PM +0300, Dmitry Marakasov wrote: > Hi! > > Me and Ilya Arkhipov were investigating the cause of this bug: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215572 > > In short, when FreeBSD ports options dialog is interrupted by Ctrl+C, > there's chance of sp

Re: [bmake] bmake sigint handling causing tty corruption

2017-07-19 Thread Simon J. Gerraty
Hi Dmitry Thanks for the detailed report. Will take a look > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215572 > Now to fix this, I suggest that instead of killing itself, make should > signal all its childs carefully and wait() on them, only then die > itself. > > Now after a quick

Re: [bmake] bmake sigint handling causing tty corruption

2017-07-19 Thread Poul-Henning Kamp
In message <20170718205700.GA2131@hades.panopticon>, Dmitry Marakasov writes: >In short, when FreeBSD ports options dialog is interrupted by Ctrl+C, >there's chance of sporadic terminal corruption. They are not always >reproducible and seem to be dependent on a machine, shell, terminal,

[bmake] bmake sigint handling causing tty corruption

2017-07-19 Thread Dmitry Marakasov
Hi! Me and Ilya Arkhipov were investigating the cause of this bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215572 In short, when FreeBSD ports options dialog is interrupted by Ctrl+C, there's chance of sporadic terminal corruption. They are not always reproducible and seem to be depend