Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-13 Thread Mike Tancsa
On 8/3/2012 5:18 PM, John Baldwin wrote: >> >> Seems to apply to RELENG_9 just fine. Are there any stress tests you >> suggest I run that might expose some bugs ? The machine is not >> production yet, so its ok to crash it. > > Probably pho's stress2 stuff. Thinks like dbench might be a good sta

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-10 Thread Mike Tancsa
On 8/10/2012 10:05 AM, John Baldwin wrote: > > 5972 tw_cli CALL > __sysctl(0x7fffd798,0x2,0x7fffd7a0,0x7fffd790,0x7fffd960,0x16) > 5972 tw_cli SCTL "sysctl.name2oid" > 5972 tw_cli RET __sysctl -1 errno 2 No such file or directory > 5972 tw_cli CALL unlink(0x7fff

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-10 Thread John Baldwin
On 8/10/12 9:52 AM, Mike Tancsa wrote: > On 8/10/2012 9:31 AM, John Baldwin wrote: >> On 8/9/12 5:04 PM, Mike Tancsa wrote: >>> Start up the tw_cli client >>> >>> 0{offsite2}# tw_cli >>> //offsite2> show >>> >>> Ctl Model(V)Ports Drives Units NotOpt RRate VRate BBU >>> --

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-10 Thread Mike Tancsa
On 8/10/2012 9:31 AM, John Baldwin wrote: > On 8/9/12 5:04 PM, Mike Tancsa wrote: >> Start up the tw_cli client >> >> 0{offsite2}# tw_cli >> //offsite2> show >> >> Ctl Model(V)Ports Drives Units NotOpt RRate VRate BBU >> ---

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-10 Thread John Baldwin
On 8/9/12 5:04 PM, Mike Tancsa wrote: > Start up the tw_cli client > > 0{offsite2}# tw_cli > //offsite2> show > > Ctl Model(V)Ports Drives Units NotOpt RRate VRate BBU > > c09650SE-2LP 2 2

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-09 Thread Mike Tancsa
On 8/9/2012 3:28 PM, Mike Tancsa wrote: > On 8/9/2012 1:21 PM, John Baldwin wrote: >> >> Humm, I wonder if this module has a mix of old and new .o files somehow? >> Perhaps try rebuilding twe.ko from scratch after doing a 'make clean'? > > I think you are right. I nuked all the kernel files and re

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-09 Thread Mike Tancsa
On 8/9/2012 1:21 PM, John Baldwin wrote: > > Humm, I wonder if this module has a mix of old and new .o files somehow? > Perhaps try rebuilding twe.ko from scratch after doing a 'make clean'? I think you are right. I nuked all the kernel files and recompiled again, and it no longer panics and I se

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-09 Thread John Baldwin
On 8/9/12 10:31 AM, Mike Tancsa wrote: > On 8/9/2012 9:16 AM, John Baldwin wrote: >>> One more data point, /dev/twe0 does not exist with the patch and I think >>> thats why the utils fail outright. >> >> Oh, hmm. That's odd. Do you get any error messages on the console >> when twe0 attaches? Als

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-09 Thread Mike Tancsa
On 8/9/2012 9:16 AM, John Baldwin wrote: >> One more data point, /dev/twe0 does not exist with the patch and I think >> thats why the utils fail outright. > > Oh, hmm. That's odd. Do you get any error messages on the console > when twe0 attaches? Also, you have INVARIANTS enabled, yes? > (make_

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-09 Thread John Baldwin
On 8/9/12 8:22 AM, Mike Tancsa wrote: > On 8/8/2012 2:39 PM, Mike Tancsa wrote: >> On 8/8/2012 7:27 AM, John Baldwin wrote: Looks like it breaks 3dm2 and the tw_cli. With the patch, I am not able to see the 8006 controller I added. >>> >>> Ugh, ok. A few questions: >>> >>> 1) Does the d

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-09 Thread Mike Tancsa
On 8/8/2012 2:39 PM, Mike Tancsa wrote: > On 8/8/2012 7:27 AM, John Baldwin wrote: >>> Looks like it breaks 3dm2 and the tw_cli. With the patch, I am not able >>> to see the 8006 controller I added. >> >> Ugh, ok. A few questions: >> >> 1) Does the driver see any attached drives/volumes? > > Yes

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-08 Thread Mike Tancsa
On 8/8/2012 7:27 AM, John Baldwin wrote: >> Looks like it breaks 3dm2 and the tw_cli. With the patch, I am not able >> to see the 8006 controller I added. > > Ugh, ok. A few questions: > > 1) Does the driver see any attached drives/volumes? Yes > > 2) If it does, does basic I/O to the drives

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-08 Thread John Baldwin
On Tuesday, August 07, 2012 10:11:01 AM Mike Tancsa wrote: > On 8/3/2012 5:26 PM, John Baldwin wrote: > >>If there's a tool for poking at the drives/controller, I would use > >>that, plus camcontrol. Of course you want a data intensive workload > > > > (iometer/iozone/xdd with async and sy

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-07 Thread Mike Tancsa
On 8/3/2012 5:26 PM, John Baldwin wrote: >> If there's a tool for poking at the drives/controller, I would use >> that, plus camcontrol. Of course you want a data intensive workload > (iometer/iozone/xdd with async and sync mode, random reads and sequential > reads, etc), and maybe resort t

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-03 Thread John Baldwin
On Friday, August 03, 2012 5:17:09 pm Garrett Cooper wrote: > On Aug 3, 2012, at 1:42 PM, Mike Tancsa wrote: > > > On 8/3/2012 3:39 PM, John Baldwin wrote: > >> On Friday, August 03, 2012 2:56:00 pm Kevin Oberman wrote: > >>> I'll try to find time to try it later today, but I'm in the middle of >

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-03 Thread John Baldwin
On Friday, August 03, 2012 4:42:59 pm Mike Tancsa wrote: > On 8/3/2012 3:39 PM, John Baldwin wrote: > > On Friday, August 03, 2012 2:56:00 pm Kevin Oberman wrote: > >> I'll try to find time to try it later today, but I'm in the middle of > >> budget wrangling and I can't make any promises. > >> > >

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-03 Thread Garrett Cooper
On Aug 3, 2012, at 1:42 PM, Mike Tancsa wrote: > On 8/3/2012 3:39 PM, John Baldwin wrote: >> On Friday, August 03, 2012 2:56:00 pm Kevin Oberman wrote: >>> I'll try to find time to try it later today, but I'm in the middle of >>> budget wrangling and I can't make any promises. >>> >>> Before I tr

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-03 Thread Mike Tancsa
On 8/3/2012 3:39 PM, John Baldwin wrote: > On Friday, August 03, 2012 2:56:00 pm Kevin Oberman wrote: >> I'll try to find time to try it later today, but I'm in the middle of >> budget wrangling and I can't make any promises. >> >> Before I try, will these patches apply to the twe driver in >> 9.1-

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-03 Thread John Baldwin
On Friday, August 03, 2012 2:56:00 pm Kevin Oberman wrote: > I'll try to find time to try it later today, but I'm in the middle of > budget wrangling and I can't make any promises. > > Before I try, will these patches apply to the twe driver in > 9.1-PRERELEASE? My system with twe was updated to R

Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-03 Thread Kevin Oberman
I'll try to find time to try it later today, but I'm in the middle of budget wrangling and I can't make any promises. Before I try, will these patches apply to the twe driver in 9.1-PRERELEASE? My system with twe was updated to RELENG_9 on July 18. I really don't have time to install current right

[PATCH] Add locking to twe(4) so it no longer uses Giant

2012-08-03 Thread John Baldwin
We only have a few storage drivers left that use Giant and twe(4) is one of them. I don't have any hardware to test with, however. I have verified the patch compiles, but I'd appreciate it if some folks with twe(4) hardware could test it. The patch is at http://www.FreeBSD.org/~jhb/patches/tw