Re: 12.0-BETA1 vnet with pf firewall

2018-10-30 Thread Rodney W. Grimes
> On 30 Oct 2018, at 14:14, Rodney W. Grimes wrote: > > >> On 30 Oct 2018, at 14:29, Bjoern A. Zeeb wrote: > >>> On 30 Oct 2018, at 12:23, Kristof Provost wrote: > I?m not too familiar with this part of the vnet code, but it looks > to me like we?ve got more per-vnet variables that was o

Re: 12.0-BETA1 vnet with pf firewall

2018-10-30 Thread Bjoern A. Zeeb
On 30 Oct 2018, at 14:14, Rodney W. Grimes wrote: On 30 Oct 2018, at 14:29, Bjoern A. Zeeb wrote: On 30 Oct 2018, at 12:23, Kristof Provost wrote: I?m not too familiar with this part of the vnet code, but it looks to me like we?ve got more per-vnet variables that was originally anticipated, so

Re: 12.0-BETA1 vnet with pf firewall

2018-10-30 Thread Rodney W. Grimes
> On 30 Oct 2018, at 14:29, Bjoern A. Zeeb wrote: > > On 30 Oct 2018, at 12:23, Kristof Provost wrote: > >> I?m not too familiar with this part of the vnet code, but it looks > >> to me like we?ve got more per-vnet variables that was originally > >> anticipated, so we may need to just increase th

Re: 12.0-BETA1 vnet with pf firewall

2018-10-30 Thread Kristof Provost
On 30 Oct 2018, at 14:29, Bjoern A. Zeeb wrote: On 30 Oct 2018, at 12:23, Kristof Provost wrote: I’m not too familiar with this part of the vnet code, but it looks to me like we’ve got more per-vnet variables that was originally anticipated, so we may need to just increase the allocated space.

Re: 12.0-BETA1 vnet with pf firewall

2018-10-30 Thread Bjoern A. Zeeb
On 30 Oct 2018, at 12:23, Kristof Provost wrote: On 29 Oct 2018, at 4:41, Kristof Provost wrote: So we panic because we dereference a NULL pointer in strncmp(), which happens because nprogtab = 13 but ef->progtab[12] has NULL pointers. I cannot reproduce your panic trying to load both pf, and

Re: 12.0-BETA1 vnet with pf firewall

2018-10-30 Thread Kristof Provost
On 29 Oct 2018, at 4:41, Kristof Provost wrote: So we panic because we dereference a NULL pointer in strncmp(), which happens because nprogtab = 13 but ef->progtab[12] has NULL pointers. It’s not clear to me why that happens, but it’s something to go on. I do wonder if this isn’t a bit of a re

Re: Has anything changed from 11.2 to 12.0 in PCI MSI/MSIX path?

2018-10-30 Thread Rajesh Kumar
Hi John, Thanks for your updates. I assume you are talking about having a unified intr_machdep.h compared to having seperate amd64 and i386 versions. Can you please update this thread once all changes are MFC complete or tag me in necessary place? So that I can give a try in my board once it's r