FreeBSD's rand() implementation has been broken for the past 23
months, since the following commit:
Revision 1.3 / (download) - annotate - [select for diffs], Tue Feb 27 14:42:19 2001
UTC (23 months ago) by ache
Branch: MAIN
Changes since 1.2: +26 -0 lines
Diff to previous 1.2 (colored)
Use
On Sat 01 Feb, Matthew Dillon wrote:
> Well, there is something to be said for trying to avoid userland
> namespace pollution, but it is still somewhat of a stretch since most
> userland programs #include standard and system headers before
> they #include their own, and the includes
Well, there is something to be said for trying to avoid userland
namespace pollution, but it is still somewhat of a stretch since most
userland programs #include standard and system headers before
they #include their own, and the includes are typically done before
any code.
On Sat 01 Feb, Steve Kargl wrote:
> From: Steve Kargl <[EMAIL PROTECTED]>
> To: Julian Elischer <[EMAIL PROTECTED]>
> Cc: Mark Murray <[EMAIL PROTECTED]>, [EMAIL PROTECTED], [EMAIL PROTECTED]
> Subject: Re: Style fixups for proc.h
>
> On Sat, Feb 01, 2003 at 03:04:32PM -0800, Julian Elischer wrote
On Sat, 1 Feb 2003, Mike Barcroft wrote:
> Brad Knowles <[EMAIL PROTECTED]> writes:
> > At 6:27 PM -0800 2003/02/01, Matthew Dillon wrote:
> >
> > > Well, it is an active conversation/thread. Either people care enough
> > > to stay involved or they don't.
> >
> > But don't people
On Sat, 1 Feb 2003, Matthew Dillon wrote:
> sys/acl.h -- looks like the authors tried to use the underscore technique
> but forgot a couple.
Actually, the pattern is that the function prototypes exposed to userspace
are prefixed with '_' to prevent interfering with the appli
> Technically, the compiler doesn't need prototypes at all; they
> are merely a band-aid for the compiler vendors, who did not want
> to have to deal with changing object file format.
IMHO the value of prototypes is in documenting a function
interface rather than for the vendors. Compilers of
lan
Simon,
This is a known issue. Have a look at
http://www.freebsd.org/releases/5.0R/errata.html
under section 3 (Late-Breaking News).
Regards,
> Andre Guibert de Bruet | Enterprise Software Consultant >
> Silicon Landmark, LLC. | http://siliconlandmark.com/>
On Fri, 31 Jan 2003, Simon wrote:
Brad Knowles <[EMAIL PROTECTED]> writes:
> At 6:27 PM -0800 2003/02/01, Matthew Dillon wrote:
>
> > Well, it is an active conversation/thread. Either people care enough
> > to stay involved or they don't.
>
> But don't people have to sleep sometime? Shouldn't we allow for that?
Matthew Dillon wrote:
> Mark Murray wrote:
> :Then can we just get the proc.h prototypes into a (any) consistent
> :style?
Yes; no brainer, except where Garrett has indicated (e.g. a
function that takes a "fromvp" and "tovp", or other similar arguments).
> Lets ask ourselves what the goal of
In an attempt to understand where and how the last KSE patch may have
been broken, I'd like to know if there is anyone who had
a system "magically cured" by the backout. (Assuming you had
the 'ticks' patch beforehand).
If so, can you tell me what your system was doing wrong beforehand,
and wha
On 2003-02-01 19:31, Garrett Wollman <[EMAIL PROTECTED]> wrote:
> < said:
> > I can't see what actual error is avoided by this warning.
>
> My personal opinion, which is different from what style(9) recommends,
> is that parameter names should be omitted for all functions, EXCEPT
> those with ambig
On Sat, 1 Feb 2003, Julian Elischer wrote:
>
>
> On Sun, 2 Feb 2003, Brad Knowles wrote:
>
> > At 10:47 AM -0800 2003/02/01, Julian Elischer wrote:
> >
> > > still no comments?
> > >
> > > this patch seems to be working, but a review from another developer
> > > would be good.. particular
At 6:27 PM -0800 2003/02/01, Matthew Dillon wrote:
Well, it is an active conversation/thread. Either people care enough
to stay involved or they don't.
But don't people have to sleep sometime? Shouldn't we allow for that?
I mean, I can understand impatience, too. I get impatient
On Sun, 2 Feb 2003, Brad Knowles wrote:
> At 10:47 AM -0800 2003/02/01, Julian Elischer wrote:
>
> > still no comments?
> >
> > this patch seems to be working, but a review from another developer
> > would be good.. particularly re: the point mentionned..
>
[...]
>
> If I am wrong an
At 1:01 PM +0100 2003/01/26, [EMAIL PROTECTED] wrote:
In message <[EMAIL PROTECTED]>, Ruslan Ermilov writes:
Welcome to the club if people who was bitten by the poor design
choices in the BSD disklabel.
>Now the
question. Where is the code in the kernel that prevents swapping
and/or writing
Matthew Dillon wrote:
> The HLT/clock interrupt issue is precisely what I describe in the
> idle_hlt comments in i386/i386/machdep.c (last July). I wish we had a
> better mechanism then the stupid IPI stuff, like a simple per-cpu
> latch/acknowledge level interrupt (softint), but w
On Sun, 2 Feb 2003, Mark Murray wrote:
> > Why not fix the compiler & lint instead of cluttering up
> > declarations?
>
> Can we at least get proc.h to have a consistent style of
> function parameter usage?
Sure. let's be consistent with all the other .h files in the kernel.
what does a quick
:02:59:24 -0800 (PST). The date/time stamp on the message that I am
:replying to is Sat, 1 Feb 2003 10:47:44 -0800 (PST). That's
:something around seven hours and forty-five minutes, unless I have
:miscalculated.
:
: Is it really normal to expect replies within that kind of a time
:fra
At 10:47 AM -0800 2003/02/01, Julian Elischer wrote:
still no comments?
this patch seems to be working, but a review from another developer
would be good.. particularly re: the point mentionned..
You first announced the split-out patch at Sat, 1 Feb 2003
02:59:24 -0800 (PST). The date/ti
On Saturday 01 February 2003 05:43 pm, Scott Long wrote:
> Have you made
> sure that the DVD drive is using DMA? 'sysctl hw.ata.atapi_dma' will
> tell you, and can be set at boot from /boot/loader.conf.
This was the main problem. Turning on DMA makes everything run smoothly and
drops the load av
> > I can't see what actual error is avoided by this warning.
s/actual/potential/
>
> If a named prototype clashes with something in global scope,
> isn't it still a shadowing issue? They should probably never
> be *in* scope.
Nothing is being shadowed. Paramater names in a function
prototype
:>I really dislike screwing around with source code to work around
:>bugs in the the compiler, or lint. Given the choice of underlines
:>or leaving the arguments unnamed, I would leave them unnamed. Or I
:>would figure out and remove whatever broken compiler option is generating
:
Matthew Dillon writes:
>
> :WARNS=5.
>
> This isn't helpful. I tried adding every -W switch in bsd.sys.mk
> and couldn't reproduce the problem. What compiler option is causing
> the problem?
I don't know which specific one.
>Ok, now I'm really confused. How can it not always
< union baz {
> int foo;
> struct frotz *gorp;
> } foobaz;
> #define foo foobaz.foo
Oops... What I meant to say:
union baz {
int bazu_foo;
struct frotz *bazu_gorp;
} foobaz;
#define foo foobaz.ba
< said:
> I can't see what actual error is avoided by this warning.
It's a potential error -- if there were an actual error, it would be
an error and not a warning.
The issue is simple:
Say you have an object and a function declared in global scope:
int foo;
/* many lines of de
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
--
>>> Rebuilding the temporary build tree
--
>>> stage 1: bootstrap tools
--
>>> stage 2: cleaning up the object tree
:If a named prototype clashes with something in global scope,
:isn't it still a shadowing issue? They should probably never
:be *in* scope.
:--
:Juli Mallett <[EMAIL PROTECTED]>
:AIM: BSDFlata -- IRC: juli on EFnet
I finally was able to reproduce the bug. But it's an obvious bug in the
> Why not fix the compiler & lint instead of cluttering up
> declarations?
Can we at least get proc.h to have a consistent style of
function parameter usage?
M
--
Mark Murray
iumop ap!sdn w,I idlaH
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of t
:WARNS=5.
This isn't helpful. I tried adding every -W switch in bsd.sys.mk
and couldn't reproduce the problem. What compiler option is causing
the problem?
:> :2 ways to fix this are to "protect" the prototype argument names with the
:> :"_", or to remove the argument name altogeth
* De: Bakul Shah <[EMAIL PROTECTED]> [ Data: 2003-02-01 ]
[ Subjecte: Re: Style fixups for proc.h ]
> > Julian Elischer writes:
> > > I don't know about the protection with a '_'.
> > >
> > > It's not standard and usually the name matches that used in the actual
> > > function.
> >
> > Wh
> Julian Elischer writes:
> > I don't know about the protection with a '_'.
> >
> > It's not standard and usually the name matches that used in the actual
> > function.
>
> When the prototype parameter name matches a local variable, the C compiler
> (and lint) whine about clashes between names in
On Sat, Feb 01, 2003 at 03:04:32PM -0800, Julian Elischer wrote:
> I don't know about the protection with a '_'.
>
> It's not standard and usually the name matches that used in the actual
> function.
>
> It's certainly not part of style(9) that I've ever noticed
> and it's generally noy done that
> :When the prototype parameter name matches a local variable, the C compiler
> :(and lint) whine about clashes between names in local/global namespace.
>
> I've never in my life heard of this behavior before, what compiler
> arguments reproduce it?
WARNS=5.
> :2 ways to fix this are to
Hi,
hw.ata.atapi_dma=1 ?
Martin
Martin Blapp, <[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
--
ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH
Phone: +41 61 826 93 00 Fax: +41 61 826 93 01
PGP:
PGP Fingerprint: B434 5
David Syphers wrote:
I recently installed 5.0-R (and KDE 3.1, thus the cc:). Ogle now has
terrible
performance - very jerky. Last weekend, when this computer (an Athlon XP
1800+) had 4-stable and KDE 3.0.5, ogle perfomance on the same DVD was
perfectly smooth. Since ogle didn't change, I assume
:Julian Elischer writes:
:> I don't know about the protection with a '_'.
:>
:> It's not standard and usually the name matches that used in the actual
:> function.
:
:When the prototype parameter name matches a local variable, the C compiler
:(and lint) whine about clashes between names in local/g
> Date: Sat, 1 Feb 2003 19:20:12 +0100
> From: Oliver Brandmueller <[EMAIL PROTECTED]>
> Sender: [EMAIL PROTECTED]
>
> Hi,
>
> I'm currently experimenting with 5-CURRENT on my Notebook an have a
> question regarding the concept of devd.
>
> With 4-STABLE I had pccardd running. Whenever a pccard
On Sat, 1 Feb 2003, Mark Murray wrote:
> Julian Elischer writes:
> > I don't know about the protection with a '_'.
> >
> > It's not standard and usually the name matches that used in the actual
> > function.
>
> When the prototype parameter name matches a local variable, the C compiler
> (and lin
Julian Elischer writes:
> I don't know about the protection with a '_'.
>
> It's not standard and usually the name matches that used in the actual
> function.
When the prototype parameter name matches a local variable, the C compiler
(and lint) whine about clashes between names in local/global na
I recently installed 5.0-R (and KDE 3.1, thus the cc:). Ogle now has terrible
performance - very jerky. Last weekend, when this computer (an Athlon XP
1800+) had 4-stable and KDE 3.0.5, ogle perfomance on the same DVD was
perfectly smooth. Since ogle didn't change, I assume it's something to do
Folks,
Please send this info to SOREN, not to the list.
Thanks,
Doug
--
If it's moving, encrypt it. If it's not moving, encrypt
it till it moves, then encrypt it some more.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
I don't know about the protection with a '_'.
It's not standard and usually the name matches that used in the actual
function.
It's certainly not part of style(9) that I've ever noticed
and it's generally noy done that way.. is there a move to do this on all
the other files?
On Sat, 1 Feb 2003,
atapci0: port 0xd800-0xd80f at device 0.1 on
pci0
agp0@pci0:0:0: class=0x06 card=0x chip=0x07301039 rev=0x02
hdr=0x00
atapci0@pci0:0:1: class=0x010180 card=0x80321043 chip=0x55131039
rev=0xd0 hdr=0x00
isab0@pci0:1:0: class=0x060100 card=0x chip=0x00081039 rev=0x00
hdr=0
Hi
OK to commit the style fixups below? (They just make sure that all
function prototypes have all arguments named, and that all names are
protected).
int foo(int bar);
becomes
int foo(int _bar);
M
Index: proc.h
===
RCS file: /ho
Dear/Beste Patrick,
Thursday, January 30, 2003, 8:37:04 PM, you wrote:
> has anyone every had problems with appending existing files on volumes
> mounted by smbfs or shlight?
$ echo "sdsad" >>> hey
$ echo "sdsad" >>> hey
> cannot create hey: Permission denied
You should look at permission on t
:> The ideal situation would be to have as Matt (and the comment
:> actually) says a cpu mask of idle cpus and generate an IPI to wake up
:> CPUs sitting in HLT when something hits the runqueue, then you can
:> just hlt all of them and rely on the IPI to wake you up, or the next
:> timer
In message <[EMAIL PROTECTED]>, Ju
lian Elischer writes:
>Oh shut up Poul-Henning.
Try to remain civil here Julian :-)
I tried to explain the situation to you, to make sure you would not be
tempted to do rush something which needs to take the time things take.
>I know I'm on your shit list, an
On Sat, Feb 01, 2003 at 01:28:45PM -0800, Terry Lambert wrote:
> Bosko Milekic wrote:
> > > > Or, as I explained in my previous post, only HLT the [virtual] CPU if
> > > > the other [virtual] CPU that is sharing the same execution & cache
> > > > units is not HLT'd itself. If the other one
Bosko Milekic wrote:
> > > Or, as I explained in my previous post, only HLT the [virtual] CPU if
> > > the other [virtual] CPU that is sharing the same execution & cache
> > > units is not HLT'd itself. If the other one is HLT'd, then not do the
> > > HLT.
> >
> > Actually, why is that? W
On Sat, 1 Feb 2003 [EMAIL PROTECTED] wrote:
> In message <[EMAIL PROTECTED]>, Ju
> lian Elischer writes:
>
> >still no comments?
>
> Julian, you sent this out a few hours ago, after people had spent
> a lot of time and getting quite frustrated trying to get you to
> DTRT with your mentee's ina
On Sat, Feb 01, 2003 at 12:47:59PM -0800, Terry Lambert wrote:
> Bosko Milekic wrote:
> > On Fri, Jan 31, 2003 at 11:52:53AM -0800, Matthew Dillon wrote:
> > > Another solution would be to have a global mask of 'idle' cpus and send
> > > an IPI to them when a new KSE is scheduled on a no
Bosko Milekic wrote:
> On Fri, Jan 31, 2003 at 11:52:53AM -0800, Matthew Dillon wrote:
> > Another solution would be to have a global mask of 'idle' cpus and send
> > an IPI to them when a new KSE is scheduled on a non-idle cpu that would
> > simply serve to wakeup the HLT. IPIs are
From time-to-time I notice people reporting lock-order-reversal
messages here. My system popped up with one sometime overnight,
I have no idea what it might have been doing at the time.
lock order reversal
1st 0xc0514fc0 arp mutex (arp mutex) @ /usr/src/sys/netinet/if_ether.c:151
2nd 0xc410707c
On Sat, Feb 01, 2003 at 12:02:05PM +0100, Soeren Schmidt wrote:
>
> I'm currently in the midst of an ATA chipset support mega rewrite/update,
> and the last item on the list is SiS support.
>
> That where _you_ come into the picture, I need a pciconf -l from your
> SiS based system!
>
> Just rep
In message <[EMAIL PROTECTED]>, Ju
lian Elischer writes:
>still no comments?
Julian, you sent this out a few hours ago, after people had spent
a lot of time and getting quite frustrated trying to get you to
DTRT with your mentee's inappropriate commit.
If people are sick and tired of you right n
still no comments?
this patch seems to be working, but a review from another developer
would be good.. particularly re: the point mentionned..
On Sat, 1 Feb 2003, Julian Elischer wrote:
>
> I'm working on backing out david's patch.
>
> Part of his megacommit was a patch that should ahve been
Hi,
I'm currently experimenting with 5-CURRENT on my Notebook an have a
question regarding the concept of devd.
With 4-STABLE I had pccardd running. Whenever a pccard was inserted I
had pccardd starting the corresponding scripts. I have configured devd
to do so now (especially for my wavelan pcca
It seems Christoph Kukulies wrote:
>
> I bought new hardware for a server today, an ASUS P4S8X with
> an 1.8 GHZ P4 CPU, nothing fancy I would say, which has an
> onboard RAID controller (Promise) but I'm not using it
> for the moment. I attached an IBM 60GB Deskstar ATA/IDE disk to
> the IDE 1 po
> Soeren Schmidt wrote:
> >I'm currently in the midst of an ATA chipset support mega rewrite/update,
> >and the last item on the list is SiS support.
> >
> >That where _you_ come into the picture, I need a pciconf -l from your
> >SiS based system!
> >
> >Just reply to this message with the output f
In message <[EMAIL PROTECTED]>, Christoph Kuk
ulies writes:
>
>I bought new hardware for a server today, an ASUS P4S8X with
>an 1.8 GHZ P4 CPU, nothing fancy I would say, which has an
>onboard RAID controller (Promise) but I'm not using it
>for the moment. I attached an IBM 60GB Deskstar ATA/IDE di
I bought new hardware for a server today, an ASUS P4S8X with
an 1.8 GHZ P4 CPU, nothing fancy I would say, which has an
onboard RAID controller (Promise) but I'm not using it
for the moment. I attached an IBM 60GB Deskstar ATA/IDE disk to
the IDE 1 port. FreeBSD 5.0R boots until the point where
it
agp0@pci0:0:0: class=0x06 card=0x chip=0x07301039 rev=0x02 hdr=0x00
atapci0@pci0:0:1: class=0x010180 card=0x0a011019 chip=0x55131039 rev=0xd0
hdr=0x00
isab0@pci0:1:0: class=0x060100 card=0x chip=0x00081039 rev=0x00 hdr=0x00
ohci0@pci0:1:2: class=0x0c0310 card=0x70011039
Soeren Schmidt wrote:
Just reply to this message with the output from pciconf -l and you
have helped me sort out the myriads of SiS chipsets out there.
~# pciconf -l
chip0@pci0:0:0: class=0x06 card=0x chip=0x55911039 rev=0x02 hdr=0x00
atapci0@pci0:0:1: class=0x010180 card=0x5
Hi,
chip0@pci0:0:0: class=0x06 card=0x chip=0x55711039 rev=0x01
hdr=0x00
isab0@pci0:1:0: class=0x060100 card=0x chip=0x00081039 rev=0x01
hdr=0x00
atapci0@pci0:1:1: class=0x01018a card=0x0063000d chip=0x55131039
rev=0xc1 hdr=0x00
none0@pci0:11:0: class=0x03 card=0x000
On Fri, Jan 31, 2003 at 11:52:53AM -0800, Matthew Dillon wrote:
> Another solution would be to have a global mask of 'idle' cpus and send
> an IPI to them when a new KSE is scheduled on a non-idle cpu that would
> simply serve to wakeup the HLT. IPIs are nasty, but there are large
On Fri, Jan 31, 2003 at 11:48:17AM -0800, Peter Wemm wrote:
> The cache and most of the execution hardware is shared. The execution
> units can run something like 4 instructions per clock. If the "idle"
> logical core is in a spinloop, then it is generating instructions for
> execution, so you a
On Sat, Feb 01, 2003 at 12:02:05PM +0100, Soeren Schmidt wrote:
> Just reply to this message with the output from pciconf -l and you
> have helped me sort out the myriads of SiS chipsets out there.
agp0@pci0:0:0: class=0x06 card=0x06481039 chip=0x06481039 rev=0x02 hdr=0x00
pcib1@pci0:1:0: cla
On Mon, 6 Jan 2003 11:17:23 +0100
Alexander Leidinger <[EMAIL PROTECTED]> wrote:
> On Fri, 03 Jan 2003 03:19:28 +0100
> Dag-Erling Smorgrav <[EMAIL PROTECTED]> wrote:
>
> > Alexander Leidinger <[EMAIL PROTECTED]> writes:
> > > Dag-Erling, any ideas?
> >
> > http://www.freebsd.org/cgi/query-pr.cg
I've reverted the patch in question.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
--
>>> Rebuilding the temporary build tree
--
>>> stage 1: bootstrap tools
--
>>> stage 2: cleaning up the object tree
Hope this helps:
agp0@pci0:0:0: class=0x06 card=0x chip=0x07351039 rev=0x01 hdr=0x00
pcib1@pci0:1:0: class=0x060400 card=0x chip=0x00011039 rev=0x00 hdr=0x01
isab0@pci0:2:0: class=0x060100 card=0x chip=0x00081039 rev=0x00 hdr=0x00
atapci0@pci0:2:5: class=0x010180
I'm currently in the midst of an ATA chipset support mega rewrite/update,
and the last item on the list is SiS support.
That where _you_ come into the picture, I need a pciconf -l from your
SiS based system!
Just reply to this message with the output from pciconf -l and you
have helped me sort o
I'm working on backing out david's patch.
Part of his megacommit was a patch that should ahve been separatly
handled.
I have split it out..
Can people have a look at it and see if it makes sense.
http://www.freebsd.org/~julian/lock.diff
basically locks need to be per thread but were per proces
I'm trying to generate and commit a correct backout of David's changes.
but since I have to synthesise the backout patch from cvs and check it
could people refrain from updating the following files?
I believe this is the complete set that are involved.
(if you know of any others let me know)
alph
77 matches
Mail list logo
