[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-25 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 Mark Johnston changed: What|Removed |Added Assignee|b...@freebsd.org|ma...@freebsd.org -- You are rece

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-25 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 Mark Johnston changed: What|Removed |Added Status|Open|In Progress --- Comment #11 from M

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-25 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #10 from commit-h...@freebsd.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3416f5cde7a7e01b25b5f5fd240ae8aa12fd70bf commit 3416f5cde7a7e01b25b5f5fd240ae8aa12fd70bf Author:

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-25 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #9 from Mark Johnston --- (In reply to ed crowe from comment #8) Ok. I will just go ahead and commit then, I think the patch is good. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-21 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #8 from ed crowe --- (In reply to Mark Johnston from comment #7) Thanks for the driver info. I think it is performing as expected. Neither devd's CPU nor WCPU went over 0.15% while madly waving a flash light in front of the mac

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-21 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #7 from Mark Johnston --- (In reply to ed crowe from comment #5) Thanks! With respect to interrupts, what happens in asmc(4) is that an interrupt triggers a call to asmc_sms_intrfast(), which determines the interrupt type, latc

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-20 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 ed crowe changed: What|Removed |Added Attachment #235042|0 |1 is obsolete|

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-20 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #5 from ed crowe --- Hello, I'm attaching a new patch that added a comment, a check for the model, and a new error message if the interrupt triggers on a different model than expected. I'm still looking into how drivers work in

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #4 from ed crowe --- Thank you both for the feed back. I will submit a few new options. I can confidently say the interrupt only triggers on a change of ambient light - up or down. The reason it triggers so often (for me at lea

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 David Bright changed: What|Removed |Added Flags|maintainer-feedback?(dab@fr |maintainer-feedback+

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-08 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #3 from David Bright --- (In reply to Mark Johnston from comment #2) I agree with Mark's suggestions. Other than that, the patch looks fine to me. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-04 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 --- Comment #2 from Mark Johnston --- I suspect that we should, at least, add some comment explaining why we don't print anything for the light sensor interrupt, and perhaps make that behaviour conditional on the model. And even if we sile

[Bug 265005] asmc(4): Add MacBookPro6,2 support

2022-07-02 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265005 Kubilay Kocak changed: What|Removed |Added CC||d...@freebsd.org,