[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

2022-06-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578 --- Comment #5 from Ed Maste --- I tested a build with three changes 1) change from comment #1 2) set -e in mk-vmimage.sh diff --git a/release/scripts/mk-vmimage.sh b/release/scripts/mk-vmimage.sh index d5985ceb0d25..d1cde2727edc 100755

[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

2022-06-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578 --- Comment #4 from Ed Maste --- (In reply to Li-Wen Hsu from comment #2) Right, I mean I didn't know whether an error return from whatever is being run by ${EMULATOR} was propagated up (but per the previous comment, it is) -- You are rec

[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

2022-06-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578 --- Comment #3 from Ed Maste --- This patch catches the error: > Package textproc/jq installation failed however release/scripts/mk-vmimage.sh does not check for errors from vm_extra_install_packages, so it carries on anyway: --- Package

[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

2022-06-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578 --- Comment #2 from Li-Wen Hsu --- (In reply to Ed Maste from comment #1) ${EMULATOR} is set for running qemu-user-static when doing cross-build -- You are receiving this mail because: You are the assignee for the bug.

[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

2022-06-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578 --- Comment #1 from Ed Maste --- (In reply to Dave Cottlehuber from comment #0) chroot should pass through the return value. (I have no idea whether ${EMULATOR} does, off hand) perhaps: diff --git a/release/tools/vmimage.subr b/release/to

[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

2022-06-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578 Bug ID: 264578 Summary: release/tools/vmimage.subr has no error handling for pkg failures Product: Base System Version: 13.1-RELEASE Hardware: Any OS: