[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 Mark Johnston changed: What|Removed |Added Assignee|b...@freebsd.org|ma...@freebsd.org --- Comment #14

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #13 from Mahmoud Abumandour --- Also, is there a patch-checking utility I can use to identify FreeBSD style issues? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #12 from Mahmoud Abumandour --- (In reply to Mark Johnston from comment #11) Thanks for the feedback. I will address it and resend the patch. Regarding setting readdir_errno only if readdir errs, how is this achievable without

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #11 from Mark Johnston --- (In reply to Mahmoud Abumandour from comment #6) Sorry for the delayed reply. This mostly looks ok to me, but I have a few more nits: - Rather than setting errno = 0 in fts_safe_readdir(), I think it'

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #10 from Ganael LAPLANCHE --- Hello Mark, Thanks for your previous feedback. Could you have a look at Mahmoud's updated patch ? Thanks in advance, Best regards, Ganael. -- You are receiving this mail because: You are the as

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #9 from Ganael LAPLANCHE --- Quick update : the patches look good to me, but let's wait for a src committer feedback :) -- You are receiving this mail because: You are the assignee for the bug.

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #8 from Ganael LAPLANCHE --- Hello Mahmoud, Thanks for your the update. Checking the "Obsoletes" box should be done when uploading the patch. I don't think we can do it afterwards (anyway, no worry, we will be able to follow t

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #7 from Mahmoud Abumandour --- I'm sorry but I can't find the "Obsoletes" box either in the bug main page or in the "add an attachment" page. Do I need a certain privilege to be able to obsolete someone else's patches? -- You

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #6 from Mahmoud Abumandour --- Created attachment 232355 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=232355&action=edit Check for readdir errors in fts Fix the bug for fts.c, fts-compat.c, and fts-compat11.c. I fo

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #5 from Mahmoud Abumandour --- Hello Ganael, I'm sorry this is taking too long. I don't want to post the patches without at least compiling libc to make sure I did not break anything and I was running though some troubles. Patc

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #4 from Ganael LAPLANCHE --- Just to add a precision: you should follow Mark's advice and probably re-gen my original patch too, just to be sure we provide the same code for the 3 files. Thanks! -- You are receiving this mail

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 --- Comment #3 from Ganael LAPLANCHE --- Hello Mahmoud, Feel free to update the patch if you like, no pb. Just attach your new patch (using the "Add an attachment" link). Also, do not forget to mark it as obsoleting my original patch by c

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 Mahmoud Abumandour changed: What|Removed |Added CC||ma.mando...@gmail.com --- Com

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 Mark Johnston changed: What|Removed |Added Status|New |Open CC|

[Bug 262038] fts(3): Check for readdir(3) errors

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 Ganael LAPLANCHE changed: What|Removed |Added Summary|fts: Check for readdir |fts(3): Check for