[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-12-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 Mark Johnston changed: What|Removed |Added Status|New |In Progress Assignee|b..

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-26 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 --- Comment #7 from commit-h...@freebsd.org --- A commit references this bug: Author: kib Date: Thu Nov 26 18:08:42 UTC 2020 New revision: 368075 URL: https://svnweb.freebsd.org/changeset/base/368075 Log: More careful handling of the mou

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 --- Comment #6 from Tong Zhang --- (In reply to Konstantin Belousov from comment #5) Right. Your observation is correct. -- I should have mentioned my reproducer is now triggering more warnings and panic before hitting the VFS_UNMOUNT() on

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-24 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 --- Comment #5 from Konstantin Belousov --- The patch in the review only modifies path for recovery for failed VFS_ROOT/VFS_STATFS. From the backtraces you printed I think that you tested successful mount which is not touched by the change

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 --- Comment #4 from Tong Zhang --- (In reply to Tong Zhang from comment #3) hmmm... after testing an unmodified r367963, my conclusion is that this lock order bug already exists in r367963 which is irrelevant to your patch. -- You are re

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 --- Comment #3 from Tong Zhang --- (In reply to Tong Zhang from comment #2) root@freebsd:~ # uname -a FreeBSD freebsd 13.0-CURRENT FreeBSD 13.0-CURRENT #9 r367963M: Tue Nov 24 02:20:06 UTC 2020 root@freebsd:/usr/obj/usr/src/amd64.amd64

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 --- Comment #2 from Tong Zhang --- (In reply to Konstantin Belousov from comment #1) lock order reversal: 1st 0xf80004da0258 ufs (ufs, lockmgr) @ /usr/src/sys/kern/vfs_mount.c:1739 2nd 0xf80004da0070 devfs (devfs, lockmgr) @ /us

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-23 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 Konstantin Belousov changed: What|Removed |Added CC||k...@freebsd.org --- Comment

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-22 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 Tong Zhang changed: What|Removed |Added Severity|Affects Only Me |Affects Many People -- You are recei

[Bug 251320] [PATCH] vfs_domount_first: do not crash on mount failure

2020-11-22 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251320 Tong Zhang changed: What|Removed |Added Summary|vfs_domount_first: do not |[PATCH] vfs_domount_first: