Re: [fprint] Improving the etes603 driver

2015-08-28 Thread Jason Gerard DeRose
Patrick, Another update: following your advice that tuning is where I should start, I made some big progress today, so thanks for the tip! I started by looking at what values your automatic tuning is setting for the hardware I'm testing on. When I first use the device, the initial tuning se

Re: [fprint] Improving the etes603 driver

2015-08-26 Thread Jason Gerard DeRose
Patrick, On 08/26/2015 02:53 PM, Patrick Marlier wrote: Jason, On 08/26/2015 05:57 PM, Jason Gerard DeRose wrote: Patrick, A little update on where I'm at with this. Through many iterations of adding extra debug logging and removing logging that was too noisy and wasn't helpful t

Re: [fprint] Improving the etes603 driver

2015-08-26 Thread Jason Gerard DeRose
4:26 AM, Patrick Marlier wrote: Jason, On Fri, Aug 21, 2015 at 6:18 PM, Jason Gerard DeRose wrote: etes603.c mentions: 1. Tuning of DTVRT for contact detection 2. Contact detection via capacitance Those 2 are the calibration issue for detecting a finger. 3. Capture mode using assembled frames

[fprint] patches: baby steps: fix some NULL pointer handling

2015-08-21 Thread Jason Gerard DeRose
ark_aborted(ssm, -1); + return; } img->flags = FP_IMG_V_FLIPPED; -- 2.5.0 >From a380556f0e66aeb07335079b297244c60bf15d53 Mon Sep 17 00:00:00 2001 From: Jason Gerard DeRose Date: Fri, 21 Aug 2015 14:56:06 -0600 Subject: [PATCH 2/2] img.c: fp_img_new(), fp_img_new_for_imgdev() assume g_mall

Re: [fprint] Improving the etes603 driver

2015-08-21 Thread Jason Gerard DeRose
Patrick, On 08/21/2015 01:41 AM, Patrick Marlier wrote: Hi Jason and Vasily, On Fri, Aug 21, 2015 at 3:58 AM, Vasily Khoruzhick wrote: Hi Jason, On Thu, Aug 20, 2015 at 11:51 AM, Jason Gerard DeRose wrote: Hello, I work at System76 and am going to take a stab at improving the etes603

Re: [fprint] Improving the etes603 driver

2015-08-21 Thread Jason Gerard DeRose
Vasily, On 08/20/2015 07:58 PM, Vasily Khoruzhick wrote: Hi Jason, On Thu, Aug 20, 2015 at 11:51 AM, Jason Gerard DeRose wrote: Hello, I work at System76 and am going to take a stab at improving the etes603 driver (1c7a:0603) as it's the fingerprint reader used in our current gener

[fprint] Improving the etes603 driver

2015-08-20 Thread Jason Gerard DeRose
Hello, I work at System76 and am going to take a stab at improving the etes603 driver (1c7a:0603) as it's the fingerprint reader used in our current generation hardware. I'm just starting to get my head around the code and was hoping folks here might be able to advise me on a few questions I cur