On Fri, Feb 16, 2018 at 12:14 PM, Marco Trevisan (Treviño)
wrote:
> Vasily,
>
> See https://github.com/3v1n0/libfprint/commit/8cb5e6945cc26 (and
> related code) in this device after every enroll stage (and after every
> image save) we need to perform the device reactivation...
That sounds like an
Vasily,
See https://github.com/3v1n0/libfprint/commit/8cb5e6945cc26 (and
related code) in this device after every enroll stage (and after every
image save) we need to perform the device reactivation...
Now, during enroll it's libfprint itself that keeps track of the
number of stages that have bee
On Thu, Feb 15, 2018 at 11:58 PM, Igor Filatov wrote:
> I think it would be better if libfprint simply called dev_activate each time
> it needed an image, including each enroll step, and then called
> dev_deactivate when it's done. Drivers should know whether they need to
> reactivate or not. But
On Thu, Feb 15, 2018 at 5:56 PM, Marco Trevisan (Treviño)
wrote:
> When a device has this flag set, it has to be re-activated at
> each enroll step, without performing any other cleanup.
>
> This allows to solve this such case in a cleaner way inside
> drivers.
What's the purpose of this change?
2018-02-16 14:38 GMT+01:00 Igor Filatov :
> Here's what I'm doing which isn't clean either
> https://github.com/iafilatov/libfprint/blob/elan/libfprint/drivers/elan.c#L525
> but allows to contain the ugliness to a small part of code. You actually
> don't need to deactivate manually until libfprint
Here's what I'm doing which isn't clean either
https://github.com/iafilatov/libfprint/blob/elan/libfprint/drivers/elan.c#L525
but
allows to contain the ugliness to a small part of code. You actually don't
need to deactivate manually until libfprint calls dev_deactivate. You only
need to keep submit
Hi Igor,
2018-02-16 8:58 GMT+01:00 Igor Filatov :
> I think it would be better if libfprint simply called dev_activate each time
> it needed an image, including each enroll step, and then called
> dev_deactivate when it's done. Drivers should know whether they need to
> reactivate or not. But this
