Re: [fprint] [PATCH] imgdev: add support for FP_IMGDRV_NEEDS_REACTIVATION_BETWEEN_ENROLLS flag

2018-02-15 Thread Igor Filatov
I think it would be better if libfprint simply called dev_activate each time it needed an image, including each enroll step, and then called dev_deactivate when it's done. Drivers should know whether they need to reactivate or not. But this will require changes to all the drivers of the devices tha

[fprint] [PATCH] imgdev: add support for FP_IMGDRV_NEEDS_REACTIVATION_BETWEEN_ENROLLS flag

2018-02-15 Thread Treviño
When a device has this flag set, it has to be re-activated at each enroll step, without performing any other cleanup. This allows to solve this such case in a cleaner way inside drivers. --- libfprint/fp_internal.h | 1 + libfprint/imgdev.c | 30 +++--- 2 files chang

[fprint] [PATCH] core: keep a reference on device and free dev list

2018-02-15 Thread Treviño
Fixes the memory leak on devs. I think it's better to keep a reference on the udev too, but this could be changed. --- libfprint/core.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libfprint/core.c b/libfprint/core.c index 81b972e..1c48bf1 100644 --- a/libfprint/core