Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Graeme Geldenhuys
On 06/10/2011 20:41, Reinier Olislagers wrote: > rem check setting - yes, input: > git config --global core.autocrlf > input The Git installation under Windows set mine to true (not input). > So while it could be used, I'd have to remember to run unix2dos over it > - that is, if people expect a

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Reinier Olislagers
On 7-10-2011 9:15, Graeme Geldenhuys wrote: > On 06/10/2011 20:41, Reinier Olislagers wrote: > The Git installation under Windows set mine to true (not input). true it is, see other message ;) >> So while it could be used, I'd have to remember to run unix2dos over it >> - that is, if people expect

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Marco van de Voort
In our previous episode, Graeme Geldenhuys said: > > So while it could be used, I'd have to remember to run unix2dos over it > > - that is, if people expect a Windows patch ( > > I don't think that is needed. I believe the 'patch' program will sort > that out by itself. I have sent numerous patche

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Reinier Olislagers
On 7-10-2011 9:15, Graeme Geldenhuys wrote: > I don't think that is needed. I believe the 'patch' program will sort > that out by itself. I have sent numerous patches to FPC and Lazarus > (both those repositories are git ones on my Linux system). Nobody has > ever complained that the EOL style was

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Graeme Geldenhuys
On 07/10/2011 11:28, Marco van de Voort wrote: > > Even up to date patch doesn't always process lineendings properly btw. I > have to dos2unix often on *nix too. Interesting. I would think sharing code between platform with patches is a bog-standard task these days, and all tools in question shou

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Graeme Geldenhuys
On 07/10/2011 12:52, Reinier Olislagers wrote: > doesn't work - will need patch -p1 < git.diff Correct, and anybody that has applied a handful of patches or more in there time would have known that already. ;-) Regards, - Graeme - -- fpGUI Toolkit - a cross-platform GUI toolkit using Free

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Reinier Olislagers
On 7-10-2011 15:13, Graeme Geldenhuys wrote: > On 07/10/2011 12:52, Reinier Olislagers wrote: >> doesn't work - will need patch -p1 < git.diff > > Correct, and anybody that has applied a handful of patches or more in > there time would have known that already. ;-) Sure, but why add to the aggravat

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Graeme Geldenhuys
On 07/10/2011 15:53, Reinier Olislagers wrote: > Sure, but why add to the aggravation - SVN diff doesn't do this, so one > less difference to worry about: It's still in the universal patch format, with or without the path prefixes. Also nobody should commit a patch blindly. They should review the

[fpc-pascal] [Total OT] Re: Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Lukasz Sokol
On 07/10/2011 14:53, Reinier Olislagers wrote: > On 7-10-2011 15:13, Graeme Geldenhuys wrote: >> On 07/10/2011 12:52, Reinier Olislagers wrote: >>> doesn't work - will need patch -p1 < git.diff >> >> Correct, and anybody that has applied a handful of patches or more in >> there time would have know

[fpc-pascal] Re: Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Reinier Olislagers
On 7-10-2011 11:28, Marco van de Voort wrote: > I usually apply patches on FreeBSD, and in rarer cases Linux. > > Even up to date patch doesn't always process lineendings properly btw. I > have to dos2unix often on *nix too. > > Recently a lot of patches with incorrect filenames, or no filenames

[fpc-pascal] Re: Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Reinier Olislagers
On 7-10-2011 16:08, Graeme Geldenhuys wrote: > On 07/10/2011 15:53, Reinier Olislagers wrote: >> Sure, but why add to the aggravation - SVN diff doesn't do this, so one >> less difference to worry about: > > It's still in the universal patch format, with or without the path > prefixes. Also nobody

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Florian Klämpfl
Am 07.10.2011 11:28, schrieb Marco van de Voort: > In our previous episode, Graeme Geldenhuys said: >>> So while it could be used, I'd have to remember to run unix2dos over it >>> - that is, if people expect a Windows patch ( >> >> I don't think that is needed. I believe the 'patch' program will so

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Florian Klämpfl
Am 07.10.2011 16:08, schrieb Graeme Geldenhuys: > On 07/10/2011 15:53, Reinier Olislagers wrote: >> Sure, but why add to the aggravation - SVN diff doesn't do this, so one >> less difference to worry about: > > It's still in the universal patch format, with or without the path > prefixes. Also nob

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Marco van de Voort
In our previous episode, Graeme Geldenhuys said: > > Even up to date patch doesn't always process lineendings properly btw. I > > have to dos2unix often on *nix too. > > Interesting. I would think sharing code between platform with patches is > a bog-standard task these days, and all tools in ques

Re: [fpc-pascal] Git line endings leading to patch problems - was [Semi-OT] Git format patches don't seem to work

2011-10-07 Thread Sven Barth
On 07.10.2011 20:44, Florian Klämpfl wrote: Am 07.10.2011 11:28, schrieb Marco van de Voort: In our previous episode, Graeme Geldenhuys said: So while it could be used, I'd have to remember to run unix2dos over it - that is, if people expect a Windows patch ( I don't think that is needed. I b