Re: [fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-21 Thread Noel Duffy via fpc-pascal
On 20/04/20 7:41 pm, Karoly Balogh (Charlie/SGR) wrote: Hi, On Mon, 20 Apr 2020, Noel Duffy via fpc-pascal wrote: I have already fixed it, with a simplistic fix, I think. Committed as SVN r44845. Great, good to know it's fixed. Not having the SVN repo to hand, I can't tell how recent that re

Re: [fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-20 Thread Marco van de Voort
Op 2020-04-20 om 09:41 schreef Karoly Balogh (Charlie/SGR): Great, good to know it's fixed. Not having the SVN repo to hand, I can't tell how recent that revision is. Has this change made it to any released version of the compiler? No. I just fixed it yesterday. :) So the fix is new. I'll proba

Re: [fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-20 Thread Karoly Balogh (Charlie/SGR)
Hi, On Mon, 20 Apr 2020, Noel Duffy via fpc-pascal wrote: > > I have already fixed it, with a simplistic fix, I think. Committed as > > SVN r44845. > > > Great, good to know it's fixed. Not having the SVN repo to hand, I can't > tell how recent that revision is. Has this change made it to any > r

Re: [fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-20 Thread Michael Van Canneyt
On Sun, 19 Apr 2020, Karoly Balogh (Charlie/SGR) wrote: Hi, On Sun, 19 Apr 2020, Michael Van Canneyt wrote: > The StrToHostAddr function in the sockets unit accepts negative octets > in the source ip address. Consider this program: This should indeed be ckecked. Please report this in the b

Re: [fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-19 Thread Noel Duffy via fpc-pascal
On 19/04/20 11:48 pm, Karoly Balogh (Charlie/SGR) wrote: Hi, On Sun, 19 Apr 2020, Michael Van Canneyt wrote: The StrToHostAddr function in the sockets unit accepts negative octets in the source ip address. Consider this program: This should indeed be ckecked. Please report this in the bugtra

Re: [fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-19 Thread Karoly Balogh (Charlie/SGR)
Hi, On Sun, 19 Apr 2020, Michael Van Canneyt wrote: > > The StrToHostAddr function in the sockets unit accepts negative octets > > in the source ip address. Consider this program: > > This should indeed be ckecked. > Please report this in the bugtracker, so we don't forget to look at it! I have

Re: [fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-19 Thread Michael Van Canneyt
On Sun, 19 Apr 2020, Noel Duffy via fpc-pascal wrote: Running fpc 3.0.4 on Fedora 30. The StrToHostAddr function in the sockets unit accepts negative octets in the source ip address. Consider this program: This should indeed be ckecked. Please report this in the bugtracker, so we don't fo

[fpc-pascal] StrToHostAddr in sockets unit accepts negative octets

2020-04-19 Thread Noel Duffy via fpc-pascal
Running fpc 3.0.4 on Fedora 30. The StrToHostAddr function in the sockets unit accepts negative octets in the source ip address. Consider this program: program ip4_neg; {$mode objfpc}{$H+} uses sockets; var ip4_addr: in_addr; begin ip4_addr := StrToHostAddr('172.-16.32.14'); if ip4_ad