Re: [fpc-pascal] Multi helpers

Ryan Joseph schrieb am Do., 28. Feb. 2019, 15:37: > > > > On Feb 28, 2019, at 1:51 AM, Sven Barth via fpc-pascal < > fpc-pascal@lists.freepascal.org> wrote: > > > > Yes, though the first step should probably be to rework your commits. > It's a bit of work, but that way you can nicely restructure

Re: [fpc-pascal] Multi helpers

> On Feb 28, 2019, at 1:51 AM, Sven Barth via fpc-pascal > wrote: > > Yes, though the first step should probably be to rework your commits. It's a > bit of work, but that way you can nicely restructure your commit history,get > rid of unintended changes(1) and maybe group the changes by func

Re: [fpc-pascal] Multi helpers

Ryan Joseph schrieb am Do., 28. Feb. 2019, 03:50: > posts getting blocked again, just sending this to see if it gets through. > > > On Feb 26, 2019, at 9:10 AM, Ryan Joseph > wrote: > > > > > > > >> On Feb 26, 2019, at 7:05 AM, Graeme Geldenhuys < > mailingli...@geldenhuys.co.uk> wrote: > >> > >

Re: [fpc-pascal] Multi helpers

posts getting blocked again, just sending this to see if it gets through. > On Feb 26, 2019, at 9:10 AM, Ryan Joseph wrote: > > > >> On Feb 26, 2019, at 7:05 AM, Graeme Geldenhuys >> wrote: >> >> Rather do as always recommended... develop in a "feature" branch. >> Branches are brilliant in

Re: [fpc-pascal] Multi helpers

On 25/02/2019 19:08, Ryan Joseph wrote: > git format-patch master --stdout > patch.diff Yuck! Rather do as always recommended... develop in a "feature" branch. Branches are brilliant in Git and most Git commands work better when branches are used. Also split your changes into multiple smaller com

Re: [fpc-pascal] Multi helpers

Am 25.02.2019 um 19:44 schrieb Sven Barth: Mattias Gaertner via fpc-pascal > schrieb am Mo., 25. Feb. 2019, 19:09: On Mon, 25 Feb 2019 12:49:16 -0500 Ryan Joseph mailto:r...@thealchemistguild.com>> wrote: > > On Feb 25, 2019, at 12:41 PM, Mat

Re: [fpc-pascal] Multi helpers

Slightly unrelated question but one that will come up again soon. When I submitted my last patch I was told it would be best to put the tests in a different patch (so I submitted two). Does anyone know how to do that? This is the command I used: git format-patch master --stdout > patch.diff wh

Re: [fpc-pascal] Multi helpers

Mattias Gaertner via fpc-pascal schrieb am Mo., 25. Feb. 2019, 19:09: > On Mon, 25 Feb 2019 12:49:16 -0500 > Ryan Joseph wrote: > > > > On Feb 25, 2019, at 12:41 PM, Mattias Gaertner via fpc-pascal > > > wrote: > > > > > > At least FPC helpers are more consistent than Delphi. > > > inherited cr

Re: [fpc-pascal] Multi helpers

Ryan Joseph schrieb am Mo., 25. Feb. 2019, 19:00: > Question, is this mode switch allowed in Delphi mode? I disabled it > because I had a comment that said it was ObjFPC mode only but that doesn’t > make sense it couldn’t be enabled manually even in Delphi mode. > Mattias already answered, but n

Re: [fpc-pascal] Multi helpers

> On Feb 25, 2019, at 1:12 PM, Mattias Gaertner via fpc-pascal > wrote: > > Since $modeswitch typehelpers is allowed in mode delphi, it would be > inconsistent to forbid it. Good point, I didn’t know that. I’ve correct this on GitHub. Regards, Ryan Joseph ___

Re: [fpc-pascal] Multi helpers

On Mon, 25 Feb 2019 12:20:13 -0500 Ryan Joseph wrote: > Question, is this mode switch allowed in Delphi mode? I disabled it > because I had a comment that said it was ObjFPC mode only but that > doesn’t make sense it couldn’t be enabled manually even in Delphi > mode. Since $modeswitch typehelpe

Re: [fpc-pascal] Multi helpers

On Mon, 25 Feb 2019 12:49:16 -0500 Ryan Joseph wrote: > > On Feb 25, 2019, at 12:41 PM, Mattias Gaertner via fpc-pascal > > wrote: > > > > At least FPC helpers are more consistent than Delphi. > > inherited crap > > I’m pretty confident I didn’t add anything extra in terms of logic. > All my

Re: [fpc-pascal] Multi helpers

Question, is this mode switch allowed in Delphi mode? I disabled it because I had a comment that said it was ObjFPC mode only but that doesn’t make sense it couldn’t be enabled manually even in Delphi mode. Regards, Ryan Joseph ___ fpc-pascal

Re: [fpc-pascal] Multi helpers

> On Feb 25, 2019, at 12:41 PM, Mattias Gaertner via fpc-pascal > wrote: > > At least FPC helpers are more consistent than Delphi. > inherited crap I’m pretty confident I didn’t add anything extra in terms of logic. All my changes did are instead of checking the last helper declared, it now

Re: [fpc-pascal] Multi helpers

On Mon, 25 Feb 2019 11:44:35 -0500 Ryan Joseph wrote: > Update on multi-scope helpers. I’ve added tests (tmshlp*.pp), fixed a > bug and renamed the mode switch to “multihelpers” which I think is > more concise than “multiscopehelpers” and fits the format with > “typehelpers”. Thanks! Good that

[fpc-pascal] Multi helpers

Update on multi-scope helpers. I’ve added tests (tmshlp*.pp), fixed a bug and renamed the mode switch to “multihelpers” which I think is more concise than “multiscopehelpers” and fits the format with “typehelpers”. Any better ideas are welcome of course. I’ve made all the tests I could think of