Re: [PATCH] tree-optimization/111779 - Handle some BIT_FIELD_REFs in SRA

(expr) == IMAGPART_EXPR > >|| TREE_CODE (expr) == REALPART_EXPR) > > { > > @@ -1170,6 +1186,7 @@ build_access_from_expr_1 (tree expr, gimple *stmt, > > bool write) case COMPONENT_REF: > > case ARRAY_REF: > > case ARRAY_RANGE_REF: > > +case BIT_FIELD_REF: > >ret = create_access (expr, stmt, write); > >break; > > > > @@ -1549,6 +1566,7 @@ make_fancy_name_1 (tree expr) > >obstack_grow (&name_obstack, buffer, strlen (buffer)); > >break; > > > > +case BIT_FIELD_REF: > > case ADDR_EXPR: > >make_fancy_name_1 (TREE_OPERAND (expr, 0)); > >break; > > @@ -1564,7 +1582,6 @@ make_fancy_name_1 (tree expr) > > } > >break; > > > > -case BIT_FIELD_REF: > > case REALPART_EXPR: > > case IMAGPART_EXPR: > >gcc_unreachable (); /* we treat these as scalars. */ > > @@ -3769,7 +3786,8 @@ sra_modify_expr (tree *expr, gimple_stmt_iterator > > *gsi, bool write) tree type, bfr, orig_expr; > >bool partial_cplx_access = false; > > > > - if (TREE_CODE (*expr) == BIT_FIELD_REF) > > + if (TREE_CODE (*expr) == BIT_FIELD_REF > > + && (write || !sra_handled_bf_read_p (*expr))) > > { > >bfr = *expr; > >expr = &TREE_OPERAND (*expr, 0); > > > -- Andre Vehreschild * Email: vehre ad gmx dot de

[Patch, PR Fortran/90069] Polymorphic Return Type Memory Leak Without Intermediate Variable

Souvereign Tech Fund. Yes, the funding has been granted and Nicolas, Mikael and me will be working on some Fortran topics in the next 12-18 months. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From edd6c94b802732b0dd742ef9eca4d74aaaf6d91b Mon Sep 17 00:00:00 2001 From: Andre

Re: [Patch, PR Fortran/90069] Polymorphic Return Type Memory Leak Without Intermediate Variable

some light. Thanks you very much for that. Regards, Andre On Tue, 28 May 2024 21:45:56 +0200 Harald Anlauf wrote: > Hi Andre, > > On 5/28/24 14:10, Andre Vehreschild wrote: > > Hi all, > > > > the attached patch fixes a memory leak with unlimited polymorphic

[GOMP, Fortran] RFC: Issues with gomp-fortran tests

;" } { set lang_source_re {^.*\.[fF](|90|95|03|08)$} This is just a first shot. With the patch the test compile and run ok. But now my question: What am I doing wrong? I am working on gcc-master with only a few commits behind. Is testing libgomp-fortran fine for everyone else? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

[Patch, PR Fortran/90072] Polymorphic Dispatch to Polymophic Return Type Memory Leak

, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From e79072de7279cc6863914588e4a0457f0c3493fd Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Wed, 19 Jul 2023 11:57:43 +0200 Subject: [PATCH] Fix returned type to be allocatable for user-functions. The returned type of user

[Patch, Fortran/90068] Add finalizer creation to array constructor for functions of derived type.

, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 367e8be8945a32dcb24c4bfb9558abf687a53fe0 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Thu, 27 Jul 2023 14:51:34 +0200 Subject: [PATCH] Add finalizer creation to array constructor for functions of derived type. PR fortran/90068

Re: [GOMP, Fortran] RFC: Issues with gomp-fortran tests

tests only when the libs are not found? > PS: Welcome back to the gfortran effort. Thanks, I hope to produce a constant stream of patches in the next year or even longer. Thank you for your time. If you have any other idea that I could test, please let me know. Regards, Andre

Re: [Patch, PR Fortran/90072] Polymorphic Dispatch to Polymophic Return Type Memory Leak

hanks again for the review. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Commited, Patch, Fortran/90068] Add finalizer creation to array constructor for functions of derived type.

to this. This sounds to me like another application for a try-finally, but that is just a first shot w/o any deep thought on the aspects. If you like a rubber ducking feel free to contact me. Sometimes talking about it helps... Thanks again and regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, fortran] PR59104

res that: > (i) These variables are placed correctly in the tlink chain, respecting > inter-dependencies; and (ii) The dependent initializations are placed at > the end of the wrapped block init chain. The details appear in the > comments in the patch. It is entirely possible that a less clunky fix > exists but I failed to find it. > > OK for mainline? > > Regards > > Paul -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, PR Fortran/90072] Polymorphic Dispatch to Polymophic Return Type Memory Leak

question about me issue with doing gomp-fortran tests: https://gcc.gnu.org/pipermail/fortran/2024-June/060542.html Do you have any insight of what I am doing wrong? Regards, Andre On Sat, 8 Jun 2024 21:52:42 +0200 Tobias Burnus wrote: > Andre Vehreschild wrote: > >> PS

[Patch, Fortran] 0/3 (PR90076) Setting _vptr correctly.

understand that this is long way to go. Therefore I first like to ask about the general perception of this idea. So I like to hear constructive criticism. Could I explain it good enough? Do you think it is worth pursuing? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

[Patch, Fortran] 2/3 Refactor locations where _vptr is (re)set.

? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From f9018fa7d4dc752331e62963c9cf86ab01a1bfc5 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Fri, 7 Jun 2024 08:57:36 +0200 Subject: [PATCH 2/3] Use gfc_reset_vptr more consistently. The vptr for a class type is set in

[Patch, Fortran, 90076] 1/3 Fix Polymorphic Allocate on Assignment Memory Leak

x86_64 Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From e3a7f07e7dfad7ab347f148d2d46b633c0bbdecc Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Thu, 6 Jun 2024 14:01:13 +0200 Subject: [PATCH 1/3] Fortran: Set the vptr of a class typed

[Patch, Fortran] 3/3 RFC: Introduce gfc_class_set_vptr.

. What do you think? On x86_66 Fedora 39 this regtests fine. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 9847eaa6aa96eead01ab26800812bc5aeb6443d2 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Tue, 11 Jun 2024 12:52:26 +0200 Subject: [PATCH 3/3] Add

[Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs

was derefed as an array, but it was no array. Introducing the test for the descriptor removes the ICE. Regtests ok on x86_64-linux/Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From e56f32ed836c1ecc2b46497d1d7b9c7c08749521 Mon Sep 17 00:00:00

Re: [Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs

Jun 2024 16:12:38 +0200 Andre Vehreschild wrote: > Hi all, > > attached patch has already been present in 2020, but lost my attention. It > fixes an ICE in the testsuite. The old mails description is: > > attached patch fixes PR96418 where the code in the testsuite when compile

Re: [Patch, fortran] PR59104

ve comments. I think that I have > incorporated them fully in the attached. > > OK for mainline and ...? > > Paul > > > On Mon, 10 Jun 2024 at 08:19, Andre Vehreschild wrote: > > > Hi Paul, > > > > while looking at your patch I see calls to gfc_add_init_c

[Fortran, Patch, PR 96992] Fix Class arrays of different ranks are rejected as storage association argument

them. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 86ac3179e1314ca1c41f52025c5a156ad7346dc1 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Fri, 14 Jun 2024 16:54:37 +0200 Subject: [PATCH] Fortran: [PR96992] Fix rejecting class arrays of different ranks as stor

Re: [Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs

*** > > Thanks for the patch! > > Harald > > > Am 14.06.24 um 09:22 schrieb Andre Vehreschild: > > Hi all, > > > > I messed up renaming of the coarray_alloc_comp-test. This is fixed in the > > second version of the patch. Sorry for the inconvenience. > &g

Re: [Fortran, Patch, PR 96992] Fix Class arrays of different ranks are rejected as storage association argument

allocated potentially by pack, and also updated the testcase to include the negative stride. Regtests fine on x86_64-pc-linux-gnu/Fedora 39. Ok for mainline? Regards, Andre On Sun, 16 Jun 2024 23:27:46 +0200 Harald Anlauf wrote: << snipped for brevity >>> -- Andre Vehreschild * E

Re: [PATCH] Fortran: fix for CHARACTER(len=*) dummies with bind(C) [PR115390]

linux-gnu. OK for mainline? > > Thanks, > Harald > -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, Fortran, 90076] 1/3 Fix Polymorphic Allocate on Assignment Memory Leak

> Paul > > > On Tue, 11 Jun 2024 at 13:57, Andre Vehreschild wrote: > > > Hi all, > > > > the attached patch fix the last case in the bug report. The inital example > > code > > is already fixed by the combination of PR90068 and PR90072. The issue

Re: [Patch, Fortran] 2/3 Refactor locations where _vptr is (re)set.

on my > side. I like gfc_class_set_vptr. Please remove the commented out assert, > unless you intend to deploy it. > > OK for mainline. > > Thanks for the patches. > > Regards > > Paul > > > On Fri, 21 Jun 2024 at 07:39, Andre Vehreschild wrote: > > > Hi Paul

Re: [Patch, fortran] PR102689 - Segfault with RESHAPE of CLASS as actual argument

most of the test statements are factored out into > their own subroutines in order to expose the code generated for each. This > was essential for the debugging but can be undone if preferred. > > Regtests just fine - OK for mainline? > > Paul -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, fortran] PR102689 - Segfault with RESHAPE of CLASS as actual argument

t; happy to do the rest and to assign this patch to the dustbin of history. It > should be rather straightforward to provide an interface to the existing > library functions that produces significantly less inline code than my > implementation. > > I will commit the patch, though, and will revert as and when class-aware > library functions are in place. > > Thanks again > > Paul -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Linaro-TCWG-CI] gcc patch #93154: FAIL: 1 regressions on arm

e me with any insights; eg, by rerunning the testcase outside > of the dejagnu framework? > > Thank you for doing this testing, by the way, even if the failure is a bit > obscure at the moment. > > Best regards > > Paul -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [PATCH] Fortran: fix associate with assumed-length character array [PR115700]

t; As the PR is marked as a regression, is it also OK for backporting? > > Thanks, > Harald > -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Fortran, Patch, PR 96992, V3] Fix Class arrays of different ranks are rejected as storage association argument

nlauf wrote: > Hi Andre, > > Am 19.06.24 um 09:07 schrieb Andre Vehreschild: > > Hi Harald, > > > > thank you for the investigation and useful tips. I had to figure what went > > wrong here, but I now figured, that the array needs repacking when a > > negativ

Re: [Fortran, Patch, PR 96992, V4] Fix Class arrays of different ranks are rejected as storage association argument

39. Ok for mainline? Regards, Andre On Fri, 5 Jul 2024 22:10:16 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 03.07.24 um 12:58 schrieb Andre Vehreschild: > > Hi Harald, > > > > I am sorry for the long delay, but fixing the negative stride lead from one > > iss

[Fortran, Patch, PR78466, coarray, v1] Fix Explicit cobounds of a procedures parameter not respected

, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 32d8a8da4e1e6120c515932878994514e04c909d Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Thu, 31 Dec 2020 10:40:30 +0100 Subject: [PATCH] Fortran: Fix Explicit cobounds of a procedures parameter not respected [PR78466

[Fortran, Patch, PR82904] Fix [11/12/13/14/15 Regression][Coarray] ICE in make_ssa_name_fn, at tree-ssanames.c:261

th is of course still provided and needed later on. I hope this fixes the ICE in the IPA: inline phase, because I never saw it. Is that what you had in mind @Richard? Regtests ok on x86_64-pc-linux-gnu/Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx d

Re: [Fortran, Patch, PR 96992, V4] Fix Class arrays of different ranks are rejected as storage association argument

Hi Harald, thank you very much for ok'ing this large patch. Merged as gcc-15-1965-ge4f2f46e015 Looking forward to get (no) bug reports ;-) Thanks again, Andre On Wed, 10 Jul 2024 20:52:37 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 10.07.24 um 10:45 schrieb Andre Vehre

Re: [Fortran, Patch, PR 96992, V4] Fix Class arrays of different ranks are rejected as storage association argument

Hi Richard, I am sorry to hear that. Shall I revert? - Andre On Thu, 11 Jul 2024 10:57:48 +0200 Richard Biener wrote: > On Thu, Jul 11, 2024 at 10:54 AM Richard Biener > wrote: > > > > On Thu, Jul 11, 2024 at 10:04 AM Andre Vehreschild > > wrote: > > > &

Re: [Fortran, Patch, PR 96992, V4] Fix Class arrays of different ranks are rejected as storage association argument

Hi Richard, would that be sufficient? Bootstrap is still running for me... From c30c2cf829a094ba5e4c2c31333bed6e8c0d32af Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Thu, 11 Jul 2024 11:21:04 +0200 Subject: [PATCH] [Fortran] Fix bootstrap broken by gcc-15-1965-ge4f2f46e015 gcc

Re: [Fortran, Patch, PR 96992, V4] Fix Class arrays of different ranks are rejected as storage association argument

Hi Richard, bootstrap finally passed and the fix is now merged as gcc-15-1971-gb9513c6746b Thanks for your patience. - Andre On Thu, 11 Jul 2024 14:01:02 +0200 Richard Biener wrote: > On Thu, Jul 11, 2024 at 11:24 AM Andre Vehreschild > wrote: > > > > Hi Richard, >

[Patch, Fortran, PR88624, v1] Fix Rejects allocatable coarray passed as a dummy argument

Hi all, attached patch fixes using of coarrays as dummy arguments. The coarray dummy argument was not dereferenced correctly, which is fixed now. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline. Regards, Andre -- Andre Vehreschild * Email: vehre ad gcc dot gnu dot org

[Patch, Fortran, PR84244, v1] Fix ICE in recompute_tree_invariant_for_addr_expr, at tree.c:4535

, Andre -- Andre Vehreschild * Email: vehre ad gcc dot gnu dot org From 88f209316a980fbe78423d6aba747bb6b7fd404f Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Thu, 11 Jul 2024 15:44:56 +0200 Subject: [PATCH] [Fortran] Fix ICE in recompute_tree_invariant_for_addr_expr, at tree.c:4535 [PR84244

Re: [Patch, fortran] PR84868 - [11/12/13/14/15 Regression] ICE in gfc_conv_descriptor_offset, at fortran/trans-array.c:208

gmail.com> wrote: > > > > > >> Hi All, > > >> > > >> After messing around with argument mapping, where I found and fixed > > >> another bug, I realised that the problem lay with simplification of > > >> len_trim with an argument that is the element of a parameter array. The > > fix > > >> was then a straightforward lift of existing code in expr.cc. The mapping > > >> bug is also fixed by supplying the se string length when building > > character > > >> typespecs. > > >> > > >> Regtests just fine. OK for mainline? I believe that this is safe for > > >> backporting to 14-branch before the 14.2 release - thoughts? > > > > If you manage to correct/fix the above issues, I am fine with > > backporting, as this appears a very reasonable fix. > > > > Thanks, > > Harald > > > > >> Regards > > >> > > >> Paul > > >> > > > > > > > -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, fortran] PR84868 - [11/12/13/14/15 Regression] ICE in gfc_conv_descriptor_offset, at fortran/trans-array.c:208

> >> > Paul > >> > > >> > > >> > On Sat, 13 Jul 2024 at 10:58, Paul Richard Thomas < > >> > paul.richard.tho...@gmail.com> wrote: > >> > > >> >> Hi All, > >> >> > >> >> After messing around with argument mapping, where I found and fixed > >> >> another bug, I realised that the problem lay with simplification of > >> >> len_trim with an argument that is the element of a parameter array. > >> The fix > >> >> was then a straightforward lift of existing code in expr.cc. The > >> mapping > >> >> bug is also fixed by supplying the se string length when building > >> character > >> >> typespecs. > >> >> > >> >> Regtests just fine. OK for mainline? I believe that this is safe for > >> >> backporting to 14-branch before the 14.2 release - thoughts? > >> > >> If you manage to correct/fix the above issues, I am fine with > >> backporting, as this appears a very reasonable fix. > >> > >> Thanks, > >> Harald > >> > >> >> Regards > >> >> > >> >> Paul > >> >> > >> > > >> > >> -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Ping, Fortran, Patch, PR78466, coarray, v1.1] Fix Explicit cobounds of a procedures parameter not respected

Hi all, just pinging on this patch. The attached patch is rebased to an unmodified master as of this afternoon (CEST 3 p.m.). Anyone in for a review? Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre On Wed, 10 Jul 2024 11:17:44 +0200 Andre Vehreschild

Re: [Ping, Fortran, Patch, PR82904] Fix [11/12/13/14/15 Regression][Coarray] ICE in make_ssa_name_fn, at tree-ssanames.c:261

Hi all, pinging for attached patch rebased on master and my patch for 78466. Anyone in for a review? Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre On Wed, 10 Jul 2024 14:51:53 +0200 Andre Vehreschild wrote: > Hi all, > > the patch attached

Re: [Ping, Patch, Fortran, PR88624, v1] Fix Rejects allocatable coarray passed as a dummy argument

Hi all, and another ping... Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? - Andre On Thu, 11 Jul 2024 15:42:54 +0200 Andre Vehreschild wrote: > Hi all, > > attached patch fixes using of coarrays as dummy arguments. The coarray > dummy argument was not

Re: [Ping, Patch, Fortran, PR84244, v1] Fix ICE in recompute_tree_invariant_for_addr_expr, at tree.c:4535

Hi all, and the last ping. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre On Thu, 11 Jul 2024 16:05:09 +0200 Andre Vehreschild wrote: > Hi all, > > the attached patch fixes a segfault in the compiler, where for pointer > components of a

[Fortran, Patch, coarray, PR84246] Fix for [Coarray] ICE in conv_caf_send, at fortran/trans-intrinsic.c:1950

actions. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From e073b32bd792f7db92334e89e546095c9ad583f8 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Wed, 17 Jul 2024 12:30:52 +0200 Subject: [PATCH

Re: [Patch, fortran] PR108889 -[12/13/14/15 Regression] (Re)Allocate in assignment shows used uninitialized memory warning with -Wall if LHS is unallocated

Andre On Thu, 18 Jul 2024 06:55:14 +0100 Paul Richard Thomas wrote: > Hi All, > > This patch is simple and well described by the ChangeLogs and the > comments. Regtests OK. > > OK for mainline and backporting? > > Cheers > > Paul -- Andre Vehreschild * Email: vehre ad gcc dot gnu dot org

Re: [Fortran, Patch, PR82904] Fix [11/12/13/14/15 Regression][Coarray] ICE in make_ssa_name_fn, at tree-ssanames.c:261

cide whether to > backport in time for the 14.2 release. > > Regards > > Paul On Wed, 10 Jul 2024 14:51:53 +0200 Andre Vehreschild wrote: > Hi all, > > the patch attached fixes the use of an uninitialized variable for the > string length in the declaration of the

Re: [Patch, fortran] PR108889 -[12/13/14/15 Regression] (Re)Allocate in assignment shows used uninitialized memory warning with -Wall if LHS is unallocated

ind to it :-( Dead code duly removed. > > Thanks for the review. > > Paul -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 178 3837536 * ve...@gmx.de

Re: [Ping, Fortran, Patch, PR78466, coarray, v1.1] Fix Explicit cobounds of a procedures parameter not respected

--- > > work on the declared type. All array types other than deferred > shape or > 546c546 > < +call st(A) ! FIXME > --- > > +call st(A) > > As far as I am concerned, it is OK for mainline. > > Thanks for the patch > > Paul > > > On Wed, 17 Jul 2024 a

[Fortran, Patch, PR77518, (coarray), v1] Fix ICE in sizeof(coarray)

Hi all, the attached patch fixes an ICE when the object supplied to sizeof() is a coarray of class type. This is fixed by taking the class object from the se's class_container. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild *

Re: [Fortran, Patch, PR77518, (coarray), v2] Fix ICE in sizeof(coarray)

dig deeper to figure what is going on and how to resolve it. > A micro-nit line 12 s/User/Use/ Ups, thanks, fixed. Not merging yet, therefore updated patch attached. - Andre > > Apart from this, it looks to be eminently obvious. OK for mainline. > > Paul > > > On Thu, 1

Re: [PATCH] Fortran: character array constructor with >= 4 constant elements [PR103115]

ment-wise. > > Regtested on x86_64-pc-linux-gnu. OK for mainline / backports? > > Thanks, > Harald > -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Ping, Patch, Fortran, PR88624, v1] Fix Rejects allocatable coarray passed as a dummy argument

> Paul > > > On Wed, 17 Jul 2024 at 14:10, Andre Vehreschild wrote: > > > Hi all, > > > > and another ping... > > > > Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? > > > > - Andre > > > > On Thu, 11 Jul 2024 15:

[Fortran, Patch, PR85510, v1] Fix coarray token in associate not linking

, so my solution may be wrong. The essence of my patch is to ensure, that the namespace the symbol is in is not caused by an associate command. I hope this is the way to go. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad

Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]

ide. (I will file a PR about this) > > > > As COMMON as issues, an alternative would be to defer the trans-common.cc > > changes to a later patch. > > > > Comments, questions, concerns? > > > > Tobias > > > > PS: Tested with nvptx offloading with a page-migration supporting system > > with nvptx and GCN offloading configured and no new fails observed. -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]

Andre On Mon, 29 Jul 2024 09:29:28 +0200 Tobias Burnus wrote: > Hi Andre, > > Andre Vehreschild wrote: > > I am wondering why the testcase has no `!{ dg-do ... }` line. What will > > dejagnu do then? Sorry for the may be stupid question, but I never > > encountered a t

Re: [Patch, libgfortran] PR105361 Followup fix to test case

b > real :: c, d > open(10, access="stream") > - write(10) "1 2" ! // NEW_LINE('A') > + write(10) "1 2" // NEW_LINE('A') > close(10) > open(10) > read(10,*) c, d -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, Fortran] PR104626 ICE in gfc_format_decoder, at fortran/error.cc:1071

ave = s; > diff --git a/gcc/testsuite/gfortran.dg/pr104626.f90 > b/gcc/testsuite/gfortran.dg/pr104626.f90 > new file mode 100644 > index 000..faff65a8c92 > --- /dev/null > +++ b/gcc/testsuite/gfortran.dg/pr104626.f90 > @@ -0,0 +1,8 @@ > +! { dg-do compile } > +program p > + procedure(g), save :: f ! { dg-error "PROCEDURE attribute conflicts" } > + procedure(g), save :: f ! { dg-error "Duplicate SAVE attribute" } > +contains > + subroutine g > + end > +end -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Ping 2, Patch, Fortran, PR84244, v3] Fix ICE in recompute_tree_invariant_for_addr_expr, at tree.c:4535

Ping! On Wed, 17 Jul 2024 15:11:33 +0200 Andre Vehreschild wrote: > Hi all, > > and the last ping. > > Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? > > Regards, > Andre > > On Thu, 11 Jul 2024 16:05:09 +0200 > Andre Vehreschild

Re: [Ping, Fortran, Patch, coarray, PR84246, v2] Fix for [Coarray] ICE in conv_caf_send, at fortran/trans-intrinsic.c:1950

Ping! On Wed, 17 Jul 2024 15:15:51 +0200 Andre Vehreschild wrote: > Hi all, > > attached patch fixes an ICE in coarray code, where the coarray expression > already was a pointer, which confused the compiler. Furthermore have I removed > a rewrite to a caf_send late in the trans

Re: [Ping, Fortran, Patch, PR77518, (coarray), v3] Fix ICE in sizeof(coarray)

Ping! @Paul, you already had a look at this patch, but I made some changes. Or they ok? - Andre On Fri, 19 Jul 2024 13:26:21 +0200 Andre Vehreschild wrote: > Hi Paul, > > thanks for the review. > > > While I realise that this is not your doing, should we not > >

Re: [Ping, Fortran, Patch, PR85510, v2] Fix coarray token in associate not linking

Ping! And the last ping in the series. I have a "bigger" patch in the queue and want the pending ones done beforehand. Regtested ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? - Andre On Mon, 22 Jul 2024 16:35:28 +0200 Andre Vehreschild wrote: > Hi all, hi Paul, > &

Re: [Ping, Fortran, Patch, PR85510, v2] Fix coarray token in associate not linking

Hi Jerry, thanks for the review. Commited as gcc-15-2882-g8d8db21eb72. Thanks again and regards, Andre On Fri, 9 Aug 2024 10:35:26 -0700 Jerry Delisle wrote: > Ok and thanks. > > On Fri, Aug 9, 2024, 7:33 AM Andre Vehreschild wrote: > > > Ping! > > > > A

[Fortran, Patch, PR110033, v1] Fix associate for coarrays

seconds real user time (i.e. time's "real" row) on a rather old Intel i7-5775C@3.3GHz with 24G RAM that was used for work during the test. If need be I can tuned that more. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild *

Re: [patch, fortran] First part of Fortran's unsigned implementation

as possible; > I would then start working on the array intrinsics. > > Regarding where to put this: Paul, you had the idea of making this > dependent on a future standard plan. I think we can do this, setting > -funsigned when this is flag is set. > > Where to put the test cases: I currently have them in the main > gfortran.dg directory. A subdirectory might also be a good idea, > but then somebody would have to help me withe DejaGnu code to > put there. > > So... Comments? Suggestions? OK for master? > > Best regards > > Thomas > -- Andre Vehreschild * Email: vehre ad gmx dot de

[Fortran, Patch, PR116292, v1] Fix 15-regression in move_alloc

Andre PS. This patch was made with all of my other pending patches on the same branch. So it may not apply clean to master. -- Andre Vehreschild * Email: vehre ad gmx dot de From 4b19d871a3f5a4cdaf0fef6200ddaf51d6c8a8c4 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Fri, 9 Aug 2024 16:19:23

[Fortran, Patch, PR102973, v1] Reset flag for parsing proc_ptrs in associate in error case

error case than not to do it. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 02e96672b2c9891ade40497298e2c69652e3d321 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Tue, 13 Aug 2024 15:06:56

Re: [PATCH] Fortran: fix minor frontend GMP leaks

> I found two minor memleaks with GMP variables that were not cleared. > > Regtested on x86_64-pc-linux-gnu. > > I intend to commit to mainline soon unless there are comments. > > (And no, this does not address the recent intermittent runtime failures > reported in pr116261).

Re: [Fortran, Patch, PR116292, v1] Fix 15-regression in move_alloc

consistently. The patch gets the _vptr only of a > > derived or class type now and not of every type. > > > > Regression tested ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? > > OK (and looks obvious, too). > > Best regards > > Thomas > -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Fortran, Patch, PR102973, v1] Reset flag for parsing proc_ptrs in associate in error case

second part of the patch. This would then allow to get the dependencies of the ASSOCIATE-PR to zero. Thanks again and regards, Andre On Tue, 13 Aug 2024 18:29:31 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 13.08.24 um 15:15 schrieb Andre Vehreschild: > > Hi all, > >

Re: [patch, fortran] First part of Fortran's unsigned implementation

_init_1 (void) near the end of the function. I.e. no space after the comma. That was the background of my question. Thanks for the adaptions. - Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

[Patch, Fortran, 77871, v1] Allow for class typed coarray parameter as dummy [PR77871]

Hi all, attached patch fixes another regression on coarrays. This time for class typed coarrays as dummys. Regtested ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From d16ef6fe8e792063064d930f1b3ffd31c74594e1 Mon

Re: [Fortran, Patch, PR110033, v1] Fix associate for coarrays

. Thanks again, Andre On Wed, 14 Aug 2024 21:21:17 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 12.08.24 um 14:11 schrieb Andre Vehreschild: > > Hi all, > > > > the attached two patches fix ASSOCIATE for coarrays, i.e. that a coarray > > associated to a

Re: [Fortran, Patch, PR110033, v1] Fix associate for coarrays

ges=c,fortran,c++\ --prefix="${INSTALLPATH}" LANG=C make -j ${NOPARALLEL} bootstrap What is wrong with that? Er, Jakub, do you do the patch, as you have assigned yourself? - Andre On Thu, 15 Aug 2024 19:39:54 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 15.08.24 um 17:35

Re: [Fortran, Patch, PR110033, v1] Fix associate for coarrays

Hi Jakub, I will not be faster by far. I have just started and am still in stage 1. So please you go ahead. And thank you very much for the help. - Andre On Thu, 15 Aug 2024 20:50:38 +0200 Jakub Jelinek wrote: > On Thu, Aug 15, 2024 at 08:30:12PM +0200, Andre Vehreschild wrote: > >

Re: [PATCH] Fortran: fix doumentation of intrinsic RANDOM_INIT [PR114146]

ard, while the runtime behavior is apparently fine. > > Checked with make dvi pdf . > > OK for mainline? > > Thanks, > Harald > -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Ping x 3, Patch, Fortran, PR84244, v3] Fix ICE in recompute_tree_invariant_for_addr_expr, at tree.c:4535

Hi all, any one for a review? This patch is over a month old and starts to rot. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? - Andre On Fri, 9 Aug 2024 16:27:42 +0200 Andre Vehreschild wrote: > Ping! > > On Wed, 17 Jul 2024 15:11:33 +0200 > Andre Vehres

[Fortran, Patch, PR46371, v1] Fix coarrays use in select type

the test gives a rough idea on what is tested instead of having just the pr#) to have it covered. Bootstraps and regtests ok on x86_64-pc-linux-gnu. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 205e001e9df7d7b84667a16deee776d2cc8129ca Mon Sep 17 00

Re: [Ping x 3, Patch, Fortran, PR84244, v3] Fix ICE in recompute_tree_invariant_for_addr_expr, at tree.c:4535

Hi Harald, thanks for the review. Committed as: gcc-15-3014-g661acde60ef Regards, Andre On Fri, 16 Aug 2024 19:20:58 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 16.08.24 um 12:05 schrieb Andre Vehreschild: > > Hi all, > > > > any one for a review? This pa

Re: [Fortran, Patch, PR46371, v1] Fix coarrays use in select type

wrote: > Hi Andre, > > Am 16.08.24 um 14:10 schrieb Andre Vehreschild: > > Hi all, > > > > attached patch is a follow up on the pr110033 patch and fixes two ICEs > > reported in pr46371. With the patch also pr56496 is fixed, although that > > could have been

Re: [Ping x 3, Fortran, Patch, coarray, PR84246, v2] Fix for [Coarray] ICE in conv_caf_send, at fortran/trans-intrinsic.c:1950

Hi all, another ping on this patch. Regtests ok on x86_64-pc-linux-gnu on updated master. Ok for mainline? Regards, Andre On Fri, 9 Aug 2024 16:29:08 +0200 Andre Vehreschild wrote: > Ping! > > On Wed, 17 Jul 2024 15:15:51 +0200 > Andre Vehreschild wrote:

Re: [Ping x 3, Fortran, Patch, coarray, PR84246, v2] Fix for [Coarray] ICE in conv_caf_send, at fortran/trans-intrinsic.c:1950

Hi Jerry, thanks for the review. Committed as: gcc-15-3035-g35f56012806 Thanks again, Andre On Mon, 19 Aug 2024 08:46:45 -0700 Jerry D wrote: > On 8/19/24 4:43 AM, Andre Vehreschild wrote: > > Hi all, > > > > another ping on this patch. > > > > Regt

[Fortran, Patch, PR86468, v1] Fix propagation of corank to array components in derived types.

types. These can be associated only to coarray array targets (compare F2018 C1024 and C1026). Therefore for those the corank is still propagated. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From

Re: [Ping x2 , Fortran, Patch, PR77518, (coarray), v4] Fix ICE in sizeof(coarray)

Hi all, pinging this patch. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre On Fri, 9 Aug 2024 16:30:52 +0200 Andre Vehreschild wrote: > Ping! > > @Paul, you already had a look at this patch, but I made some changes. Or they > ok? > &

Re: [Ping x2 , Fortran, Patch, PR77518, (coarray), v4] Fix ICE in sizeof(coarray)

Hi Jerry, thank you for the review. Committed as gcc-15-3062-g515730fd65a Thanks again, Andre On Tue, 20 Aug 2024 09:16:50 -0700 Jerry D wrote: > On 8/20/24 5:35 AM, Andre Vehreschild wrote: > > Hi all, > > > > pinging this patch. > > > > Regtests ok o

Re: [Fortran, Patch, PR86468, v1] Fix propagation of corank to array components in derived types.

Thanks again, Andre On Tue, 20 Aug 2024 22:32:32 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 20.08.24 um 13:52 schrieb Andre Vehreschild: > > Hi all, > > > > attached patch fixes an ICE in gimplify by assuring that the corank of a > > non-pointer,

[Fortran, Patch, PR86468, v1] Follow up: Remove obsolete VIEW_CONVERT

. Regtests ok on x86_64-pc-linux-gnu. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 3a83901e64568967600d5ba643723ae2ad80e0ac Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Wed, 21 Aug 2024 11:22:57 +0200 Subject: [PATCH] [Fortran] Remove unnecessary

Re: [Ping, Patch, Fortran, 77871, v1] Allow for class typed coarray parameter as dummy [PR77871]

Hi all, pinging this patch for the first time. Rebased and regtested ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? - Andre On Thu, 15 Aug 2024 14:39:25 +0200 Andre Vehreschild wrote: > Hi all, > > attached patch fixes another regression on coarrays. This time for cl

Re: [Fortran, Patch, PR86468, v1] Follow up: Remove obsolete VIEW_CONVERT

Hi Steve, thanks for the ok. Committed as gcc-15-3099-g0636de8c520 Thanks again, Andre On Wed, 21 Aug 2024 09:31:55 -0700 Steve Kargl wrote: > On Wed, Aug 21, 2024 at 12:17:46PM +0200, Andre Vehreschild wrote: > > > > attached small patch removes a VIEW_CONVERT tha

Re: [patch][v2a] libgomp: Add interop types and routines to OpenMP's headers and module

omp_interop_property_t property_id, > + omp_interop_rc_t *ret_code) > +{ > + if (property_id < omp_ipr_first || property_id >= 0) > +*ret_code = omp_irc_out_of_range; > + else if (interop == omp_interop_none) > +*ret_code = omp_irc_empty; > + else > +*ret_code = omp_irc_other; > + return 0; Do I get this correct, that omp_intptr_t is a pointer to an integer? Would it not be more intuitive to return nullptr here? > +} -- Andre Vehreschild * Email: vehre ad gmx dot de

[Fortran, Patch, PR85002, v1] Fix deep-copy of alloc. comps. in coarrays ICEing and crashing w/ lib.

deep copy was not inserted in the coarray case, which is fixed by this patch now. Furthermore did I correct a comment, that was describing the inverse of the code following. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre

Re: [patch][v2a] libgomp: Add interop types and routines to OpenMP's headers and module

| return desc[omp_ipr_fr_id - property_id]; |^ - Andre On Fri, 23 Aug 2024 10:28:56 +0200 Andre Vehreschild wrote: > Hi Tobias, > > I just had a short look at your PR. Besides that it did not git-am for me (see > below), I have onl

Re: [Bug fortran/106606] Internal compiler error with abstract derived type using recursive class() components. since r7-4096-gbf9f15ee55f5b291

re On Tue, 17 Sep 2024 07:35:44 + "pault at gcc dot gnu.org" wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106606 > > --- Comment #8 from Paul Thomas --- > (In reply to Andre Vehreschild from comment #7) > > Hi Paul, > > > > I hope you don'

Re: [Ping*3, Patch, Fortran, 77871, v1] Allow for class typed coarray parameter as dummy [PR77871]

Hi all, this patch somehow slipped my attention. Anyone for a review? Third time ping! Rebased to current mainline. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre On Wed, 18 Sep 2024 12:30:23 +0200 Andre Vehreschild wrote: > Hi all, > > bac

Re: [Ping*4, Patch, Fortran, 77871, v1] Allow for class typed coarray parameter as dummy [PR77871]

Ping ^ 4. Really no one to review this 160 something patch? Regtests ok on x86_64-pc-linux-gnu /Fedora 39? Ok for mainline? - Andre On Mon, 7 Oct 2024 12:52:29 +0200 Andre Vehreschild wrote: > Hi all, > > this patch somehow slipped my attention. Anyone for a review? Third

Fortran test typebound_operator_7.f03 broken by non-Fortran commit. Confirm anyone?

ht be doing something wrong here, so please be patient and explain, what I miss. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Fortran, Patch, PR51815, v3] Fix parsing of substring refs in coarrays.

patch or my > shortened version. > > Thanks for the patch! > > Harald > > > > Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Is this ok? > > > > Regards and thanks for the review, > > Andre > > > > On Tue, 1 Oct 2024 23:31:11 +0200 > >

Re: [patch, fortran] Implement maxloc and minloc for unsigned

AMD64 on Linux) > > trunk-bin/x86_64-pc-linux-gnu/libgfortran/generated > > and you then have to copy what's new over to > > trunk/libgfortran/generated , then do a second bootstrap, preferably in > > a separate directory) without --enable-maintainer-mode to see if > > everything works right. > > > > Best regards > > > > Thomas > > > > > > -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch] OpenMP: Allocate directive for static vars, clean up

es here and there, > > see > > commit log and source code for details. > > > > Code comments? Suggestions or remarks? - Before I apply this patch? > > > > Tobias > > > > PS: I am aware that C++ support is lacking. There is a pending patch > > that needs > > to be updated for this patch, probably some bitrotting, and in > > particular for the > > review comments, cf. > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633782.html > > and https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639929.html -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Fortran, Patch, PR81265, v1] Fix passing coarrays always w/ descriptor

Hi Steve, thanks for the review. Committed as: gcc-15-3958-gbac95615b50 Thanks again, Andre On Fri, 27 Sep 2024 10:48:46 -0700 Steve Kargl wrote: > On Fri, Sep 27, 2024 at 03:20:43PM +0200, Andre Vehreschild wrote: > > > > attached patch fixes a runtime issue when a coa

  1   2   3   4   >