[Patch, fortran] PR109345 - [12/13/14/15 Regression] class(*) variable that is a string array is not handled correctly

2024-11-10 Thread Paul Richard Thomas
Hi All, The failing testcase came about because the array reference in the TYPE IS block required the correct value of the span. The fix separates out unlimited polymorphic expressions in gfc_get_array_span and ensures that the value returned is the originating array span, rather than the element

Re: [Patch, fortran] PR109345 - [12/13/14/15 Regression] class(*) variable that is a string array is not handled correctly

2024-11-10 Thread Harald Anlauf
Hi Paul, this looks good to me for mainline as well as backports ... ... except that the PR number should be corrected (109345 instead of 109435) in the testcase and the commit message (Change.logs). Thanks for the patch! Harald Am 10.11.24 um 14:52 schrieb Paul Richard Thomas: Hi All, The

Re: [patch, Fortran] Reject UNSIGNED for COMPLEX

2024-11-10 Thread Harald Anlauf
Hi Thomas, the patch is basically fine. I am wondering if we should create a new helper function that is the opposite of type_check ("type_cannot_be"), so that we avoid redundant code at the source level. It may not be worth it yet, so your choice. Furthermore, if you planned to list intrinsic