Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]

2024-07-29 Thread Andre Vehreschild
Hi Tobias, I am wondering why the testcase has no `!{ dg-do ... }` line. What will dejagnu do then? Sorry for the may be stupid question, but I never encountered a testcase without a dg-do line. It was the minimum for me. Besides that the patch looks ok to me. - Andre On Fri, 26 Jul 2024 20:34

Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]

2024-07-29 Thread Tobias Burnus
Hi Andre, Andre Vehreschild wrote: I am wondering why the testcase has no `!{ dg-do ... }` line. What will dejagnu do then? Sorry for the may be stupid question, but I never encountered a testcase without a dg-do line. It was the minimum for me. Well, then you need look harder ;-) In gcc/test

Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]

2024-07-29 Thread Andre Vehreschild
Thanks a lot Tobias, yes, I could have looked harder :-) This isn't by any chance documented on the developer website of gcc somewhere? It would be sad, if that knowledge is not publicy available for the future. Thanks again for the explanation and keep up the good work. Regards, Andre

Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]

2024-07-29 Thread Tobias Burnus
Hi Andre, hi all, Andre Vehreschild wrote: yes, I could have looked harder 🙂 I wrote ;-) on purpose as this feature is somewhat hidden and writing 'dg-do compile' doesn't harm. In case of gcc/testsuite, the 'run' is also needed and were often missed (or rather caused by invalid variants su

How to add an additional option to dg-compile and dg-run

2024-07-29 Thread Thomas Koenig
Hi, for the fortran-unsigned branch, I would like to be able to run all existing Fortran tests also with -funsigned, to make sure the option does not break anything on existing code. Question is: How? I came as far as $ make check-fortran RUNTESTFLAGS="--target_board=unix/-funsigned" but that

Re: [Patch, v2] OpenMP/Fortran: Fix handling of 'declare target' with 'link' clause [PR11555]

2024-07-29 Thread Jakub Jelinek
On Mon, Jul 29, 2024 at 09:53:47AM +0200, Tobias Burnus wrote: > Hi Andre, hi all, > > Andre Vehreschild wrote: > > yes, I could have looked harder 🙂 > > I wrote ;-) on purpose as this feature is somewhat hidden and writing 'dg-do > compile' doesn't harm. I think an explicit dg-do is better, oth

Re: How to add an additional option to dg-compile and dg-run

2024-07-29 Thread Jonathan Wakely
On Mon, 29 Jul 2024 at 09:20, Thomas Koenig via Gcc wrote: > > Hi, > > for the fortran-unsigned branch, I would like to be able to run all > existing Fortran tests also with -funsigned, to make sure the option > does not break anything on existing code. > > Question is: How? > > I came as far as >

Re: How to add an additional option to dg-compile and dg-run

2024-07-29 Thread Jonathan Wakely
On Mon, 29 Jul 2024 at 10:20, Jonathan Wakely wrote: > > On Mon, 29 Jul 2024 at 09:20, Thomas Koenig via Gcc wrote: > > > > Hi, > > > > for the fortran-unsigned branch, I would like to be able to run all > > existing Fortran tests also with -funsigned, to make sure the option > > does not break a

Re: How to add an additional option to dg-compile and dg-run

2024-07-29 Thread Andrew Pinski
On Mon, Jul 29, 2024 at 1:20 AM Thomas Koenig wrote: > > Hi, > > for the fortran-unsigned branch, I would like to be able to run all > existing Fortran tests also with -funsigned, to make sure the option > does not break anything on existing code. > > Question is: How? > > I came as far as > > $ m

Re: How to add an additional option to dg-compile and dg-run

2024-07-29 Thread Thomas Koenig
Hi Andrew, Any other possibilites? Yes you could add it into the list of Torture options that gfortran-dg-runtest uses. Something like: ``` diff --git a/gcc/testsuite/lib/gfortran-dg.exp b/gcc/testsuite/lib/gfortran-dg.exp index fcba95dc396..0589d507382 100644 --- a/gcc/testsuite/lib/gfortran-d

Re: How to add an additional option to dg-compile and dg-run

2024-07-29 Thread Thomas Schwinge
Hi Thomas! On 2024-07-29T10:18:49+0200, Thomas Koenig via Gcc wrote: > for the fortran-unsigned branch By the way: I did see your recent announcement; wow -- Fortran finally getting an UNSIGNED type! :-) > I would like to be able to run all > existing Fortran tests also with -funsigned, to mak