Re: [PATCH] Fortran: ordering of hidden procedure arguments [PR107441]

2022-10-31 Thread Mikael Morin
Le 30/10/2022 à 22:25, Mikael Morin a écrit : Le 30/10/2022 à 20:23, Mikael Morin a écrit : Another probable issue is your change to create_function_arglist changes arglist/hidden_arglist without also changing typelist/hidden_typelist accordingly.  I think a change to gfc_get_function_type is

[Patch] OpenMP/Fortran: 'target update' with strides + DT components

2022-10-31 Thread Tobias Burnus
I recently saw that gfortran does not support derived type components with 'target update', an OpenMP 5.0 feature. When adding it, I also found out that strides where not handled. There is probably some room of improvement about what to copy and what not, but copying too much should be fine. Bui

Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]

2022-10-31 Thread Harald Anlauf via Fortran
Hi Mikael, thanks a lot, your testcases broke my initial (and incorrect) patch in multiple ways. I understand now that the right solution is much simpler and smaller. I've added your testcases, see attached, with a simple scan of the dump for the generated order of hidden arguments in the funct

Re: adding attributes

2022-10-31 Thread Dave Love via Fortran
Bernhard Reutner-Fischer via Fortran writes: > Well we already have > !GCC$ ATTRIBUTES attribute-list :: var-name [, var-name] ... > > See https://gcc.gnu.org/onlinedocs/gfortran/ATTRIBUTES-directive.html Yes, that's what I was hoping was simple to extend. Sorry I didn't say explicitly. > For