[committed] fortran/dump-parse-tree.c: Use proper enum type (was: Re: [Patch ]Fortran/OpenMP: Extend defaultmap clause for OpenMP 5 [PR92568])

2021-06-23 Thread Tobias Burnus
Indeed, I somehow managed to use the wrong of the two enums in the cast ... Fixed in r12-1760-gcac3527793b38164e2a83c7ccbfe0cfcf5ac95b8 On 23.06.21 16:13, Martin Liška wrote: I noticed the patch causes the following clang warnings: gcc/fortran/dump-parse-tree.c:1786:11: warning: comparison of

Re: [Patch ]Fortran/OpenMP: Extend defaultmap clause for OpenMP 5 [PR92568]

2021-06-23 Thread Martin Liška
Hello. I noticed the patch causes the following clang warnings: gcc/fortran/dump-parse-tree.c:1786:11: warning: comparison of different enumeration types in switch statement ('enum gfc_omp_defaultmap' and 'gfc_omp_defaultmap_category') [-Wenum-compare-switch] gcc/fortran/dump-parse-tree.c:1787

Re: [Patch ]Fortran/OpenMP: Extend defaultmap clause for OpenMP 5 [PR92568]

2021-06-15 Thread Jakub Jelinek via Fortran
On Tue, Jun 15, 2021 at 03:45:15PM +0200, Tobias Burnus wrote: > PR fortran/92568 > > gcc/fortran/ChangeLog: > > * dump-parse-tree.c (show_omp_clauses): Update for defaultmap. > * f95-lang.c (LANG_HOOKS_OMP_ALLOCATABLE_P, > LANG_HOOKS_OMP_SCALAR_TARGET_P): New. > * g

Re: [Patch ]Fortran/OpenMP: Extend defaultmap clause for OpenMP 5 [PR92568]

2021-06-15 Thread Tobias Burnus
On 14.06.21 18:18, Jakub Jelinek wrote: On Wed, Jun 09, 2021 at 02:18:43PM +0200, Tobias Burnus wrote: This patch add's OpenMP 5.1's defaultmap extensions to Fortran. There is one odd thing, [...] The list in 5.1 2.21.7 is ordered, so if defaultmap is present and is not default, it takes prec

Re: [Patch ]Fortran/OpenMP: Extend defaultmap clause for OpenMP 5 [PR92568]

2021-06-14 Thread Jakub Jelinek via Fortran
On Wed, Jun 09, 2021 at 02:18:43PM +0200, Tobias Burnus wrote: > This patch add's OpenMP 5.1's defaultmap extensions to Fortran. > > There is one odd thing, > integer :: ii, it > target :: it > both count as nonallocatable, nonpointer scalars (i.e. category 'scalar'). > But with implicit mapp

[Patch ]Fortran/OpenMP: Extend defaultmap clause for OpenMP 5 [PR92568]

2021-06-09 Thread Tobias Burnus
This patch add's OpenMP 5.1's defaultmap extensions to Fortran. There is one odd thing, integer :: ii, it target :: it both count as nonallocatable, nonpointer scalars (i.e. category 'scalar'). But with implicit mapping (and 'defaultmap(default)'), 'it' is mapped tofrom due to the TARGET att