Re: [Patch, fortran] PR119460 - gfortran.dg/reduce_1.f90 FAILs

2025-04-06 Thread Andre Vehreschild
Hi Paul, > > --- a/libgfortran/intrinsics/reduce.c > > +++ b/libgfortran/intrinsics/reduce.c > > @@ -83,8 +83,8 @@ reduce (parray *ret, > >if (dim_present) > > { > >if ((*dim < 1) || (*dim > (GFC_INTEGER_4)array_rank)) > > - runtime_error ("DIM in REDUCE intrinsic is less th

Re: [Patch, fortran] PR119460 - gfortran.dg/reduce_1.f90 FAILs

2025-04-06 Thread Paul Richard Thomas
Hi Andre, On Mon, 7 Apr 2025 at 07:29, Andre Vehreschild wrote: > Hi Paul, > > shouldn't this be done in iresolve.cc to make other parts of gfortran > benefit > from learning, that the sym is allocatable? > > I'll give it a try. I was attempting to eliminate any wider side effects by setting the

Re: GSoC[Fortran Runtime argument check ] Draft of Proposal and some doubts about the needs

2025-04-06 Thread Gwen Fu
Thanks for your reply ! >The word "parameter" has very a specific meaning in Fortran. The >entity that is passed into a function or subroutine is an "actual >argument". The entity within the functions associated with the >"actual argument" is a "dummy argument". Can I understand "dummy parameters"

Re: [Patch, fortran] PR119460 - gfortran.dg/reduce_1.f90 FAILs

2025-04-06 Thread Andre Vehreschild
Hi Paul, shouldn't this be done in iresolve.cc to make other parts of gfortran benefit from learning, that the sym is allocatable? --- a/gcc/fortran/trans-intrinsic.cc +++ b/gcc/fortran/trans-intrinsic.cc @@ -3883,6 +3883,13 @@ gfc_conv_intrinsic_funcall (gfc_se * se, gfc_expr * expr) append_args

Re: GSoC[Fortran Runtime argument check ] Draft of Proposal and some doubts about the needs

2025-04-06 Thread Steve Kargl
On Sat, Apr 05, 2025 at 03:16:45PM +0800, Gwen Fu wrote: > My doubt : > 1.Does the compilation option only need to support fortran versions above > 9, o5r does it also need to support fortran 77? gfortran started life as a Fortran 95 compiler. It should support anything that is Fortran 95 or late

Re: [Patch, fortran] PR119460 - gfortran.dg/reduce_1.f90 FAILs

2025-04-06 Thread H.J. Lu
On Sun, Apr 6, 2025 at 5:39 AM Paul Richard Thomas wrote: > > Hi All, > > As far as I can tell, the attached patch fixes the problems with the reduce > intrinsic. I would be grateful to the reporters if they would confirm that > this is the case. > > The key to the fix appears in reduce_3.f90, w

[Patch, fortran] PR119460 - gfortran.dg/reduce_1.f90 FAILs

2025-04-06 Thread Paul Richard Thomas
Hi All, As far as I can tell, the attached patch fixes the problems with the reduce intrinsic. I would be grateful to the reporters if they would confirm that this is the case. The key to the fix appears in reduce_3.f90, which failed even with -m64. Although it was not apparent from the tree dump