Re: Failure on 14 branch

2025-01-09 Thread Jerry D
On 1/9/25 1:29 PM, Thomas Koenig wrote: Hi Jerry, Is anyone else seeing this? Running /home/jerry/dev/gcc14/gcc/testsuite/gfortran.dg/dg.exp ... FAIL: gfortran.dg/bind-c-contiguous-1.f90   -O3 -fomit-frame-pointer - funroll-loops -fpeel-loops -ftracer -finline-functions  (internal compiler er

Re: Failure on 14 branch

2025-01-09 Thread Thomas Koenig
Hi Jerry, Is anyone else seeing this? Running /home/jerry/dev/gcc14/gcc/testsuite/gfortran.dg/dg.exp ... FAIL: gfortran.dg/bind-c-contiguous-1.f90   -O3 -fomit-frame-pointer - funroll-loops -fpeel-loops -ftracer -finline-functions  (internal compiler error: Segmentation fault) FAIL: gfortran.d

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Mikael Morin
Le 09/01/2025 à 18:12, Andre Vehreschild a écrit : Hi Jakub, Yes, that is what I had in mind. Being German I don't see any problem with the explanation, but that is better judged by a native English speaker. Is the send patch hunk intentional where only indentation is changed? I haven't applied

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 06:12:51PM +0100, Andre Vehreschild wrote: > Yes, that is what I had in mind. Being German I don't see any problem with the > explanation, but that is better judged by a native English speaker. > > Is the send patch hunk intentional where only indentation is changed? I > h

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Andre Vehreschild
Hi Jakub, Yes, that is what I had in mind. Being German I don't see any problem with the explanation, but that is better judged by a native English speaker. Is the send patch hunk intentional where only indentation is changed? I haven't applied it though. Thanks for the patch, Andre On

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 03:28:28PM +0100, Jakub Jelinek wrote: > So like this? Thomas mentioned bad wording in a private mail. Here is a better patch: 2025-01-09 Jakub Jelinek PR fortran/118337 * module.cc (use_iso_fortran_env_module): Add a comment explaining the opt

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 11:32:35AM +0100, Andre Vehreschild wrote: > I am sorry, I don't get it. So we are trying to help the compiler, i.e. the > C++ > one, to create a fast gfortran binary. But we don't care about devs that > stumble > about the code and ask themselves, "Why is this done (witho

Re: [patch, Fortran] -fc-prototypes fixes.

2025-01-09 Thread Thomas Koenig
Am 09.01.25 um 14:45 schrieb Andre Vehreschild: You forgot to add the patch! Sent two minutes later :-) https://gcc.gnu.org/pipermail/fortran/2025-January/061540.html

Re: [patch, Fortran] -fc-prototypes fixes.

2025-01-09 Thread Andre Vehreschild
You forgot to add the patch! On Thu, 9 Jan 2025 14:34:50 +0100 Thomas Koenig wrote: > Hello world, > > This patch fixes and reorganizes dumping C prototypes. It makes the > following changes: > > - BIND(C) types are now always output before any global symbols > - CFI_cdesc_t is issu

Re: [patch, Fortran] -fc-prototypes fixes.

2025-01-09 Thread Thomas Koenig
Am 09.01.25 um 14:34 schrieb Thomas Koenig: This patch fixes and reorganizes dumping C prototypes. And here is the "five seconds later, I realized I had forgotten to attach the patch" e-mail... diff --git a/gcc/fortran/dump-parse-tree.cc b/gcc/fortran/dump-parse-tree.cc index 8d31ddfcffb..826f

[patch, Fortran] -fc-prototypes fixes.

2025-01-09 Thread Thomas Koenig
Hello world, This patch fixes and reorganizes dumping C prototypes. It makes the following changes: - BIND(C) types are now always output before any global symbols - CFI_cdesc_t is issued for assumed shape and assumed rank arguments. - BIND(C,NAME="...") entities were no

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Andre Vehreschild
Hi Mikael, merged only patch #2 as gcc-15-6729-gd1071402055. Thanks for the ok and regards, Andre On Wed, 8 Jan 2025 22:46:15 +0100 Mikael Morin wrote: > Le 08/01/2025 à 18:23, Andre Vehreschild a écrit : > > > > First of all the recursive attr must not be set on vtypes, neither on m

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Andre Vehreschild
Hi all, I am sorry, I don't get it. So we are trying to help the compiler, i.e. the C++ one, to create a fast gfortran binary. But we don't care about devs that stumble about the code and ask themselves, "Why is this done (without a comment) so oddly?"! Furthermore is the code again using conventi