Re: [patch, libgfortran] PR117820

2024-12-03 Thread Harald Anlauf
Hi Jerry, regarding the testcase, these variants are both standard-conforming and silent under -pedantic: x = ibset (0_8, 63) x = ibset (0_8, bit_size(x)-1) No trickery needed. Cheers, Harald Am 03.12.24 um 05:13 schrieb Jerry D: Hi all, Attached patch adds a test for zero that is neede

Re: [Patch, fortran] PR102689 revisited - Segfault with RESHAPE of CLASS as actual argument

2024-12-03 Thread Paul Richard Thomas
Hi Harald, > > Reviewing it properly is beyond me, but if nobody else volunteers, > I am not so sure that is right but your review is mightily helpful. I worry that the logic in the handling of the gfc_ss's is not clear enough. Some time, when feeling bored, I might try to refactor it. > I'll j

Re: [Patch] OpenMP: 'allocate' directive - fixes for 'alignof' and [[omp::decl]]

2024-12-03 Thread Andre Vehreschild
Hi Tobias, ok for the Fortran part. - Andre On Tue, 3 Dec 2024 10:34:34 +0100 Tobias Burnus wrote: > In C, [[omp::decl]] wasn't supported and when discussing 'alignof' with Jakub, > he pointed out that there are corner cases (see commit log for one), which > imply that it is better that 'omp a

Re: [Patch] OpenMP: 'allocate' directive - fixes for 'alignof' and [[omp::decl]]

2024-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2024 at 10:34:34AM +0100, Tobias Burnus wrote: > --- a/gcc/testsuite/c-c++-common/gomp/allocate-18.c > +++ b/gcc/testsuite/c-c++-common/gomp/allocate-18.c > @@ -17,14 +17,14 @@ typedef enum omp_allocator_handle_t > > void test0 () > { > - int A1[5]; > + int A1[5], B1[1]; I'd

[Patch] OpenMP: 'allocate' directive - fixes for 'alignof' and [[omp::decl]]

2024-12-03 Thread Tobias Burnus
In C, [[omp::decl]] wasn't supported and when discussing 'alignof' with Jakub, he pointed out that there are corner cases (see commit log for one), which imply that it is better that 'omp allocate align(…) doesn't affect 'alignof'. The patch now removes the alignment handling from the FE (C and Fo