[PATCH v2] gfortran testsuite: Remove unit-files in files having open-statements, PR116701

2024-09-24 Thread Hans-Peter Nilsson
Changes since v1: - Rename gfortran-dg-rmunits to fortran-delete-unit-files. - Move it to lib/fortran-modules.exp. - Tweak commit message accordingly and mention cause of placement of the proc. - Tweak proc comment to mention why keeping removals unique despite comment. Here's a general approa

Re: [PATCH] gfortran testsuite: Remove unit-files in files having open-statements, PR116701

2024-09-24 Thread Hans-Peter Nilsson
Thanks for the review! > Date: Tue, 24 Sep 2024 17:10:27 -0700 > Cc: Jerry D > From: Jerry D > On 9/23/24 11:21 PM, Hans-Peter Nilsson wrote: > > I hope the inclusion of gfortran-dg.exp in > > fortran-torture.exp is not controversial, but there's no > > fortran-specific testsuite file common to

Re: [PATCH] gfortran testsuite: Remove unit-files in files having open-statements, PR116701

2024-09-24 Thread Jerry D
On 9/23/24 11:21 PM, Hans-Peter Nilsson wrote: Here's a general approach to handle PR116701. I considered adding manual deletions as quoted below and mentioned in the PR, but seeing the handling of "integer 8" in fortran-torture-execute I decided to follow that example: better scan the source fo

[Patch] OpenMP: Update OMP_REQUIRES_TARGET_USED for declare_target + interop

2024-09-24 Thread Tobias Burnus
OpenMP mandates that when certain clauses are used with 'omp requires' that in all compilation units this requires clause appears. Those clauses influence the offloading behavior (+ potentially codegen); hence, the must requires must match for those claues when device code is involved. That's

Re: [Fortran, Patch, PR101100, v1] Fix ICE when compiling with caf-lib and using proc_pointer component.

2024-09-24 Thread Andre Vehreschild
Hi Harald, thanks for the review. Committed as gcc-15-3827-g0c0d79c783f Thanks again, Andre On Mon, 23 Sep 2024 21:25:55 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 19.09.24 um 14:19 schrieb Andre Vehreschild: > > Hi all, > > > > the attached patch fixes an ICE when compiling with -f

Re: [Fortran, Patch, PR84870, v1] Fix ICE and allocated memory not assigned correctly.

2024-09-24 Thread Andre Vehreschild
Hi Harald, thanks for the review. Committed as gcc-15-3825-gf5035d7d015 Thanks again, Andre On Mon, 23 Sep 2024 21:19:40 +0200 Harald Anlauf wrote: > Hi Andre, > > Am 19.09.24 um 16:01 schrieb Andre Vehreschild: > > Hi all, > > > > in PR84870 an ICE was reported, that has been fixed in

Re: [patch, fortran] Matmul and dot_product for unsigned

2024-09-24 Thread Andre Vehreschild
Hi Thomas, thanks for your answers. I am ok with the patch. - Andre On Mon, 23 Sep 2024 15:07:31 +0200 Thomas Koenig wrote: > Hello Andre and everybody else? > > Any more comments on the matmul patch? The other ones depend on > it, so I would like to commit (unless there are further > question

Re: [Patch] OpenMP: Add support for 'self_maps' to the 'require' directive

2024-09-24 Thread Tobias Burnus
Hi all, now committed as r15-3822-gb752eed3e3f2f2, see attachment. I fixed on C/C++ test issue (missing 's') and added the Fortran module check. Tobias PS: I noticed that 'declare target' does not add the target-used flag. At least TR13 is very clear that it counts, but currently GCC does n

Re: [Patch, fortran] PR116733: Generic processing of assumed rank objects (f202y)

2024-09-24 Thread Andre Vehreschild
Hi Paul, in addition to Thomas' remarks (which I second to), I have the following: > diff --git a/gcc/fortran/intrinsic.cc b/gcc/fortran/intrinsic.cc > index 0a6be215825..d95f35145b5 100644 > --- a/gcc/fortran/intrinsic.cc > +++ b/gcc/fortran/intrinsic.cc > @@ -293,11 +293,15 @@ do_ts29113_check