Re: [PATCH 00/14] fortran: Use precalculated class container for deallocation [PR110618]

2023-07-14 Thread Paul Richard Thomas via Fortran
Hi Mikael, I apologise for not being a bit faster with the review. I appreciate that you put a lot of effort into presenting the work in digestible chunks. Perhaps this is a personal perspective but I found it more difficult to absorb than reviewing a single patch. What do others think? That said

[PATCH] [og13] OpenMP: Enable c-c++-common/gomp/declare-mapper-3.c for C

2023-07-14 Thread Julian Brown
This patch enables the c-c++-common/gomp/declare-mapper-3.c test for C. This was seemingly overlooked in commit 393fd99c90e. Tested with offloading to AMD GCN. I will apply (to og13) shortly. 2023-07-14 Julian Brown gcc/testsuite/ * c-c++-common/gomp/declare-mapper-3.c: Enable for C.

[PATCH] [og13] OpenMP: Dimension ordering for array-shaping operator for C and C++

2023-07-14 Thread Julian Brown
This patch fixes a bug in non-contiguous 'target update' operations using the new array-shaping operator for C and C++, processing the dimensions of the array the wrong way round during the OpenMP lowering pass. Fortran was also incorrectly using the wrong ordering but the second reversal in omp-lo

Re: [PATCH 14/14] fortran: Pass pre-calculated class container argument [pr110618]

2023-07-14 Thread Mikael Morin
Hello, Le 14/07/2023 à 07:55, Paul Richard Thomas via Fortran a écrit : Hi Mikhail, This patch uses a field for gfc_se called class container, which is neither declared nor set as far as I can tell. These patches are dependent on my previous patchset for pr92178. Sorry, I didn't highlight tha