Re: referencing JIRA issues in code

2012-03-01 Thread Carol Frampton
y >>> attachments and discussion thread from the JIRA issue. >>> >>> Rui >>> >>> Original Message >>> > From: "Carol Frampton" >>> > Sent: segunda-feira, 27 de Fevereiro de 2012 15:16 >>> >

Re: referencing JIRA issues in code

2012-02-29 Thread Rafael Santos
Rui >> >> Original Message >> > From: "Carol Frampton" >> > Sent: segunda-feira, 27 de Fevereiro de 2012 15:16 >> > To: "flex-dev@incubator.apache.org" >> > Subject: Re: referencing JIRA issues in code >>

Re: referencing JIRA issues in code

2012-02-29 Thread Rafael Santos
Original Message > > From: "Carol Frampton" > > Sent: segunda-feira, 27 de Fevereiro de 2012 15:16 > > To: "flex-dev@incubator.apache.org" > > Subject: Re: referencing JIRA issues in code > > > > I really dislike bug numbers in th

Re: referencing JIRA issues in code

2012-02-29 Thread Rui Silva
nda-feira, 27 de Fevereiro de 2012 15:16 > To: "flex-dev@incubator.apache.org" > Subject: Re: referencing JIRA issues in code > > I really dislike bug numbers in the code. As other said the svn history > is there. The only time where it might be ok is if it is a very com

Re: referencing JIRA issues in code

2012-02-27 Thread John Fletcher
I agree on no bug numbers. Except I think it's valid in a temporary comment where you have a hack because you are awaiting a fix in another issue. Like "We have to check for null here due to a bug in Label - see FLEX-99" John

Re: referencing JIRA issues in code

2012-02-27 Thread Carol Frampton
in a summary comment with the bug number, in this format: [FLEX-99]. Carol On 2/27/12 3 :03AM, "Alex Harui" wrote: > > > >On 2/26/12 2:32 PM, "Justin Mclean" wrote: > >> Hi, >> >> Just wondering what the policy should be on referencing JIRA i

RE: referencing JIRA issues in code

2012-02-27 Thread David Arno
> From: Yennick Trevels [mailto:yennick.trev...@gmail.com] >Sent: 27 February 2012 07:24 > Imo we shouldn't include those comments in the code, it's already in the > SVN history and if we write a unit test when we fix something then it's covered > there also which should avoid regression bugs. I

Re: referencing JIRA issues in code

2012-02-27 Thread Haykel BEN JEMIA
I would not clutter the code with this information. It should be enough to have it in SVN and Jira. Haykel

Re: referencing JIRA issues in code

2012-02-27 Thread Alex Harui
On 2/26/12 2:32 PM, "Justin Mclean" wrote: > Hi, > > Just wondering what the policy should be on referencing JIRA issues in code > comments > > Do we: > 1. Don't need to do it as it's contained in the SVN history > Adobe policy was not to put b

Re: referencing JIRA issues in code

2012-02-26 Thread Yennick Trevels
Imo we shouldn't include those comments in the code, it's already in the SVN history and if we write a unit test when we fix something then it's covered there also which should avoid regression bugs. It would just clutter the code.

Re: referencing JIRA issues in code

2012-02-26 Thread Pierangelo Mancusi
5. //issue: FLEX-123 //some fix code Il giorno 26 febbraio 2012 23:41, Jun Heider ha scritto: > > On Feb 26, 2012, at 3:32 PM, Justin Mclean wrote: > > > > 2. Mention issue by name > > // some random fix (FLEX-123) > > Based on previous discussion and also personal pref, I thin

Re: referencing JIRA issues in code

2012-02-26 Thread Jun Heider
On Feb 26, 2012, at 3:32 PM, Justin Mclean wrote: > > 2. Mention issue by name > // some random fix (FLEX-123) Based on previous discussion and also personal pref, I think the above should be the way to go.

referencing JIRA issues in code

2012-02-26 Thread Justin Mclean
Hi, Just wondering what the policy should be on referencing JIRA issues in code comments Do we: 1. Don't need to do it as it's contained in the SVN history 2. Mention issue by name // some random fix (FLEX-123) 3. Have a URL to the issue // some random fix (https://issues.apach