Hi,
> I will put it where I think it should go for now. I am not planning on
> modifying the manifests, so someone else can make that decision.
I'll stick into the build_framework script for you once you've checked it into
patches.
Thanks,
Justin
Hi,
> I am still curious how this works with the framework as it is now, but
> working on correcting these.
It generally has well formed XML and escapes characters like ",", "&",">" etc.
Currently only public and protected constants, properties and methods comments
are looked at, I've run over
>Probably best to submit to the patches branch (for now) until we have an
>initial release.
Okay, in it.
>These is also the question of what namespace it should go in.
I will put it where I think it should go for now. I am not planning on
modifying the manifests, so someone else can make that d
On 4/11/12 7:26 AM, "Michael A. Labriola"
wrote:
>
> Now that this issue is fixed, any problems with me committing this and the
> VectorList and Collection to trunk.
Trunk is "closed" until we cut a "parity" release. I think Justin has a
branch you can use for now.
--
Alex Harui
Flex SDK T
>ASDocs currently fails to compile on the code (basically comments must be
>valid XML so "<" and ">" should be escaped) - not a huge issue IMO. I was
>going to provide a patch but not had the time.
Interesting as I think 99% of those comments are just copies from ArrayList
Hi,
> Now that this issue is fixed, any problems with me committing this and the
> VectorList and Collection to trunk.
Probably best to submit to the patches branch (for now) until we have an
initial release.
These is also the question of what namespace it should go in. You might might
to look
>I would think the fix would be to find a way to get the right index.
Now that this issue is fixed, any problems with me committing this and the
VectorList and Collection to trunk. We still need to determine how we want to
add serialization for Vector(if we do) for right now I have removed the
>It looks like the index is converted to a string. Using -1 instead of 0 seems
>just as bad. I would think the fix would be to find a way to get the right
>index.
Okay, ArrayList and VectorList along with the unit tests for each are now
pushed back up to my whiteboard. Please review. Factored
>It looks like the index is converted to a string. Using -1 instead of 0 seems
>just as bad. I would think the fix would be to find a way to get the right
>index.
Alex,
It's not -1 instead of 0, its -1 instead of 4294967295. Since that seems like a
valid index there is other code which can
On 4/10/12 9:11 AM, "Michael A. Labriola"
wrote:
>> I do now. Is there an exiting Flex bug for it?
>
> Can't find the original bug I wanted, however, on a side note, this one
> applies to one of the inconsistencies that I think needs to be fixed:
>
> https://bugs.adobe.com/jira/browse/SDK-3
>That is exactly my point. We can "fix" a whole slew of big, bad, annoying
>things. but we will end up creating an SDK version that will totally shatter
>many existing applications which most likely will have implemented >careful
>workarounds and quirk-specific code for quirks that we will be
v@incubator.apache.org
> Subject: RE: ArrayList itemUpdateHandler Change
> Date: Tue, 10 Apr 2012 16:18:43 +
>
> >I agree with this, there are a number of inconsistencies in the handling of
> >indexes throughout the framework. I think that it is a worthwhile effort to
> &g
>I agree with this, there are a number of inconsistencies in the handling of
>indexes throughout the framework. I think that it is a worthwhile effort to
>address them in this way. As Mike states, the number of side >effects could
>be numerous. But with that being said, I think that changing
>I do now. Is there an exiting Flex bug for it?
Can't find the original bug I wanted, however, on a side note, this one applies
to one of the inconsistencies that I think needs to be fixed:
https://bugs.adobe.com/jira/browse/SDK-31861
Want me to create a jira issue somewhere for this one?
Mik
subsequent changes flying around.
I think we will definitely resolve some long pending issues, but we should be
very careful and aware that this could be a rather deep rabbit hole.
> From: labri...@digitalprimates.net
> To: flex-dev@incubator.apache.org
> Subject: RE: ArrayList itemUpda
>I do now. Is there an exiting Flex bug for it?
There was a bug about the AdvancedDataGrid and this was the root cause. It's
been a couple of years but I can try to find it again.
Mike
>Frankly, all of the propertyChange stuff and collectionChange stuff is a mess
>and inconsistent. I want to fix it all, but I am trying to make the narrowest
>number of changes until we have tests. The other method:
Adding to this for a moment. One of the issues here is that when a child object
On 4/10/12 8:38 AM, "Michael A. Labriola"
wrote:
> However, regardless of all of this, we are still calling a method which states
> that -1 is a valid return value, but casting it to an uinsigned integer. That
> is a problem in and of itself.
>
> See the issue?
I do now. Is there an exiting
>This did not make sense to me. ItemUpdated is called on objects that should
>already exist in a dataprovider, no? Can I get more details on the scenario?
When you call itemUpdated, you pass it an object:
public function itemUpdated(item:Object, property:Object = null,
On 4/10/12 7:16 AM, "Michael A. Labriola"
wrote:
> This is already in my whiteboard put I want to push it to trunk.
Trunk still isn't "open" until we get a parity release.
>
> In ArrayList's itemUpdatedHandler, it checks the event.target and attempts to
> get the index. However, in many case
On Tue, Apr 10, 2012 at 9:16 AM, Michael A. Labriola <
labri...@digitalprimates.net> wrote:
> var objEvent:PropertyChangeEvent = PropertyChangeEvent(event.clone());
> //When itemUpdated is called, there is no event target.
> This means getItemIndex returns a -1
>
On 10 Apr 2012, at 15:16, Michael A. Labriola wrote:
This is already in my whiteboard put I want to push it to trunk.
In ArrayList's itemUpdatedHandler, it checks the event.target and
attempts to get the index. However, in many cases (such as when you
call itemUpdated()) this target is not
This is already in my whiteboard put I want to push it to trunk.
In ArrayList's itemUpdatedHandler, it checks the event.target and attempts to
get the index. However, in many cases (such as when you call itemUpdated())
this target is not defined. getItemIndex() returns a -1 in that case, but her
23 matches
Mail list logo
