[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-26 Thread Martin Heidegger (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216680#comment-13216680 ] Martin Heidegger commented on FLEX-19: -- I know its an FDT bug: That occasionally happens

Re: [jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-26 Thread Justin Mclean
Hi, So isn't that a FDT bug? :-) Do you know if there's any performance implications to that change being in binding utils it might have an effect. (I'm unaware of anything but we do need to take care with changes like that). Thanks, Justin

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Martin Heidegger (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216664#comment-13216664 ] Martin Heidegger commented on FLEX-19: -- FDT has a bug: it breaks if you write @dynamic l

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Justin Mclean (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216555#comment-13216555 ] Justin Mclean commented on FLEX-19: --- As typeDescription is XML what's the reason for this c

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Martin Heidegger (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216502#comment-13216502 ] Martin Heidegger commented on FLEX-19: -- I was gunning for non-destructive improvements t

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Alex Harui (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216500#comment-13216500 ] Alex Harui commented on FLEX-19: Regarding empty spaces: I'm actually surprised that was the

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Alex Harui (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216499#comment-13216499 ] Alex Harui commented on FLEX-19: Regarding D: That's a pretty strict definition of backward c

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Martin Heidegger (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216376#comment-13216376 ] Martin Heidegger commented on FLEX-19: -- There were empty spaces after the ";".

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Alex Harui (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216375#comment-13216375 ] Alex Harui commented on FLEX-19: Why is AsyncListView in the semicolon patch? I don't see a

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Martin Heidegger (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216374#comment-13216374 ] Martin Heidegger commented on FLEX-19: -- I am not sure how to answer: If someone in the f

[jira] [Commented] (FLEX-19) Code style improvements in framework

2012-02-25 Thread Alex Harui (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216367#comment-13216367 ] Alex Harui commented on FLEX-19: I took a quick look at D (unused locals). Most of it looks