[flashrom] [PATCH] Add delays to dediprog driver

2012-06-13 Thread Nico Huber
Some investigations have shown, that the original dediprog driver waits about 200ms after setting voltage up and before setting voltage down. This patch adds those delays. It helps flash chips to come up in time. Signed-off-by: Nico Huber Index: dediprog.c

[flashrom] [PATCH] Let the programmer driver decide how to do AAI transfers

2012-06-13 Thread Nico Huber
lises this abstraction in the dediprog driver will follow. Signed-off-by: Nico Huber Index: it87spi.c === --- it87spi.c (Revision 1541) +++ it87spi.c (Arbeitskopie) @@ -120,6 +120,7 @@ .multicommand = default_spi_send_mu

[flashrom] [PATCH] Enable spi clock setting in dediprog driver

2012-06-13 Thread Nico Huber
This adds a programmer parameter 'speed' in the dediprog driver to controll the transfer rate on the spi bus. The following rates are available (all in kHz): 24000, 12000, 8000, 3000, 2180, 1500, 750, 375 Signed-off-by: Nico Huber Index:

[flashrom] [PATCH] Add native AAI transfer support to the dediprog driver

2012-06-13 Thread Nico Huber
size of the chunks sent over usb earlier. This patch requires "[PATCH] Let the programmer driver decide how to do AAI transfers". Signed-off-by: Nico Huber diff -urp -x.svn flashrom-spi_write_aai/dediprog.c flashrom-dediprog-own-spi_write_aai/dediprog.c --- flashrom-spi_write_aai/

Re: [flashrom] [PATCH] Let the programmer driver decide how to do AAI transfers

2012-06-15 Thread Nico Huber
(renamed spi_aai_write) for all programmers for now. A patch which utilises this abstraction in the dediprog driver will follow. Signed-off-by: Nico Huber Index: dediprog.c === --- dediprog.c (Revision 1541) +++ d

Re: [flashrom] [PATCH] Add native AAI transfer support to the dediprog driver

2012-06-15 Thread Nico Huber
unsigned int start, unsigned int len) >> +static int dediprog_write_256(struct flashctx *flash, uint8_t *buf, > > Not sure if dediprog_wite_256() still is an appropriate name for the > function. I'm not sure if it was an appropriate name before and I don'

Re: [flashrom] [PATCH] Add native AAI transfer support to the dediprog driver

2012-06-18 Thread Nico Huber
second word was mistaken for the size of the chunks sent over usb earlier. The third byte (first of the second word) is now set to zero. This also adds some checks for the size of data chunks sent over usb. Signed-off-by: Nico Huber Index: dediprog.c

Re: [flashrom] [PATCH] Enable spi clock setting in dediprog driver

2012-06-18 Thread Nico Huber
Hello Carl-Daniel, thank you for your review. Am 13.06.2012 23:22, schrieb Carl-Daniel Hailfinger: > Hi Nico, > > thanks for your patch. Review follows. > > > Am 13.06.2012 11:01 schrieb Nico Huber: >> This adds a programmer parameter 'speed' in the dediprog

Re: [flashrom] [PATCH] Add native AAI transfer support to the dediprog driver

2012-06-19 Thread Nico Huber
over usb earlier. The third byte (first of the second word) is now set to zero. This also adds some checks for the size of data chunks sent over usb. Signed-off-by: Nico Huber Index: dediprog.c === --- dediprog.c (Revision 1545) +++ de

Re: [flashrom] [PATCH] Enable spi clock setting in dediprog driver

2012-09-12 Thread Nico Huber
speed, so the initialization calls have moved into a new function dediprog_setup() which is called twice. Signed-off-by: Nico Huber Index: dediprog.c === --- dediprog.c (Revision 1596) +++ dediprog.c (Arbeitskopie) @@ -152

Re: [flashrom] [PATCH] Enable spi clock setting in dediprog driver

2012-11-16 Thread Nico Huber
alizes the programmer after setting the speed, so the initialization calls have moved into a new function dediprog_setup() which is called twice. Signed-off-by: Nico Huber diff --git a/dediprog.c b/dediprog.c index a81cf83..60067a8 100644 --- a/dediprog.c +++ b/dediprog.c @@ -152,7 +152,23 @@

[flashrom] [PATCH] Bump dediprog driver to use libusb-1.0

2012-11-16 Thread Nico Huber
This patch tracks the changes in the libusb interface. Nothing changed in the behaviour of the driver, so far. It will be used by a follow-up patch. It's based on "Enable spi clock setting in dediprog driver". Signed-off-by: Nico Huber diff --git a/Makefile b/Makefile index b

[flashrom] [PATCH] dediprog: Use asynchronous bulk transfers for reading

2012-11-16 Thread Nico Huber
It's based on "Bump dediprog driver to use libusb-1.0". Signed-off-by: Nico Huber diff --git a/dediprog.c b/dediprog.c index a558285..f1c03d8 100644 --- a/dediprog.c +++ b/dediprog.c @@ -29,6 +29,7 @@ #define FIRMWARE_VERSION(x,y,z) ((x << 16) | (y << 8) | z) #defi

[flashrom] [PATCH 0/6] Add libflashrom interface

2012-12-10 Thread Nico Huber
at we encountered when a client wants to restart things after calling programmer_shutdown(). Nico Huber (6): Make some char pointers const Add a convenient libflashrom interface Add Doxyfile for libflashrom documentation Adapt CLI to use new libflashrom interface' prin

[flashrom] [PATCH 1/6] Make some char pointers const

2012-12-10 Thread Nico Huber
This makes some char pointers const to get a more convenient libflashrom interface. Signed-off-by: Nico Huber --- flash.h |4 ++-- flashrom.c |8 programmer.h |2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/flash.h b/flash.h index 526087c

[flashrom] [PATCH 4/6] Adapt CLI to use new libflashrom interface' print callback

2012-12-10 Thread Nico Huber
This renames CLI's print() to fl_print_cb() and registers it through the new libflashrom interface. Signed-off-by: Nico Huber --- cli_classic.c |3 +++ cli_output.c |7 +-- flash.h |2 ++ 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cli_classi

[flashrom] [PATCH 5/6] On shutdown, reset count of registered programmers

2012-12-10 Thread Nico Huber
To get things working correctly again after programmer_shutdown(), registered_programmer_count has to be reset. Herewith, we can start another run with programmer_init(). Signed-off-by: Nico Huber --- flashrom.c |4 1 file changed, 4 insertions(+) diff --git a/flashrom.c b/flashrom.c

[flashrom] [PATCH 2/6] Add a convenient libflashrom interface

2012-12-10 Thread Nico Huber
, without breaking clients. A new make target, libinstall, is also added. It installs libflashrom.a and libflashrom.h in lib/ and include/ dirs respectively. This commit breaks build of the cli. It will be fixed with a follow-up commit. Signed-off-by: Nico Huber --- Makefile |8

[flashrom] [PATCH 6/6] Cleanup ichspi opcode settings on shutdown

2012-12-10 Thread Nico Huber
curopcodes in ichspi.c reflects the state of the related chipset registers. Those are reset on shutdown but curopcodes is left initialized. This prevented further runs with the same libflashrom instance. Signed-off-by: Nico Huber --- ichspi.c | 14 ++ 1 file changed, 14 insertions

Re: [flashrom] [PATCH] Enable spi clock setting in dediprog driver

2013-02-20 Thread Nico Huber
Hello Carl-Daniel, Am 19.02.2013 22:56, schrieb Carl-Daniel Hailfinger: > Hi Nico, > > I'm very sorry about the long review delay. Anyway, thanks for your review. > Am 16.11.2012 11:23 schrieb Nico Huber: >> This adds a programmer parameter 'spispeed' to the

Re: [flashrom] [PATCH] Bump dediprog driver to use libusb-1.0

2013-02-22 Thread Nico Huber
Hello Carl-Daniel, >> I have fixed and forward ported the code, please check that it works and >> looks sane. Thanks for your time. Current (your second) iteration works flawlessly here. > libusb header file location is still something I have to fix in another > iteration. I guess `#include ` woul

[flashrom] [PATCH] dediprog: Use asynchronous bulk transfers for reading

2013-02-22 Thread Nico Huber
igned-off-by: Nico Huber --- dediprog.c | 92 ++-- 1 file changed, 83 insertions(+), 9 deletions(-) diff --git a/dediprog.c b/dediprog.c index 93c4072..3cd7b01 100644 --- a/dediprog.c +++ b/dediprog.c @@ -31,6 +31,7 @@ #define FIRMWARE_VE

Re: [flashrom] [PATCH] Bump dediprog driver to use libusb-1.0

2013-03-27 Thread Nico Huber
Am 27.03.2013 11:51, schrieb Stefan Tauner: > On Fri, 22 Feb 2013 11:56:03 +0100 > Nico Huber wrote: > >> I'm not quite sure if I changed anything since my post, so I'll rebase, >> test, and repost my pending changes. > > Were there any pending changes

Re: [flashrom] [PATCH] dediprog: fix SPI clock setting.

2013-05-07 Thread Nico Huber
shrom.8 > index c7a6c69..4e6ab55 100644 > --- a/flashrom.8 > +++ b/flashrom.8 > @@ -683,7 +683,8 @@ Usage example to select the second device: > .sp > An optional > .B spispeed > -parameter specifies the frequency of the SPI bus. Syntax is > +parameter specifies the freq

[flashrom] [PATCH] WIP: Add support for continious SPI reads

2015-08-27 Thread Nico Huber
Rebased this old, rotting patch. Not tested in the last two years, but might help to speed up some things (ftdi got pretty fast with this). It has to be enabled per chip (see WINBOND/W25Q64.V for example). --- chipdrivers.h | 1 + cli_common.c | 14 +++--- flash.h | 23 +++

[flashrom] [PATCH] ft2232: Hack to delay SPI command after CS# assertion

2015-10-04 Thread Nico Huber
Here's a tiny hack that I use to externally flash my X200s with an FT2232H. It delays the SPI command by repeating the CS# assertion command many times. Signed-off-by: Nico Huber --- ft2232_spi.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/ft2232_sp

Re: [flashrom] flashrom output on HP 425 Notebook

2015-10-12 Thread Nico Huber
Hi Bruno, people were quite busy with the coreboot conference last week. In case you didn't find answers on your own yet: > My question is: Why flashrom says it doesn't support my motherboard if > my chipset is supported on the coreboot project wiki. Your question somehow answers itself: For core

Re: [flashrom] [PATCH 1/3] 128 bytes write granularity support

2015-10-14 Thread Nico Huber
On 10.10.2015 16:20, Paul Kocialkowski wrote: > Some chips such as the ENE KB9012 internal flash require a write granularity > of > 128 bytes. > > Signed-off-by: Paul Kocialkowski clean patch, +2 > --- > flash.h| 1 + > flashrom.c | 6 ++ > 2 files changed, 7 insertions(+) > > diff --

Re: [flashrom] [PATCH 2/3] Flag-driven erased bit value

2015-10-14 Thread Nico Huber
On 10.10.2015 16:20, Paul Kocialkowski wrote: > Most flash chips are erased to ones and programmed to zeros. However, some > other > flash chips, such as the ENE KB9012 internal flash, work the opposite way. > > Signed-off-by: Paul Kocialkowski Looks good, some comments below. Nico > --- > fl

Re: [flashrom] [PATCH 3/3] ENE Embedded Debug Interface (EDI) and ENE KB9012 EC internal flash support

2015-10-14 Thread Nico Huber
On 10.10.2015 16:20, Paul Kocialkowski wrote: > The ENE Embedded Debug Interface (EDI) is a SPI-based interface for accessing > the memory of ENE embedded controllers. > > The ENE KB9012 EC is an embedded controller found on various laptops such as > the Lenovo G505s. It features a 8051 microcontr

Re: [flashrom] SOIC8 test clip - cant write to BIOS SPI flash chip

2015-10-17 Thread Nico Huber
Hi Robert, it might be easier to help if we knew your Laptop model. Also, please provide a full log of the failing flashrom run with the -V switch, you can specify a log file with -o. On 17.10.2015 02:07, Robert Brown wrote: > But here is a problem: I could read a dump from this BIOS chip without

Re: [flashrom] SOIC8 test clip - cant write to BIOS SPI flash chip

2015-11-01 Thread Nico Huber
On 22.10.2015 00:24, Denis 'GNUtoo' Carikli wrote: > On Sat, 17 Oct 2015 12:57:54 +0200 > Nico Huber wrote: >> I'd try with the AC adapter. In that case Vcc must _not_ be connected >> to your programmer. GND, OTOH, has to stay connected. > If that happens, coul

Re: [flashrom] [PATCH v2 1/2] Flag-driven erased bit value

2015-11-01 Thread Nico Huber
On 24.10.2015 13:24, Paul Kocialkowski wrote: > Most flash chips are erased to ones and programmed to zeros. However, some > other > flash chips, such as the ENE KB9012 internal flash, work the opposite way. > > Signed-off-by: Paul Kocialkowski Two comments below. Nico > --- > flash.h| 5

Re: [flashrom] [PATCH v2 2/2] ENE Embedded Debug Interface (EDI) and ENE KB9012 EC internal flash support

2015-11-08 Thread Nico Huber
Hi Paul, less comments today. Nico On 24.10.2015 13:24, Paul Kocialkowski wrote: > The ENE Embedded Debug Interface (EDI) is a SPI-based interface for accessing > the memory of ENE embedded controllers. > > The ENE KB9012 EC is an embedded controller found on various laptops such as > the Lenov

Re: [flashrom] [PATCH 3/3] ENE Embedded Debug Interface (EDI) and ENE KB9012 EC internal flash support

2015-11-08 Thread Nico Huber
Hi Paul, On 24.10.2015 13:19, Paul Kocialkowski wrote: > I will probably send v2 right away, feel free to follow up the > discussion on some of these comments in there, it'll probably be > easier. I'll keep some of the general discussion here. Some new comments will come inline with v2. >>> + u

Re: [flashrom] [PATCH 3/3] ENE Embedded Debug Interface (EDI) and ENE KB9012 EC internal flash support

2015-11-11 Thread Nico Huber
On 11.11.2015 16:34, Paul Kocialkowski wrote: > Le dimanche 08 novembre 2015 à 15:53 +0100, Nico Huber a écrit : >> Hi Paul, >> >> On 24.10.2015 13:19, Paul Kocialkowski wrote: >>> I will probably send v2 right away, feel free to follow up the >>> discus

Re: [flashrom] [PATCH v3 1/2] Add support for selecting the erased bit value with a flag

2015-11-11 Thread Nico Huber
On 11.11.2015 16:55, Paul Kocialkowski wrote: > Most flash chips are erased to ones and programmed to zeros. However, some > other > flash chips, such as the ENE KB9012 internal flash, work the opposite way. > > Signed-off-by: Paul Kocialkowski Acked-by: Nico Huber > ---

Re: [flashrom] [PATCH v3 2/2] ENE Embedded Debug Interface (EDI) and ENE KB9012 EC internal flash support

2015-11-11 Thread Nico Huber
not in use. Some firmwares disable EDI at run-time, so > it might be necessary to ground pin 42 to reset the 8051 microcontroller > before > accessing the KB9012 via EDI. > > Signed-off-by: Paul Kocialkowski Acked-by: Nico Huber > --- > Makefile

Re: [flashrom] Proposed changes to flashrom hosting and workflow

2016-01-02 Thread Nico Huber
On 31.12.2015 19:18, Stefan Tauner wrote: >> For those who missed it on IRC, Stefan (Reinauer) has proposed retiring SVN >> and patch work in favor of Git and (likely) Gerrit + Jenkins. Maintaining >> SVN and Patchwork represents a surprisingly large maintenance burden on top >> of Git and Gerrit t

Re: [flashrom] flashrom as programmer slow because it reads the whole SPI Flash contents before writing anything

2016-01-11 Thread Nico Huber
Hi rdiez, On 11.01.2016 14:58, R. Diez wrote: > Hi all: > > I am trying to use flashrom with a fast generic FTDI FT2232H adapter as > an SPI Flash programmer in a small production line. Nice to here. > > The SPI Flash chip can hold 8 MiB of data, but we are only using the > first 512 KiB of it.

Re: [flashrom] Giving to -i option some real use

2016-04-22 Thread Nico Huber
erasers to those that match the layout. This would simplify things a lot. And, IMO, you can have a layout with erase block aligned regions in most use cases. Regards, Nico -- M. Sc. Nico Huber Senior Berater SINA-Softwareentwicklung Netzwerk- & Client-Sicherheit / Network & Client

Re: [flashrom] Giving to -i option some real use

2016-04-26 Thread Nico Huber
e will maintain two code paths until libflashrom is used internally by flashrom. Any comments? Best regards, Nico -- M. Sc. Nico Huber Senior Berater SINA-Softwareentwicklung Netzwerk- & Client-Sicherheit / Network & Client Security Division Öffentliche Auftraggeber / Public Authoriti

[flashrom] [PATCH 2/2] dediprog: Fix bug where too many transfers would be queued

2016-05-04 Thread Nico Huber
We didn't check the total number of queued transfers in the inner most loop. Up to DEDIPROG_ASYNC_TRANSFERS - 1 invalid transfers could be queued therefore. So add another check on the total number. Signed-off-by: Nico Huber --- dediprog.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

[flashrom] [PATCH 1/2] dediprog: Reimplement target chip option

2016-05-04 Thread Nico Huber
Signed-off-by: Nico Huber --- dediprog.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/dediprog.c b/dediprog.c index 019de46..b7276e5 100644 --- a/dediprog.c +++ b/dediprog.c @@ -942,7 +942,7 @@ int dediprog_init(void) int spispeed_idx = 1

[flashrom] [PATCH 14/14] Enable writes with active ME

2016-05-04 Thread Nico Huber
At least with the -A,--noverify-all switch, this warning isn't true any more. Maybe we want to force -A in that case? Signed-off-by: Nico Huber --- flashrom.8.tmpl | 9 + ichspi.c| 29 - 2 files changed, 1 insertion(+), 37 deletions(-) diff --

[flashrom] [PATCH 04/14] Add a convenient libflashrom interface

2016-05-04 Thread Nico Huber
*() rewritten with layout support (touch only included regions). o Moved read/erase/write/verify operations to flashrom.c. o Added layout pointer and flags to the flash context. Signed-off-by: Nico Huber --- Makefile | 8 +- flash.h | 6 ++ flashrom.c| 293

[flashrom] [PATCH 03/14] Add functions to read/erase/write/verify by layout

2016-05-04 Thread Nico Huber
ied it yet, though. Signed-off-by: Nico Huber --- flash.h| 1 + flashrom.c | 326 + 2 files changed, 327 insertions(+) diff --git a/flash.h b/flash.h index bf381cf..be1134a 100644 --- a/flash.h +++ b/flash.h @@ -216,6 +216,7 @@ struc

[flashrom] [PATCH 09/14] cli_classic: Remove layout-for-write-only check

2016-05-04 Thread Nico Huber
Signed-off-by: Nico Huber --- cli_classic.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/cli_classic.c b/cli_classic.c index d23a3a3..aef7693 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -376,12 +376,6 @@ int main(int argc, char *argv[]) ret = 1

[flashrom] My current libflashrom/layout branch

2016-05-04 Thread Nico Huber
Hi all, this is my current work on layout support and libflashrom. I don't have the time currently to clean it more up / respond to a review, as I will be on vacation for about three weeks. Most things are pretty clean though. So I sent it in, in case anyone wants to look at it or just play with

[flashrom] [PATCH 07/14] Kill doit()

2016-05-04 Thread Nico Huber
No words can describe this feeling. Signed-off-by: Nico Huber --- cli_classic.c | 24 ++-- flash.h | 5 +- flashrom.c| 393 +++--- 3 files changed, 90 insertions(+), 332 deletions(-) diff --git a/cli_classic.c b/cli_classic.c

[flashrom] [PATCH 13/14] Whitelist Roda/RV11 laptop

2016-05-04 Thread Nico Huber
Signed-off-by: Nico Huber --- board_enable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board_enable.c b/board_enable.c index 2f0c1c0..22e45b4 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2457,6 +2457,7 @@ const struct board_match board_matches[] = { {0x10DE, 0x0360

[flashrom] [PATCH 11/14] Add option to read ROM layout from IFD

2016-05-04 Thread Nico Huber
Add an option (-d|--ifd) to read the ROM layout from an Intel Firmware Descriptor (IFD). Works the same as the -l option, if given, -i specifies the images to update. v2: o Rebased on libflashrom, use libflashrom interface. o Use functions from ich_descriptors.c. Signed-off-by: Nico Huber

[flashrom] [PATCH 01/14] Make image parameter of cb_check_image() const

2016-05-04 Thread Nico Huber
Signed-off-by: Nico Huber --- cbtable.c| 14 +++--- programmer.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/cbtable.c b/cbtable.c index 1a74e46..c1c264a 100644 --- a/cbtable.c +++ b/cbtable.c @@ -38,13 +38,13 @@ static char *cb_vendor = NULL, *cb_model

[flashrom] [PATCH 12/14] Fix linking with libpayload

2016-05-04 Thread Nico Huber
o flashbuses_to_text() is a cli function and should actually be moved or not be called from flashrom.c. o I couldn't find any libc that defines HAVE_STRNLEN. Signed-off-by: Nico Huber --- flash.h| 2 +- flashrom.c | 9 ++--- helpers.c | 2 +- 3 files changed, 8 insertions(

[flashrom] [PATCH 08/14] Add option (-A, --noverify-all) to not verify the whole chip after write

2016-05-04 Thread Nico Huber
This also reduces the data read before the write to the included layout regions. Signed-off-by: Nico Huber --- cli_classic.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/cli_classic.c b/cli_classic.c index d7e17f7..d23a3a3 100644 --- a/cli_classic.c +++ b

[flashrom] [PATCH 02/14] Give layouts their own type

2016-05-04 Thread Nico Huber
Introduce `struct fl_layout` and refactor layout.c a little, so we can reuse the layout from there and have other sources of layouts beside it. I didn't want to clutter up flash.h any more. So things went into a new layout.h. Signed-off-by: Nico Huber --- flash.h | 10 ++-- layout.c

[flashrom] [PATCH 06/14] Adapt CLI to use new libflashrom interface' print callback

2016-05-04 Thread Nico Huber
This renames CLI's print() to fl_print_cb() and registers it through the new libflashrom interface. Signed-off-by: Nico Huber --- cli_classic.c | 3 +++ cli_output.c | 13 ++--- flash.h | 2 ++ 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/cli_classi

[flashrom] [PATCH 10/14] Make read_ich_descriptors_from_dump() available in flashrom

2016-05-04 Thread Nico Huber
trouble, I guess. :-P Signed-off-by: Nico Huber --- ich_descriptors.c | 23 --- ich_descriptors.h | 11 --- util/ich_descriptors_tool/Makefile | 2 +- 3 files changed, 9 insertions(+), 27 deletions(-) diff --git a/ich_descr

[flashrom] [PATCH 05/14] Add Doxyfile for libflashrom documentation

2016-05-04 Thread Nico Huber
Reference documentation for libflashrom can be build with doxygen. With doxygen Doxyfile documentation will be put into a libflashrom-doc/ subdirectory. Signed-off-by: Nico Huber --- Doxyfile | 1781 ++ 1 file changed, 1781

Re: [flashrom] Flashing ThinkPad X200 (was: Problems with CH341A)

2016-06-10 Thread Nico Huber
Hi Potato, On 07.06.2016 18:59, potato wrote: > I know that the programmer works, since I was able to make goods dumps > of a MX25L8006 that was on a old router, but I was not able to detect a > MX25L6405D that was on my Thinkpad X200 (it could not even find a chip). > I know it is not a problem w

Re: [flashrom] Broadwell-DE SoC

2016-08-02 Thread Nico Huber
Hi Wen, On 01.08.2016 21:29, Wen Wang wrote: > Has anybody tried flashrom on Broadwell-DE SoC? Intel has upstreamed > coreboot support. But we are having trouble with flashrom. The ME region > does not seem to be accessible. We cannot read the entire flash (fails when > reading ME) even though we

Re: [flashrom] Broadwell-DE SoC

2016-08-02 Thread Nico Huber
Hi Ed, On 02.08.2016 21:34, Ed Swierk wrote: > With Nico's patches, I am able to read the BIOS portion of the flash > (0x0800-0x1000) on a Camelback Mountain board with the stock > BIOS. thanks for the report. > I haven't been able to write the BIOS portion of the flash, though, as > it f

Re: [flashrom] Unsupported Lenovo Thinkpad X200

2016-08-06 Thread Nico Huber
Hello Alexander, On 06.08.2016 12:28, Alexander Waldmann wrote: > > Basically what it says on the tin. One of my X200 systems works with > flashrom's internal programmer, as expected, but a recently acquired one > does not, I get the error about unsupported laptop. Using the > laptop:force_I_want

[flashrom] Release numbering and branches

2016-08-10 Thread Nico Huber
Hi folks, now that we have a git repository [1] ready (thanks Stefan!), I've visited again the flashrom development guidelines [2]. I stumbled there over a very long, exemplary version number: "0.9.10.1". IMHO, two things are wrong here: 1st there are too many dots for my taste, and 2nd the former

Re: [flashrom] [PATCH] RFC: enable flashrom to write images of arbitrary size

2016-11-08 Thread Nico Huber
Hi all, On 09.11.2016 00:20, Charlotte Plusplus wrote: > Hello > > That is very interesting. Do you have a way to automate that? > > I am testing ram stuff with coreboot, I don't need to flash a full 8MB > image. I could just pass a -i of the cbfs content to only change the > ramstage, and do a

Re: [flashrom] How to only flash BIOS region on braswell.

2016-11-22 Thread Nico Huber
Hi Sampson, On 21.11.2016 04:33, Sampson Lee wrote: > I add a few point: > > I use flshrom version:0.99. > I try command "--layout" to read my rom file,but it show error message > "error parsing layout file". well, it means what it says, flashrom can't understand the file you gave to the `--layo

Re: [flashrom] [PATCH] Convert flashrom to git

2016-11-22 Thread Nico Huber
Hi Stefan, could you please split this up? I started to review but I guess the patch will have gone through some revisions before I'm done reading. On 21.11.2016 01:19, Stefan Tauner wrote: > - Drop support for Subversion in the getrevision script and Makefile. > - Add .gitignore file > - Rest

Re: [flashrom] How to only flash BIOS region on braswell.

2016-11-23 Thread Nico Huber
hanks. > Sampson. > > 2016-11-23 3:20 GMT+08:00 Nico Huber : > >> Hi Sampson, >> >> On 21.11.2016 04:33, Sampson Lee wrote: >>> I add a few point: >>> >>> I use flshrom version:0.99. >>> I try command "--layout" to rea

Re: [flashrom] FAILED: GA-B75M-D3V

2016-12-23 Thread Nico Huber
On 23.12.2016 08:19, David Hendricks wrote: > Looks like it failed to overwrite the descriptor region (Intel ME-related > headache): https://www.flashrom.org/ME According to the log, the descriptor is writeable. Also the error occurs right behind it. When I looked through it first, I thought ther

[flashrom] Layout Aware Flash Reading and Erase Blocks

2017-03-10 Thread Nico Huber
Hi, I've just updated my solution to _the_ layout problem that I wrote last year [1]. I'm not asking for a review at this moment. There are at least two competing approaches that I want to discuss first (I couldn't start a discussion before I wrote it, due to time constraints). We can 1) walk

Re: [flashrom] Layout Aware Flash Reading and Erase Blocks

2017-03-16 Thread Nico Huber
On 16.03.2017 00:08, David Hendricks wrote: > On Fri, Mar 10, 2017 at 8:02 AM, Nico Huber wrote: >> >> Hi, >> >> I've just updated my solution to _the_ layout problem that I wrote last >> year [1]. I'm not asking for a review at this moment. There are

Re: [flashrom] Problem with flashrom and FT2232 Port B

2017-03-22 Thread Nico Huber
Hi Zak, On 21.03.2017 17:28, Zak wrote: > Hello, > > I got flashrom compiled for windows and it works like a charm (has to > tweet the code a little, add data for the chips i want to work with, add > 4BA and fast rading for FT2232), it works perfectly fine but only for > the port A (flashrom -p f

Re: [flashrom] Flash Access on Shuttle XH170V failed

2017-03-22 Thread Nico Huber
Hi Michael, On 21.03.2017 20:48, Michael Fuckner wrote: > Hi, > > I added PCI ID for my chipset, but I can't access/ read FLash chip. Any > idea how to proceed? if you compare the datasheets, you'll see that it's incompatible with the 9series PCH. I'm currently working on upstream support for t

Re: [flashrom] Problem with flashrom and FT2232 Port B

2017-03-22 Thread Nico Huber
it's the same error Sorry, I'm just poking in the dark. Another idea: Some other driver or program might have claimed access to port B and is blocking it. flash- rom doesn't know how to handle that, maybe your "other softwares" do. Nico > > Regards > > Le 22

Re: [flashrom] Flash Access on Shuttle XH170V failed

2017-03-22 Thread Nico Huber
30: > 0040: > > Regards, > Michael! > > On 3/22/2017 1:08 PM, Nico Huber wrote: >> Hi Michael, >> >> On 21.03.2017 20:48, Michael Fuckner wrote: >>

Re: [flashrom] Flash Access on Shuttle XH170V failed

2017-03-23 Thread Nico Huber
Hi Michael, On 22.03.2017 16:43, Nico Huber wrote: > On 22.03.2017 16:13, Michael Fuckner wrote: >> Hi, >> >> just tried it- this Board uses a Winbond 25Q64FV (64Mbit) and after >> reading there is an 8MB file, but it is empty. Anything else I should try? > > Sam

Re: [flashrom] Flash Access on Shuttle XH170V failed

2017-03-23 Thread Nico Huber
On 23.03.2017 20:26, Michael Fuckner wrote: > Hi, > > I got a file, 8MB in size and it contains data. md5sum is not identical > to original file and binwalk looks different on the beginning. Not sure, what an "original" file would be. The flash contains data that is specific to your device like s

Re: [flashrom] Fwd: Re: Problem with flashrom and FT2232 Port B

2017-03-23 Thread Nico Huber
Hi Zak, please always keep the mailing list in CC, you will get less attention otherwise. On 23.03.2017 12:16, Nico Huber wrote: > > Forwarded Message > Subject: Re: [flashrom] Problem with flashrom and FT2232 Port B > Date: Wed, 22 Mar 2017 18:01:18 +0100 >

Re: [flashrom] Flash Access on Shuttle XH170V failed

2017-03-27 Thread Nico Huber
Hi Michael, On 24.03.2017 15:14, Michael Fuckner wrote: > Hi, > > I had to use flashrom and my raspi to reflash my bios chip after it got > corrupted. Now I compare the original Firmware (XH170V00.200) I flashed > into the Chip with the file I read (flash.bin). > > I found the MAC Address in the

Re: [flashrom] flashrom and MacMini 2009

2017-03-29 Thread Nico Huber
Hello Micha, On 27.03.2017 13:58, Michael Schröder wrote: > Dear folks, > > i am interested in using coreboot with a MacMini 2007 (core2duo). It > uses the same chipset (GM945) as the macbook2.1 which supported yet. > > I managed to read infos about the BIOS with flashrom. > The verbose output i

Re: [flashrom] Can flashrom be used safely with external USB WCH CH341A & laptop?

2017-04-12 Thread Nico Huber
Hello Boyce, On 12.04.2017 18:23, Boyce Humphries via flashrom wrote: > hello again @flashrom > > Could a flashrom option be added to allow only USB ports to be probed, > programmed, etc. > External programmers are cheap and there many laptops out here. in current flashrom (0.9.9), the default

Re: [flashrom] Fwd: Re: [#ZJW-196-68375]: how to setup power options

2017-04-18 Thread Nico Huber
Hello Martin, On 18.04.2017 20:36, Martin wrote: > Hello, > > I have problem after trying flash QNAP TS-453A > > ... > Proceeding anyway because user forced us to. > Found chipset "Intel Braswell". > This chipset is marked as untested. If you are using an up-to-date version > of flashrom *and* w

[flashrom] Namespace prefix for libflashrom

2017-04-22 Thread Nico Huber
Hi flashrom folks, working again on implementing the libflashrom interface described here [1]. During review [2] the question arose what `fl_` means and if we don't want to use something else. The following alternatives were pro- posed in the wiki: * fl_ / FL_ (probably *fl*ashrom) * lf_ / LF

Re: [flashrom] Namespace prefix for libflashrom

2017-04-22 Thread Nico Huber
with functions such > as flash_image_read() and flash_image_write(), but is awkward with some > other stuff like "flash_set_log_callback()". If we're already typing >2 > letters I think we ought to just use flashrom_ as the prefix to be > complete, avoid awkward contexts, and a

Re: [flashrom] Namespace prefix for libflashrom

2017-04-23 Thread Nico Huber
On 23.04.2017 16:07, Stefan Tauner wrote: > On Sat, 22 Apr 2017 11:16:18 -0700 > David Hendricks wrote: > >> Thanks for getting this discussion going on the list, Nico. >> >> For reference, folks can view the proposed libflashrom.h at >> https://review.coreboot.org/#/c/17946 to get a better idea

Re: [flashrom] flashrom v0.9.9-r1955 FAILS ON sst25lf080(a) with ch341a_spi

2017-06-13 Thread Nico Huber
Hi Boyce, Josh, On 13.06.2017 16:24, Boyce Humphries via flashrom wrote: > Hello Josh > > I dove into the code yesterday and here is what I found. When the bits > BP0 and BP1 in the status register need to be cleared the function > spi_disable_blockprotect(flash) is called. To clear these bits (

Re: [flashrom] Getting inconsistent reads with a Raspberry Pi

2017-07-14 Thread Nico Huber
Hi David, On 14.07.2017 18:30, David Hobach wrote: > For reference: > > Apparently the Pi didn't provide enough current to drive the chip and > whatever else hang in the motherboard together with it. a word of caution: Applying external power (i.e. connecting the sol- dered chip's VCC to an exte

Re: [flashrom] flash verification failure over and over

2017-08-09 Thread Nico Huber
Hi Ian, jumping in here late because I had no idea yet how to help you. On 04.08.2017 16:26, Ian Stewart wrote: > Hi There, > > I keep getting Verifying flash... FAILED messages over and over while > trying to flash an 8mb x200 chip. I'd say I've gotten the message ~10 > times now and I've trie

Re: [flashrom] flash verification failure over and over

2017-08-09 Thread Nico Huber
t; Ian > > On Wed, Aug 9, 2017 at 3:41 PM, Nico Huber wrote: > >> Hi Ian, >> >> jumping in here late because I had no idea yet how to help you. >> >> On 04.08.2017 16:26, Ian Stewart wrote: >>> Hi There, >>> >>> I keep getting Verif

Re: [flashrom] Using libflashrom from fwupd

2017-08-16 Thread Nico Huber
Hi Richard, David, On 16.08.2017 23:02, David Hendricks wrote: > On Tue, Aug 15, 2017 at 4:55 AM, Richard Hughes wrote: > >> Hi all, >> >> I'm the maintainer of fwupd, which is a daemon for doing firmware >> updates in Linux. Using fwupd about 200,000 people update firmware >> every month. At th

Re: [flashrom] Using libflashrom from fwupd

2017-08-17 Thread Nico Huber
On 17.08.2017 11:30, Stefan Tauner wrote: > On Thu, 17 Aug 2017 10:23:54 +0100 > Richard Hughes wrote: > >> On 17 August 2017 at 10:18, Stefan Tauner wrote: >>> However, this is inevitable sometimes as explained before... so maybe >>> we need some additional message passing indicating the differ

[flashrom] Erase-function fallback (was: Using libflashrom from fwupd)

2017-08-17 Thread Nico Huber
Hi, starting a new thread for this because it's somewhat orthogonal. > [...] The progress would not be > constant in speed (e.g. because reading is usually much faster than > writing), and it would sometimes even be non-monotonic (if a write > fails, we re-read the whole chip to make absolutely s

[flashrom] Contexts in the libflashrom interface (was: Using libflashrom from fwupd)

2017-08-17 Thread Nico Huber
Yet another thread (YAT?). > > flashrom_set_progress_callbacks(flashrom_progress_cb *cb_progress, > flashrom_progress_event_cb *cb_event, void *user_data); < We might need > to add a flashrom context here? No idea how the current staging > implementation works but eventually we want to fix the hid

Re: [flashrom] Using libflashrom from fwupd

2017-08-17 Thread Nico Huber
On 17.08.2017 14:09, Stefan Tauner wrote: > > > On Thu, 17 Aug 2017 11:53:58 +0200 > Nico Huber wrote: > >> B := we need to give the user a really good reason >> >> Having a RESET enum value allows us to fulfill B, thus: >> >> RESET -> B &g

Re: [flashrom] error during install to new Raspbian Distro

2017-08-24 Thread Nico Huber
Hi Billy, On 24.08.2017 09:03, Billy Isom wrote: > hello friend > > I have been using flashrom for a little while now with great results, but i > upgraded to the latest Raspbian Distro. > upon attempting to reinstall Flashrom on my Raspberry PI 3 I receive an > error. > > I was hoping you could

Re: [flashrom] Erase failure on Sapphire Pure Platinum H61 with coreboot

2017-09-02 Thread Nico Huber
al flashing doesn't work at all. For the record, this commit enabled the SPI lockdown (e.g. locked the OPMENU). Which was previously only set after resume by accident. > > As suggested by Nico Huber, I tried with `-p > internal:ich_spi_mode=hwseq`, without success (log attached). >

Re: [flashrom] [coreboot] Erase failure on Sapphire Pure Platinum H61 with coreboot

2017-09-02 Thread Nico Huber
Hi, On 02.09.2017 21:02, Nicola Corna wrote: > September 2, 2017 5:39 PM, "Nico Huber" wrote: >> From the original op menu these are probably unneeded: byte program >> (0x02), either one of the block erasers (0x20 and 0xd8) and the fast >> read (0x0b). >> &

Re: [flashrom] [coreboot] Erase failure on Sapphire Pure Platinum H61 with coreboot

2017-09-05 Thread Nico Huber
On 04.09.2017 19:31, Nicola Corna wrote: > September 3, 2017 12:24 AM, "Nico Huber" wrote: > >> TLDR; it would be a lot slower. >> >> Alas, there is no usual byte-program mode. Most chips do a 256B page >> program which uses op code 0x02 too. For the SST

Re: [flashrom] read BIOS settings

2017-09-16 Thread Nico Huber
Hi Adam, On 14.09.2017 11:43, Adam Makkos wrote: > Hi, > > Can you please tell if flashrom is able to also read bios settings? that depends, of course, where the settings are stored and that varies from device to device (modern PCs usually store them in the BIOS flash). Though, even if they happ

Re: [flashrom] Winbond W25Q64FVSIG - "ERASE FAILED!"

2017-09-16 Thread Nico Huber
Hi, On 15.09.2017 18:56, junkheap--- via flashrom wrote: > I am trying to write to a Winbond W25Q64FVSIG EEPROM (SOIC-8) using > Flashrom and a Raspberry Pi 3 (running up to date Raspbian). But I > receive the message "ERASE FAILED!". > > I am using the shortest wires which are practical to conne

  1   2   3   4   >