[flashrom] Re: libflashrom questions

2025-03-17 Thread Anastasia Klimchuk
Dmitry, thank you for the patch! I was so happy to see you made a patch already, that I started reviewing and forgot to post here :) So, we have moved to code review for #2, if anyone is interested, have a look in Gerrit. Anastasia On Mon, 17 Mar 2025, 13:39 Dmitry Zhadinets, wrote: > Sorry fo

[flashrom] Re: libflashrom questions

2025-03-17 Thread Dmitry Zhadinets
Probably this is a better place than Gerrit to discuss my question about this line https://github.com/flashrom/flashrom/blob/c3b89597fc61e14c4bc3a1e57e949483325c1e76/libflashrom.c#L47 What if we implement this in the logger APIg patch? It would prevent many calls, unnecessary allocations, and redun

[flashrom] Re: Feature Request : Software SPI using gpio lines from sysfs or libgpiod (Issue #339)

2025-03-17 Thread Anastasia Klimchuk
Hello Pierre, Thank you for sharing your idea! I wanted to ask, which phase is your idea currently? Do you have something working locally, or have you tried? If you can make something working and share it as a patch, we can then look at it and think of structure etc. The patch doesn't have to be