[flac-dev] [PATCH 3/4] Honor user's $(htmldir) and do not override GNU defaults for $(docdir)

2017-01-13 Thread David Seifert
* HTML files should be installed to $(htmldir), and $(docdir) should not be changed, as this is a user flag in the GNU conventions. --- doc/Makefile.am | 2 -- doc/html/Makefile.am| 10 -- doc/html/images/Makefile.am | 4 ++-- 3 files changed, 6 insertions(+), 10 de

[flac-dev] [PATCH 2/4] Make building/installing examples optional

2017-01-13 Thread David Seifert
--- Makefile.am | 6 +- configure.ac | 5 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index a325e3a9..38aea04a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -31,7 +31,11 @@ ACLOCAL_AMFLAGS = -I m4 -SUBDIRS = doc include m4 man src exampl

[flac-dev] Upstreaming Gentoo patches

2017-01-13 Thread David Seifert
documentation that differ from what is currently coded in the various Makefile.am's. Regards David Seifert ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] [PATCH 4/4] When using libtool, use LTLIBICONV instead.

2017-01-13 Thread David Seifert
* This is required, as otherwise -Wl,--as-needed could fail. --- src/flac/Makefile.am | 2 +- src/metaflac/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/flac/Makefile.am b/src/flac/Makefile.am index bf3bf468..fe6fa489 100644 --- a/src/flac/Makefile.am +

[flac-dev] [PATCH 1/4] Do not override CFLAGS, as CFLAGS is a user flag.

2017-01-13 Thread David Seifert
* Furthermore, use NDEBUG globally to detect the presence of building with more debug output information. AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays Gnome has also switched to it from its own custom solution. --- configure.ac | 19 +-- include/FLAC/assert.h

[flac-dev] Updated CFLAGS patches and make test compilation conditional

2017-01-15 Thread David Seifert
Hi Erik, I've found a middleground for the problem of setting default CFLAGS. I've gone back to setting them if {C,CXX,CPP,LD}FLAGS are unset at the onset of the configure script (i.e., the user hasn't specified anything) and then proceed to set them to the defaults as before. This has been sugg

[flac-dev] [PATCH 1/2] Do not override CFLAGS, as CFLAGS is a user flag.

2017-01-15 Thread David Seifert
* Furthermore, use NDEBUG globally to detect the presence of building with more debug output information. AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays Gnome has also switched to it from its own custom solution. --- configure.ac | 52 -- include/FLAC/

[flac-dev] [PATCH 2/2] Only compile and run tests when running 'make check'

2017-01-15 Thread David Seifert
--- src/test_grabbag/cuesheet/Makefile.am | 2 +- src/test_grabbag/picture/Makefile.am | 2 +- src/test_libFLAC++/Makefile.am| 2 +- src/test_libFLAC/Makefile.am | 2 +- src/test_seeking/Makefile.am | 2 +- src/test_streams/Makefile.am | 2 +- 6 files changed, 6

[flac-dev] Minor CFLAGS-related cleanups

2017-02-04 Thread David Seifert
Hi Erik, similar to what I did for libsndfile, this is to simplify the handling of adding -D_FORTIFY_SOURCE=2. Regards David ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

2017-02-04 Thread David Seifert
:0:0: error: "_FORTIFY_SOURCE" redefined [-Werror] +# : note: this is the location of the previous definition +# +# which is a problem if -Werror is enabled. This macro checks whether +# _FORTIFY_SOURCE is already defined, and if not, adds -D_FORTIFY_SOURCE=2 +# to CPPFLAGS. +#

Re: [flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

2017-02-05 Thread David Seifert
On Sun, 2017-02-05 at 20:47 +1100, Erik de Castro Lopo wrote: > David Seifert wrote: > > > - AC_PROG_SED > > - CFLAGS=$(echo "$CFLAGS" | $SED 's/-O2//') > > - CFLAGS="-O3 -funroll-loops $CFLAGS" > > + CFLAGS="-O3 -funroll-