Re: [flac-dev] Looking for users of --keep-foreign-metadata

2022-11-02 Thread Martijn van Beurden
Op ma 31 okt. 2022 om 01:37 schreef brianw : > - There is a generally-accepted industry practice concerning these extra > chunks that points out that it's problematic to preserve all types of chunks > when editing the audio. For example, a visual overview or a cue list might > easily become inco

Re: [flac-dev] Looking for users of --keep-foreign-metadata

2022-11-02 Thread Martijn van Beurden
Op wo 2 nov. 2022 om 13:48 schreef Martijn van Beurden : > Perhaps an option --force-stored-foreign-metadata could be added to > have FLAC blindly use the foreign metadata chunks and data chunk > headers. I think this might result in invalid files (wrong chunk > sizes) in corner cases, for example

Re: [flac-dev] Looking for users of --keep-foreign-metadata

2022-11-02 Thread David Willmore
If a --force-* option fails, shouldn't it error out instead? Scripts aren't going to pick up on a warning, but they should pick up on an errored exit code (or they're just not written well enough to care). On Wed, Nov 2, 2022 at 2:20 PM Martijn van Beurden wrote: > Op wo 2 nov. 2022 om 13:48 sc

Re: [flac-dev] Looking for users of --keep-foreign-metadata

2022-11-02 Thread Federico Miyara
Considering that 1) audio data is always (I believe...) in a single connected block, 2) its location and length is unambiguously known, 3) its basic formatting information is at the header, hence readily and unambiguously known, and 4) all metadata, either native or foreign, including the header

Re: [flac-dev] Looking for users of --keep-foreign-metadata

2022-11-02 Thread Martijn van Beurden
Op wo 2 nov. 2022 om 21:44 schreef David Willmore : > > If a --force-* option fails, shouldn't it error out instead? Scripts aren't going to pick up on a warning, but they should pick up on an errored exit code (or they're just not written well enough to care). > I wasn't referring to that force