[flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-26 Thread Mark H. David
Hello, I've tried encoding a FLAC file from a WAVE file saved with 24-bits-per-sample, using the flac executable. I get this warning: WARNING: legacy WAVE file has format type 1 but bits-per-sample=24 The code is currently here on line 373: src/flac/encode.c where the comment says let t

Re: [flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-26 Thread Erik de Castro Lopo
Mark H. David wrote: > I'm new at this and trying to understand it. Can someone explain?\ You are correct. With a wFormatTag of 1, the bist per sample should be either 8 or 16 (according to the Microsoft specs). > Also, a related but more practical question: is there *any* way to > create a 24-

Re: [flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-26 Thread Mark H. David
Thank you for writing and pointing out that one can have WAVE files without getting the warning, and that your library does it. I found out Goldwave (Windows software) writes 24-bit WAVE files that do not get the warning. (Good for them!) However, the flac executable from the flac reference soft

Re: [flac-dev] warning that legacy WAVE file has format type 1 but bits-per-sample is 24

2017-05-26 Thread Erik de Castro Lopo
Mark H. David wrote: > Notice the warning was given only for the WAVE file produced by the > flac reference executable. I agree. The flac decoder should not generate WAV files which it warns about when encoding. > Should I file a bug for this? No need. This is sufficient. Erik -- ---