Re: [flac-dev] [PATCH] Fix cppcheck warnings

2017-01-19 Thread Erik de Castro Lopo
Rosen Penev wrote: > fedora comes with 1.75 so I used that. I also used some additional > flags: cppcheck --enable=all --inconclusive --std=posix --force Thanks! I had wanted to use verison 1.76.1 from Debian in CI, but never enabled it because it was giving me a false positive even with relative

Re: [flac-dev] [PATCH] Fix cppcheck warnings

2017-01-19 Thread Erik de Castro Lopo
Rosen Penev wrote: > index 432e32d..0c2d1ee 100644 > --- a/src/share/utf8/charset.c > +++ b/src/share/utf8/charset.c > @@ -522,6 +522,7 @@ int charset_convert(const char *fromcode, const char > *tocode, >if (to) { > newbuf = realloc(tobuf, p - tobuf); > *to = newbuf ? newbuf : tobuf

Re: [flac-dev] [PATCH] Fix cppcheck warnings

2017-01-19 Thread Erik de Castro Lopo
Rosen Penev wrote: > src/libFLAC/bitreader.c | 4 ++-- > src/libFLAC/bitwriter.c | 4 ++-- > src/plugin_xmms/plugin.c| 2 +- > src/share/utf8/charset.c| 1 + > src/test_libFLAC++/encoders.cpp | 8 > src/test_libFLAC/decoders.c | 4 ++-- > src/test_libF

Re: [flac-dev] [PATCH 1/2] Do not override CFLAGS, as CFLAGS is a user flag.

2017-01-19 Thread Erik de Castro Lopo
David Seifert wrote: > * Furthermore, use NDEBUG globally to detect the presence > of building with more debug output information. > AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays > Gnome has also switched to it from its own custom solution. Applied. Thanks. Erik --