Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

On 1/14/17, Erik de Castro Lopo wrote: > Ozkan Sezer wrote: > >> > Ozkan Sezer wrote: >> > >> >> unsigned int and FLAC__uint32 are used interchangeably, leading to >> >> warnings with platforms (e.g. djgpp) where int32_t is long: >> > >> > Is `sizeof int == 4` though? >> >> Yes, obviously it is >

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

On 01/06/2017 01:53 PM, Hugo Beauzée-Luyssen wrote: > Hi, > > This patchet allows a few targets to be disabled when unrequired. > The rational is coming from VLC's contrib buildsystem, so far we use make -C > to select only some subparts of the available targets. > It would be easier and cleaner

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

Hugo Beauzée-Luyssen wrote: configure.ac: Allow the programs to be disabled configure.ac: Allow bench to be disabled configure.ac: Don't build any tests when they are explicitely disabled configure.ac: Allow examples to be disabled win_utf8_io: Avoid forbidden functions when building f

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

Ozkan Sezer wrote: Well, the commit seems like overkill :) not all the unsigned needed converting. And build fails : format.c:53: error: conflicting types for 'FLAC__STREAM_SYNC' ../../include/FLAC/format.h:176: error: previous declaration of 'FLAC__STREAM_SYNC' was here [many others follow]

Re: [flac-dev] [PATCH] add missing string.h include to cpu.c (for memset())

On 1/13/17, Ozkan Sezer wrote: > Attached patch adds missing string.h include to cpu.c (for memset()) Simpler patch attached, which just replaces memory.h with string.h cpu.c was the only source to use memory.h instead of string.h. -- O.S. 0001-replace-memory.h-include-with-string.h-in-cpu.c.p

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

lvqcl wrote: > Also MSVC fails because src/libFLAC/include/private/bitmath.h now > contains "uint32_t long idx" instead of "unsigned long idx". Ah, missed that because it was MSVC code. They should be `uint64_t`. > According to MSDN _BitScanReverse*() functions have signatures: > unsigned char _

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

Ozkan Sezer wrote: > Well, the commit seems like overkill :) not all the unsigned needed > converting. Not all of them *needed( converting, but afaiac this makes the code base better. I never liked the way the original C standard allowed the use of `unsigned` alone as type. Erik -- ---

Re: [flac-dev] Upstreaming Gentoo patches

David Seifert wrote: > I would like to get some of our patches merged into master. Most > of them deal with adhering to GNU conventions, respectively not > overriding flags/variables that are up to the user to set. For instance, > honoring $(htmldir) is important, as we have installation paths for

Re: [flac-dev] [PATCH 2/4] Make building/installing examples optional

David Seifert wrote: > --- > Makefile.am | 6 +- > configure.ac | 5 + > 2 files changed, 10 insertions(+), 1 deletion(-) Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ _

Re: [flac-dev] [PATCH 4/4] When using libtool, use LTLIBICONV instead.

David Seifert wrote: > * This is required, as otherwise -Wl,--as-needed could fail. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list

Re: [flac-dev] [PATCH 3/4] Honor user's $(htmldir) and do not override GNU defaults for $(docdir)

David Seifert wrote: > * HTML files should be installed to $(htmldir), and $(docdir) should > not be changed, as this is a user flag in the GNU conventions. Applied, but this one required a few extra tweaks to keep "make distcheck" working. Erik -- ---

Re: [flac-dev] [PATCH] add missing string.h include to cpu.c (for memset())

Ozkan Sezer wrote: > On 1/13/17, Ozkan Sezer wrote: > > Attached patch adds missing string.h include to cpu.c (for memset()) > > Simpler patch attached, which just replaces memory.h with string.h > cpu.c was the only source to use memory.h instead of string.h. Applied. Thanks. Erik -- ---

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

lvqcl wrote: > I think that FLAC sources should remain compatible with Visual > Studio 2010 (and probably earlier), people still need it. > For example: > > Is it possible to simply exclude win_utf8_io.c from compiling > if target OS is WinRT/non-desktop?

Re: [flac-dev] [PATCH 1/4] Do not override CFLAGS, as CFLAGS is a user flag.

David Seifert wrote: > * Furthermore, use NDEBUG globally to detect the presence > of building with more debug output information. > AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays > Gnome has also switched to it from its own custom solution. This patch removes `-funroll-loops` which f

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

On 01/14/17 05:23 PM, Erik de Castro Lopo wrote: The `unsigned long` type should be synonymous with `uint64_t` so using `uint64_t` should be safe. Furthermore if they aren't synonymous we *want* that to be a compile error! DOSish systems seem to use long for 32bit types and long long for 64 bi

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

Erik de Castro Lopo wrote: Also MSVC fails because src/libFLAC/include/private/bitmath.h now contains "uint32_t long idx" instead of "unsigned long idx". Ah, missed that because it was MSVC code. They should be `uint64_t`. No, sizeof(unsigned long) is always 4 on Windows. See http://www.viva

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

lvqcl wrote: > > Ah, missed that because it was MSVC code. They should be `uint64_t`. > > No, sizeof(unsigned long) is always 4 on Windows. > See http://www.viva64.com/en/t/0012/ Bah! Trust Windows to be different :). > >> According to MSDN _BitScanReverse*() functions have signatures: > >> uns

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

Erik de Castro Lopo wrote: It's synonymous to uint32_t, but if the 1st parameter for _BitScanReverse*() functions has 'pointer to unsigned long' type then IMHO it's better to simply use unsigned long variable there. Sorry, I disagree on the idea of using `unsigned long` exactly because anyone

Re: [flac-dev] unsigned int and FLAC__uint32 are used interchangeably

lvqcl wrote: > Ok, Visual Studio doesn't complain if idx is declared as uint32_t. As expected :). Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list fl