Re: [flac-dev] Broken build on musl libc

2016-03-14 Thread Erik de Castro Lopo
ne...@hushmail.com wrote: > Patch is here: > > https://github.com/openwrt/packages/commit/1263599f96f13f11d719ce336dfb6a639b32de98 > . > Probably needs to be modified for inclusion into mainline. Applied Thanks. commit a9f84425cfd5d1dbfb564730ca80d0b588cb4f24 Author: Erik de Castro L

Re: [flac-dev] Broken build on musl libc

2016-03-14 Thread Thomas Zander
On 14 March 2016 at 09:02, Erik de Castro Lopo wrote: > commit a9f84425cfd5d1dbfb564730ca80d0b588cb4f24 > Author: Erik de Castro Lopo > Date: Mon Mar 14 18:14:31 2016 +1100 > > libFLAC/cpu.c: Use `sigemptyset` instead of `__sigemptyset` > > The former is POSIX while

[flac-dev] [PATCH] update obj->num_comments if short circuit in read_metadata_vorbiscomment_

2016-03-14 Thread Robert Shih
In function read_metadata_vorbiscomment_ from stream_decoder.c, at various locations where we short circuit the computation, we also set `obj->num_comments` accordingly. For example: https://git.xiph.org/?p=flac.git;a=blob;f=src/libFLAC/stream_decoder.c;h=e0f1b14d30dd548268a88e4341af3f38290816e3;h

Re: [flac-dev] Broken build on musl libc

2016-03-14 Thread lvqcl
Thomas Zander писал(а) в своём письме Mon, 14 Mar 2016 15:29:13 +0300: >> @lvqcl, I tried to test this, but couldn't figure out what CPU architecture >> and configure options were required to build the code that changed. >> >> Any clues? > > AFAIK this part should always be built on Linux (excep

Re: [flac-dev] Broken build on musl libc

2016-03-14 Thread Dave Yeo
On 03/14/16 03:51 PM, lvqcl wrote: > With --disable-sse, FLAC__SSE_OS is undefined and FLAC__cpu_info() uses > sigemptyset/sigaction to determine OS SSE support. That's not quite right as I have to build binaries with --disable-sse (I build and distribute both with and without) so that some users