lvqcl wrote:
> src/share/utf8/utf8.c mentions that "On NT-based windows systems,
> we could use WideCharToMultiByte()/MultiByteToWideChar(CP_UTF8),
> but MS doesn't actually have a consistent API across win32".
>
> flac/metaflac don't support Win98 since ver. 1.3.0, so it's
> possible to use sys
lvqcl wrote:
> The set of four patches that remove dependency of libFLAC on win_utf8_io.
>
> Tested only on Windows, with MSVC and MSYS/MinGW (both autotools and
> makefile.lite)
>
> Please review, especially makefile patches, I'm not very familiar with them.
Applied. All good. Thanks.
Erik
-
Dave Yeo wrote:
> On 01/24/16 12:29 PM, Erik de Castro Lopo wrote:> Dave Yeo wrote:
> >
> >> After this the build dies with,
> >> util.c: In function 'benchmark_function':
> >> util.c:124:17: error: 'CLOCK_PROCESS_CPUTIME_ID' undeclared (first use
> >> in this function)
> >> clock_gettime (CL
Erik de Castro Lopo wrote:
> lvqcl wrote:
>
>> The set of four patches that remove dependency of libFLAC on win_utf8_io.
>>
>> Tested only on Windows, with MSVC and MSYS/MinGW (both autotools and
>> makefile.lite)
>>
>> Please review, especially makefile patches, I'm not very familiar with them.
lvqcl wrote:
> But the 1st patch ('1_sources.patch' file) was not applied...
When I tried apply that patch, all but one hunk succeeded. I inspected
the rejected part, but that seemed to have already been applied.
> Before this set of 4 patches, I posted a patch that tries to prevent
> unnecessa
Erik de Castro Lopo wrote:
When I tried apply that patch, all but one hunk succeeded. I inspected
the rejected part, but that seemed to have already been applied.
'1_sources.patch' creates windows_unicode_filenames.h and
windows_unicode_filenames.c files that don't exist in the current git.
lvqcl wrote:
> '1_sources.patch' creates windows_unicode_filenames.h and
> windows_unicode_filenames.c files that don't exist in the current git.
I already had a commit to add those two files and fix the `make distcheck`
target.
> > Lets just get a patch that fixes what we have now.
>
> Here it
On 02/08/16 03:25 AM, Erik de Castro Lopo wrote:
The configure stuff in the second seems overly complex. Is something like
this:
AC_CHECK_LIB(rt, clock_gettime, have_clock_gettime=yes)
if test x$have_clock_gettime = xyes; then
AC_DEFINE(HAVE_CLOCK_GETTIME)
fi
not suf
