lvqcl wrote:
> Erik de Castro Lopo wrote:
>> Ok, lets do it.
>
> I just thought that it's more complicated. All *file* functions should
> really be moved to libFLAC. But other functions should not, because
> libFLAC doesn't use them.
>
I'm thinking about writing my own patch to fix libFLAC -- win
lvqcl wrote:
> I'm thinking about writing my own patch to fix libFLAC -- win_utf8_io
> dependency. It'll keep win_utf8_io library and move only necessary
> functions into libFLAC. It's more elegant and simple (I hope).
Sounds reasonable. Thanks.
Erik
--
-
Currently MSVC fails when it rebuilds flac solution, because of
some missing dependencies. this patch fixes MSVC projecy files.
fix_msvc_lbflac_dependency.patch
Description: Binary data
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/m
1) Both src/share/Makefile.am and src/share/utf8/Makefile.am
have iconvert.h inside EXTRA_DIST, although iconvert.c includes it.
Why?
2) What's the purpose of charsetmap.h? It seems that it's not used
anywhere.
___
flac-dev mailing list
flac-dev@xiph.org
Previously src/plugin_common library was used by flac own
Winamp plugin (MSVC/Windows) and by XMMS plugin (*nix).
The Winamp plugin is long gone from flac tree, so plugin_common
is unused on Windows. This patch removes it from MSVC project files.
remove_plugin_common_from_msvc.patch
Description:
This file belongs to plugin_xmms, so the comment
in it was fixed.
comment_locale_hack.patch
Description: Binary data
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> 1) Both src/share/Makefile.am and src/share/utf8/Makefile.am
> have iconvert.h inside EXTRA_DIST, although iconvert.c includes it.
> Why?
EXTRA_DIST is for files that are not listed elsewhere in the Makefile.am
but which need to end up in the distribution tarball.
> 2) What's the
lvqcl wrote:
> Currently MSVC fails when it rebuilds flac solution, because of
> some missing dependencies. this patch fixes MSVC projecy files.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
lvqcl wrote:
> Previously src/plugin_common library was used by flac own
> Winamp plugin (MSVC/Windows) and by XMMS plugin (*nix).
> The Winamp plugin is long gone from flac tree, so plugin_common
> is unused on Windows. This patch removes it from MSVC project files.
Applied. Thanks.
Erik
--
--
lvqcl wrote:
> Previously src/plugin_common library was used by flac own
> Winamp plugin (MSVC/Windows) and by XMMS plugin (*nix).
> The Winamp plugin is long gone from flac tree, so plugin_common
> is unused on Windows. This patch removes it from MSVC project files.
Applied. Thanks.
Erik
--
--
lvqcl wrote:
> This file belongs to plugin_xmms, so the comment
> in it was fixed.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
This patch changes win_utf8_io.c: simplifies *print functions,
improves file related functions and prepates to move all file
related functions into libFLAC.
win_utf8_io.patch
Description: Binary data
___
flac-dev mailing list
flac-dev@xiph.org
http://li
Erik de Castro Lopo писал(а) в своём письме Sun, 31 Jan
2016 01:47:01 +0300:
>> 1) Both src/share/Makefile.am and src/share/utf8/Makefile.am
>> have iconvert.h inside EXTRA_DIST, although iconvert.c includes it.
>> Why?
>
> EXTRA_DIST is for files that are not listed elsewhere in the Makefile.am
lvqcl wrote:
> So should it be moved from EXTRA_DIST into
> utf8_libutf8_la_SOURCES/libutf8_la_SOURCES
> where iconvert.c is mentioned?
Yes, it should. Fixed.
> >> 2) What's the purpose of charsetmap.h? It seems that it's not used
> >> anywhere.
> >
> > It was added in 2002, but like you said i
lvqcl wrote:
> This patch changes win_utf8_io.c: simplifies *print functions,
> improves file related functions and prepates to move all file
> related functions into libFLAC.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
htt
15 matches
Mail list logo
