Re: [flac-dev] [PATCH] __builtin_bswap16 on Debian 6

2014-07-03 Thread Erik de Castro Lopo
Ralph Giles wrote: > Jenkins build is failing with an unresolved symbol __builtin_bswap16. > The jenkins instance is on Debian 6 (oldstable) with gcc 4.4.5, which > doesn't provide an implementation for this. > > Here's a quick patch to provide a fallback, which should unbreak the > integration t

Re: [flac-dev] Residual bps and encoding speed

2014-07-03 Thread Erik de Castro Lopo
Martin Leese wrote: > Would not a /* Do not remove */ comment be > sufficient (and much less effort)? Less effort, but also less reliable. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___

Re: [flac-dev] Performance checks

2014-07-03 Thread Miroslav Lichvar
On Wed, Jul 02, 2014 at 10:18:58PM +0200, Martijn van Beurden wrote: > http://www.audiograaf.nl/misc_stuff/FLAC-performance-test-Linux-GCC-4.8.pdf > http://www.audiograaf.nl/misc_stuff/FLAC-performance-test-Wine-MSVC-2013.pdf > > For the GCC 4.8 results, there is a*very nice 60% to 70% speed incre

Re: [flac-dev] uint64 -> double conversion

2014-07-03 Thread Erik de Castro Lopo
lvqcl wrote: > BTW, test_libFLAC is still broken for MSVS: CPU_IS_LITTLE_ENDIAN > is undefined. It's possible to add the definition for this > preprocessor macro to test_libFLAC.vcproj, but maybe there exists > more elegant way? I think I've fixed this in commit e51058343bd (which will be pushed

Re: [flac-dev] [PATCH] two patches of doubtful usefulness

2014-07-03 Thread Erik de Castro Lopo
lvqcl wrote: > 1) > lpc.c, FLAC__lpc_quantize_coefficients(): > 2) > There's the following code in stream_decoder.c: Like you, I don't see a lot of value in these. I think I'll decline these. Cheers, Erik -- -- Erik de Castr

[flac-dev] [PATCH] uint64 -> double conversion

2014-07-03 Thread lvqcl
Erik de Castro Lopo wrote: I think I've fixed this in commit e51058343bd (which will be pushed soon). Not quite ;) You missed the fact that this .vcproj file contains 2 different settings: one for Debug build and another for Release build. The patch that fixes Release build is attached. vcpr

[flac-dev] [PATCH] remove MSVC6 workaround

2014-07-03 Thread lvqcl
This patch removes MSVC "spoon feeding". no_vc6_workaround.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] two patches of doubtful usefulness

2014-07-03 Thread lvqcl
Erik de Castro Lopo wrote: >> There's the following code in stream_decoder.c: > > Like you, I don't see a lot of value in these. I think I'll decline > these. FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4 and if it's greater then it jumps to FLAC__lpc_restore_signal_asm_i

Re: [flac-dev] [PATCH] two patches of doubtful usefulness

2014-07-03 Thread Miroslav Lichvar
On Thu, Jul 03, 2014 at 04:21:59PM +0400, lvqcl wrote: > Erik de Castro Lopo wrote: > > >> There's the following code in stream_decoder.c: > > > > Like you, I don't see a lot of value in these. I think I'll decline > > these. > > FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument wit

Re: [flac-dev] PPC asm is disabled since Jan 2005? Why?

2014-07-03 Thread lvqcl
lvqcl wrote: > FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4 > and if it's greater then it jumps to FLAC__lpc_restore_signal_asm_ia32. > > I wonder why the same wasn't done for PPC/Altivec: why libFLAC compares > 'order' and 8 in C code and not in asm. ...more about PPC A

[flac-dev] [PATCH] Update website links

2014-07-03 Thread Martijn van Beurden
One more (big) website patch http://www.audiograaf.nl/misc_stuff/0001-Update-links-and-news.patch.gz This one adds quite a few new stores to the links page, alters a few images and adds one new item ___ flac-dev mailing list flac-dev@xiph.org http://

Re: [flac-dev] [PATCH] remove MSVC6 workaround

2014-07-03 Thread Erik de Castro Lopo
lvqcl wrote: > This patch removes MSVC "spoon feeding". Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://li

Re: [flac-dev] [PATCH] Update website links

2014-07-03 Thread Erik de Castro Lopo
Martijn van Beurden wrote: > One more (big) website patch > > http://www.audiograaf.nl/misc_stuff/0001-Update-links-and-news.patch.gz > > This one adds quite a few new stores to the links page, alters a > few images and adds one new item Applied. Thanks. Erik -- -

Re: [flac-dev] [PATCH] uint64 -> double conversion

2014-07-03 Thread Erik de Castro Lopo
lvqcl wrote: > Not quite ;) You missed the fact that this .vcproj file contains 2 different > settings: one for Debug build and another for Release build. > > The patch that fixes Release build is attached. Thanks! I should have probably left that to you so you could test it. Cheers, Erik -- -